Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp464070rdb; Mon, 29 Jan 2024 07:38:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5XstrPH9GTVuzTmC2vs/AN5CAq4p//JOqK6ZIYVh0enRx8mYLWmeAJxmzcpNJRuuso6lV X-Received: by 2002:a05:6a20:8409:b0:19c:972d:3e9 with SMTP id c9-20020a056a20840900b0019c972d03e9mr2737371pzd.48.1706542737042; Mon, 29 Jan 2024 07:38:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706542737; cv=pass; d=google.com; s=arc-20160816; b=nLGPHX0EHBfW+VS663MQ6eCeVejTFp0uOmyrtV9MatoUODWb4Jfs6Ctxu6iOGOQXnG KCNBR8Ab8YHHf4SH6qq2s1HELeK+tRnzHaaM4pi7T5on3K8Io2Ts1x74ClHpjyHCvLyF H5cpR5ubXUaFKlLn7On5UgNzYttjWfkt6q8JDUaU1Xs5YUujAffVEjJSGV6rB4bF0YEm iIG9vf953njYMS1GAv0A5wK9uo3kzKRI/mdxHtUu/FW9tiX0X3eEhKYHwJUgOK8nwBlY YxfLBYq/ElsP5b/9BGbuvwwZmqpzTcrIoU8SESqBpFwaUIt3ooDYQF5uc0QkoyzGgZ74 ztUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=SJoEFXjr7hn9xQSS9bjXAJ5NY2siZ9HRTsnvbE0mvfc=; fh=IpN3Qt/qTloTgyuTZfB3eE8AmG6NvJdfp+Ea+uoGtRo=; b=SJMBQlxuZ0eLYKfhYYEIKniKkRLI/6LvhdxXV5V/TezDQEfRzrHL8hukUA7GRdkiVd aJ/KQRrp7YLN99p8WtE3QqvS/dXH61pWSx6Ru3DUfi0andjQ/wKqKagJntcIWqZ+SfrX UsEOi4r/m41FMQZ4lM2Ut4LMgFWcSsv9Phm5fgMWuP2jp9HiA9WxzZX2ENXsiXSWkXwZ 5QIMDar2zsuriJyK0HgTSnokW6IxjwP7Qu+HDhQWoHbjAx/WHQoMDf1HY69uO3SPIuwL fZUscGgN/jstf9oL3ZSaC/wm96JVxWsg/S2ZSRHgya7Hun3oin2lI+hT5P5f/2V3qWCr qSHA== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=molgen.mpg.de); spf=pass (google.com: domain of linux-bluetooth+bounces-1452-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-1452-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id k79-20020a628452000000b006dbc98ff8desi5943552pfd.147.2024.01.29.07.38.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 07:38:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1452-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=molgen.mpg.de); spf=pass (google.com: domain of linux-bluetooth+bounces-1452-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-1452-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5682E283630 for ; Mon, 29 Jan 2024 15:38:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A71D154436; Mon, 29 Jan 2024 15:38:38 +0000 (UTC) X-Original-To: linux-bluetooth@vger.kernel.org Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B769F66B42 for ; Mon, 29 Jan 2024 15:38:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=141.14.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706542718; cv=none; b=CmTHXTX3A7McDaFoVcAsULZ8A6N1+xbSm1NLvLCGdCtDvPLbSr4AFwffBktTLHg2JzYjuItXbypl0B8taYKsJELmnG+0gAreGiSRSxGhedQOcs6fGkdofBCR44KfiELSV12qPJDp08tasY0flBRR0dKLjIEBKUOcECYWsB5AwKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706542718; c=relaxed/simple; bh=GOIH/21FBASTsUWYFZRoC9rpjITH9UsVURsCwH41pfk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rsPKyMxHqdxdYbdeB3BV5e2nCAoJ5Uxf3kqmf6VJxRJWQUYZoe2NEUZ2MiUL2PeU2jCGWR4cFWmvwAQ1jiZCtZIxgKkNXMkDlFVBUWkqHSZ8t5PClGba7e8rqrjDLelFMkZWFbzR7Pldg0TVz2S9uZhrcNghqvGdqXVD9t8bo4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de; spf=pass smtp.mailfrom=molgen.mpg.de; arc=none smtp.client-ip=141.14.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=molgen.mpg.de Received: from [141.14.220.34] (g34.guest.molgen.mpg.de [141.14.220.34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 8317761E646C7; Mon, 29 Jan 2024 16:38:28 +0100 (CET) Message-ID: <16304943-3d04-40c8-86e8-f60aa1d96ea3@molgen.mpg.de> Date: Mon, 29 Jan 2024 16:38:27 +0100 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH BlueZ v4 8/8] android: export only (android) entrypoint from the modules Content-Language: en-US To: Emil Velikov Cc: emil.l.velikov@gmail.com, linux-bluetooth@vger.kernel.org References: <20240129-rm-ext-plugins-v4-0-bfd1e08c7f99@gmail.com> <20240129-rm-ext-plugins-v4-8-bfd1e08c7f99@gmail.com> From: Paul Menzel In-Reply-To: <20240129-rm-ext-plugins-v4-8-bfd1e08c7f99@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Dear Emil, Thank you for your patches. One small nit. Am 29.01.24 um 15:44 schrieb Emil Velikov via B4 Relay: > From: Emil Velikov > > The android specific modules, have a designated HMI entrypoint. Hide The comma seems superfluous. > everything else with -fvisibility=hidden. > --- > android/Makefile.am | 3 +++ > android/hal-audio.c | 1 + > android/hal-bluetooth.c | 1 + > android/hal-sco.c | 1 + > 4 files changed, 6 insertions(+) […] Kind regards, Paul