Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1470-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240129204154.95773-1-VAnPushkarev@salutedevices.com> <20240129204154.95773-3-VAnPushkarev@salutedevices.com>
In-Reply-To: <20240129204154.95773-3-VAnPushkarev@salutedevices.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Mon, 29 Jan 2024 16:06:40 -0500
Message-ID: <CABBYNZK7Eb18d5tV57yhWsyuRmk-zBQptULs7nOVn_F8bjWN4A@mail.gmail.com>
Subject: Re: [PATCH BlueZ v1 2/2] a2dp: Reject connection when the channel
 limit is exceeded
To: VAnPushkarev@salutedevices.com
Cc: linux-bluetooth@vger.kernel.org, sdfw_system_team@salutedevices.com, 
	corvinus.v@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Jan 29, 2024 at 3:42=E2=80=AFPM Victor Pushkarev
<VAnPushkarev@salutedevices.com> wrote:
>
> Reject incoming connection when the configured limit
> for A2DP channels is exceeded.
>
> Signed-off-by: Victor Pushkarev <VAnPushkarev@salutedevices.com>
> ---
>  profiles/audio/a2dp.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
> index b43161a13..117b27db3 100644
> --- a/profiles/audio/a2dp.c
> +++ b/profiles/audio/a2dp.c
> @@ -2549,6 +2549,14 @@ static void confirm_cb(GIOChannel *io, gpointer da=
ta)
>         if (!chan)
>                 goto drop;
>
> +       if (btd_opts.a2dp.channels &&
> +                               queue_length(server->channels) > btd_opts=
.a2dp.channels) {
> +               device_request_disconnect(device, NULL);
> +               DBG("Reject current connection, A2DP channel limit exceed=
ed: %d",
> +                                               btd_opts.a2dp.channels);
> +               goto drop;
> +       }

NAK, this is the wrong layer to do this, it is up to the MediaEndpoint
implementation to tell how many streams it can handle.

>         chan->auth_id =3D btd_request_authorization(&src, &dst,
>                                                         ADVANCED_AUDIO_UU=
ID,
>                                                         auth_cb, chan);
> --
> 2.39.3 (Apple Git-145)
>
>


--=20
Luiz Augusto von Dentz