Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2962769rdb; Tue, 6 Feb 2024 03:10:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTXcUUugXVF5UDZV4DiSUrN0wZKVjeLmdo4iohrpOmmeAP85RBuou34OH0b28CdSNudH/6 X-Received: by 2002:ad4:5767:0:b0:68c:8b9e:b452 with SMTP id r7-20020ad45767000000b0068c8b9eb452mr2811585qvx.37.1707217845760; Tue, 06 Feb 2024 03:10:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707217845; cv=pass; d=google.com; s=arc-20160816; b=YXyuQUrNBW5lTAqQZXOG696VjopaXeqCrnyf32gUElUzmxLx1Ano94726/BSAVqsPb n0dVk7h1e5gKI0GOP0e3LOgYmMXHUeqZuiKoTPxzEODl4+lKEO0QzYQj6Pr6Ym4qJn+t V4ElU25t2XqxX8CfclU4Xtwb0xHugB7zKVQ0Srl2TwP5ayQtTonPmt0dJCFqBZxNFZbB XeOaJgl2hWCHsme0oqM9shL3hgEOxCVg8y8BdD7OaV+LKxUUmxw6boqggBJMfLLO14RN S1SW2CMDowiqZsULDlIFcyjmtVHKTAouHYxUrE5cb/cu5fOJeca5Uvgq/iCHUkTCj8N0 NwhQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=O32+myH/Zjt7SPI7DuEt8DrMl74Rc1lFtgV5YuhcNqg=; fh=Orm9IaKBUbbQLwXAwZ5WqQGKTQ6N96PB4jRlNGb5aU0=; b=M8lK8d0dr0+Ao/isAzZ1T1+sKPk4LpSyoCSMLn2Z5P7SEKALcWLVtTUVKPawRXLhSM CKOYECVpEioo4eU3NbxjqKB+LTXWa/zKD5wWWfziLTR3J1roPoYmNAw/KLbHdp1N6rz7 mdyGMovaPb+fv8Dug2M5bw5VB/qHbnwAZAcyzPcjsDCoeTfMfU0MqOp1gPII1LoOXowE 6pqIxVVvFYKhGk/zMdP30RD5sNVi/hDlOxZK3jQ88ZfqRAzkibalUMi3JNKDMvmp33jc 6Ks/SFAmLq4vB+5NgbPNcWETbd6fhwf1QdoJQ6yUZE+oAis73Su+rgAHH2nPj4XjCj2/ 6cfw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=v0yd.nl); spf=pass (google.com: domain of linux-bluetooth+bounces-1625-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-1625-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCUUSUbV/SAsKY/SQHXBZydpzEJAohR8CTw2jqmrsVkLEPBE4bQHA1CgvzYK/ecqQ+vJ1NNH8T9bNjyoEeNhN7IY4G53pl7J8iNaJmJisw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m10-20020a0ce8ca000000b0068ca70c38bbsi2130690qvo.104.2024.02.06.03.10.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 03:10:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1625-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=v0yd.nl); spf=pass (google.com: domain of linux-bluetooth+bounces-1625-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-1625-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 38BF81C23CA9 for ; Tue, 6 Feb 2024 11:10:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BF79012FF91; Tue, 6 Feb 2024 11:08:26 +0000 (UTC) X-Original-To: linux-bluetooth@vger.kernel.org Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE53E12F5A4; Tue, 6 Feb 2024 11:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707217706; cv=none; b=IMI1UOk9H14eUrpPQLV6I01paFq74L0qoyHL0InoIZFyEtnvSmrlYe0HPBFc+Y8Psf88v75wwJjPMpOMP76U2zWiQM7LZrGFthHszwkxERky4XyyE6gu76eQXJB1+VDvZWclyg+L9jgSz4XOgLcgKgpZGhr+nwPAOCCETODksKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707217706; c=relaxed/simple; bh=H0qiN5y21fJHbc3Gsib/vVUqbIRS/mAwqCfl/lTb+XQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=kulBcB0QG4p9SHR7ddU8sWSE4XlC2zpBHEJ0umKZmw32GzHhAkr2XZRUt3F4Fd6OuvyIkX4M44d2d6/VBFNo41Yce6bKJ9kkICB7vXfwfmoJCJry15rX8WppNNxZG1E5UEydbqMEHmss8SRFmvyzSqbL8v69aG9RzvX3hZo8vNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=v0yd.nl; spf=pass smtp.mailfrom=v0yd.nl; arc=none smtp.client-ip=80.241.56.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=v0yd.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=v0yd.nl Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4TTgTb2ztYz9sX2; Tue, 6 Feb 2024 12:08:19 +0100 (CET) From: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Cc: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v4 0/2] Bluetooth: Improve retrying of connection attempts Date: Tue, 6 Feb 2024 12:08:12 +0100 Message-ID: <20240206110816.74995-1-verdre@v0yd.nl> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since commit 4c67bc74f016 ("[Bluetooth] Support concurrent connect requests"), the kernel supports trying to connect again in case the bluetooth card is busy and fails to connect. The logic that should handle this became a bit spotty over time, and also cards these days appear to fail with more errors than just "Command Disallowed". This series refactores the handling of concurrent connection requests by serializing all "Create Connection" commands for ACL connections similar to how we do it for LE connections. --- v1: https://lore.kernel.org/linux-bluetooth/20240102185933.64179-1-verdre@v0yd.nl/ v2: https://lore.kernel.org/linux-bluetooth/20240108183938.468426-1-verdre@v0yd.nl/ v3: https://lore.kernel.org/linux-bluetooth/20240108224614.56900-1-verdre@v0yd.nl/ v4: - Removed first two commits since they are already applied - Removed a BT_DBG() message in the acl_create_connection() function while moving to hci_sync because it seemed out of place in hci_sync - Added a mention of the test failure in mgmt-tester to commit message Jonas Dreßler (2): Bluetooth: hci_conn: Only do ACL connections sequentially Bluetooth: Remove pending ACL connection attempts include/net/bluetooth/hci.h | 1 + include/net/bluetooth/hci_core.h | 1 - include/net/bluetooth/hci_sync.h | 3 ++ net/bluetooth/hci_conn.c | 83 +++----------------------------- net/bluetooth/hci_event.c | 21 ++------ net/bluetooth/hci_sync.c | 70 +++++++++++++++++++++++++++ 6 files changed, 86 insertions(+), 93 deletions(-) -- 2.43.0