Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1638-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240202213846.1775983-1-luiz.dentz@gmail.com>
 <f40ce06c7884fca805817f9e90aeef205ce9c899.camel@redhat.com> <CABBYNZJ3bW5wsaX=e7JGhJai_w8YXjCHTnKZVn7x+FNVpn3cXg@mail.gmail.com>
In-Reply-To: <CABBYNZJ3bW5wsaX=e7JGhJai_w8YXjCHTnKZVn7x+FNVpn3cXg@mail.gmail.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Tue, 6 Feb 2024 10:16:53 -0500
Message-ID: <CABBYNZLxbLtFM8A61H+Du1uGisCc7r155G9fFuGkF8X33Mgreg@mail.gmail.com>
Subject: Re: pull request: bluetooth 2024-02-02
To: Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, kuba@kernel.org, linux-bluetooth@vger.kernel.org, 
	netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Paolo,

On Tue, Feb 6, 2024 at 9:45=E2=80=AFAM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Paolo,
>
> On Tue, Feb 6, 2024 at 9:33=E2=80=AFAM Paolo Abeni <pabeni@redhat.com> wr=
ote:
> >
> > Hi,
> >
> > On Fri, 2024-02-02 at 16:38 -0500, Luiz Augusto von Dentz wrote:
> > > The following changes since commit ba5e1272142d051dcc57ca1d3225ad8a08=
9f9858:
> > >
> > >   netdevsim: avoid potential loop in nsim_dev_trap_report_work() (202=
4-02-02 11:00:38 -0800)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.g=
it tags/for-net-2024-02-02
> > >
> > > for you to fetch changes up to 96d874780bf5b6352e45b4c07c247e37d50263=
c3:
> > >
> > >   Bluetooth: qca: Fix triggering coredump implementation (2024-02-02 =
16:13:56 -0500)
> > >
> > > ----------------------------------------------------------------
> > > bluetooth pull request for net:
> >
> > A couple of commits have some issue in the tag area (spaces between
> > Fixes and other tag):
> > >
> > >  - btintel: Fix null ptr deref in btintel_read_version
> > >  - mgmt: Fix limited discoverable off timeout
> > >  - hci_qca: Set BDA quirk bit if fwnode exists in DT
> >
> > this one ^^^
> >
> > >  - hci_bcm4377: do not mark valid bd_addr as invalid
> > >  - hci_sync: Check the correct flag before starting a scan
> > >  - Enforce validation on max value of connection interval
> >
> > and this one ^^^
>
> Ok, do you use any tools to capture these? checkpatch at least didn't
> capture anything for me.

So I rebase it locally checking if each Fixes tag actually points to a
valid commit, all of them seem fine, what I found to be a little
different is that those 2 have an empty line added after them, is this
the problem?

> > Would you mind rebasing and resend the PR?
> >
> > Thanks!
> >
> > Paolo
> >
> >
>
>
> --
> Luiz Augusto von Dentz


--=20
Luiz Augusto von Dentz