Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1732-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240209164630.92208-1-andrei.istodorescu@nxp.com> <20240209164630.92208-7-andrei.istodorescu@nxp.com>
In-Reply-To: <20240209164630.92208-7-andrei.istodorescu@nxp.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Fri, 9 Feb 2024 17:22:45 -0500
Message-ID: <CABBYNZJ7s+0V83MCcBqrQFCXvGD+9mJPiFVYCL=zQaEMP1tPQA@mail.gmail.com>
Subject: Re: [PATCH BlueZ v2 6/6] shared/bap: Remove stream double configuration
To: Andrei Istodorescu <andrei.istodorescu@nxp.com>
Cc: linux-bluetooth@vger.kernel.org, mihai-octavian.urzica@nxp.com, 
	silviu.barbulescu@nxp.com, vlad.pruteanu@nxp.com, iulia.tanasescu@nxp.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Andrei,

On Fri, Feb 9, 2024 at 11:46=E2=80=AFAM Andrei Istodorescu
<andrei.istodorescu@nxp.com> wrote:
>
> The stream configuration is done in bt_bap_stream_set_user_data.
> This will be cleaned in a later patch.

Hmm, I rather do the stream config with bt_bap_stream_config,
bt_bap_stream_set_user_data shall not attempt to change the stream
state, actually that might be why there are some warnings with bcast
since it no longer protecting the bap reference which is something Ive
recently introduced while introducing bt_bap_stream_ops.

> ---
>  src/shared/bap.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/src/shared/bap.c b/src/shared/bap.c
> index b88fc60842a3..133711e99d71 100644
> --- a/src/shared/bap.c
> +++ b/src/shared/bap.c
> @@ -1677,12 +1677,6 @@ static unsigned int bap_bcast_config(struct bt_bap=
_stream *stream,
>                                      bt_bap_stream_func_t func, void *use=
r_data)
>  {
>         stream->qos =3D *qos;
> -       if (stream->lpac->type =3D=3D BT_BAP_BCAST_SINK) {
> -               if (data)
> -                       stream_config(stream, data, NULL);
> -               stream_set_state(stream, BT_BAP_STREAM_STATE_CONFIG);
> -       }
> -
>         return 1;
>  }
>
> --
> 2.40.1
>


--=20
Luiz Augusto von Dentz