Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2663457rdb; Mon, 12 Feb 2024 12:03:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBvfFHbtjafuo//cSAeRQ3ZFDSN0FfZdhzDfIAxho4xUgqZu3dRohEb6y3EoajS6tsSYw7 X-Received: by 2002:a17:90a:d30e:b0:297:1af6:cd3f with SMTP id p14-20020a17090ad30e00b002971af6cd3fmr3400246pju.43.1707768205076; Mon, 12 Feb 2024 12:03:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707768205; cv=pass; d=google.com; s=arc-20160816; b=xU9o3nCnZ0eJw7bSnV/exahc0JmDKnK9Wd8aA2bFnV5sJ3c/60Zeorjz8H9T0Xrua2 NT8CCoTQHyUXG5uJOnMpTzQCUNFLP/yU8WSNSuMR6pwwYA4jk9ew92vXVb3jFxKV4Cr+ ZD5V4wudTocZK3WQ24xmQPT9eLJfCZD/VAHWdEAOXFrnrwqjJD0zJdLkJf+QVNkfaBTz qfHIUmmFgcRczQY9I4k+pwnYuq0wdtLE55ivJSbuohR5V2uknoMdwsFVHm2P0Leiu0HJ av2k+z9XS/zQHu6FEZay0f4kj5/rgLotOe2bG2HpDscXlbkq+3jSiFS099t2QzyNWRgK x2Pg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=reply-to:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:date:from:dkim-signature; bh=+2SdOyTvem1XDhZA2xP84bATZdYSf6Hw6BY7xqYjawo=; fh=74wtleTZqUumcLfS7aH5JIW36u/BjluZ7vm+PGr5HvQ=; b=toCLLBFvySuaY0fw8cRYoVDM3vEdWYvjhEQni1kZ4oTX5HzhSm1OfTehLJMBJ5IIsb c+qISRI/zYYIngQLc8nwtImx5VMn1hVNZJim0pWab4a7++XZkKIc/4kTtn/GEeNI7h5c lPrPNrcuAu+R5NnbshwqLXlMJonivtscaKR6vMepjoS6GZcCpHqlSj3VtSrZe7EnOrJk U5JjwOUIH8sYhw+FR6u97HfC+cHp9nkDgZYQWeTU69d+8PBF6odX1guJm/d9Y1lDDSWM 5wjYVCSxXLIQnk6tWEjyUDSTrrHsgyvhkcoB/VARg7W44s21TOoujiFNcsT0kEiNo8SA zLSw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LMw99xJt; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-1788-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-1788-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVguaEDocvmI6fZ1QMdJBkFbDfA3XfbszQVf7mfSKUtnNipsAbLbg+WJm+3f5Q7NKa/HwEHtc7SOggCiQqQcELcCoE4imCXQm/XAcOPNA== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id i21-20020a17090acf9500b00295aa8431a4si724192pju.24.2024.02.12.12.03.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 12:03:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1788-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LMw99xJt; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-1788-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-1788-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 2376EB20EF6 for ; Mon, 12 Feb 2024 20:02:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DFD6C481DE; Mon, 12 Feb 2024 20:02:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LMw99xJt" X-Original-To: linux-bluetooth@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F01947774 for ; Mon, 12 Feb 2024 20:02:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707768160; cv=none; b=E5eJLczSuvVlX9FpsXbUyw6XzaF0RuYLt8VudLNHsOxkSE9yne8j41X4tbDvcGnI+k1K4h79wJHRhJzz+9UKHbEL3HOxpNKlGdoqFph39snrdozfo5Hk8SH1eu0qkMy0jmUvU7TI+Ok4vhQLbU6JzIKuGVKawJNPN/mPOYSScUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707768160; c=relaxed/simple; bh=CAquu6St9+YE/1js7fAfthjtnyafKD0QqkYrZLGZyVk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fXSBgqk0tt+MbXdbk8LwnOQPmUsFneWKX+dVpC+51MmQyXNkLiopimqXGDnBfBwhzey8MkNiLJn/+GIPWcbdjEwp0G/+vrocNUrFFaKmctAVeLos3Po82kXFMNgezyfTPFIoShid/otLBq/b8kFaPAqtQAYV/MTurTXLyaZgZ7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LMw99xJt; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id CD0DEC433F1; Mon, 12 Feb 2024 20:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707768159; bh=CAquu6St9+YE/1js7fAfthjtnyafKD0QqkYrZLGZyVk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=LMw99xJtzqZTC5ewyNSwUdnLDir28dZ5JKDG69WuSyaFwhwBJmcH5eyfTlLRRsiSZ gpn3V3jdCTDLXU7yhbEfOjUiAcMWZw29tqwbCRlae67nYaUGmcSrFb/dUElImburV0 hTf8e6rD6BX52NGO4VtYVcn8pFr3gmeBLlURwE08sePHajbp4/PG8yY5jTgsqs2Mgd 6iylsRQ7LwghudAgDbMPx1DfSXlEyWeDh4/cLf3nIsW862907FRgq8n5803BHNteas kW7gJocI3/SbzFqRaw/YlZN7N2bT1H57BrK6ztLm7fPzw/Coy2NPsYorWwCAvtqqa0 c0Az9ykjHkHGQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25C6C4829E; Mon, 12 Feb 2024 20:02:39 +0000 (UTC) From: Emil Velikov via B4 Relay Date: Mon, 12 Feb 2024 20:02:37 +0000 Subject: [PATCH BlueZ v2 01/10] Return at least the title attribute from player_list_metadata() Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240212-disto-patches-v2-1-8bab1bd08f4d@gmail.com> References: <20240212-disto-patches-v2-0-8bab1bd08f4d@gmail.com> In-Reply-To: <20240212-disto-patches-v2-0-8bab1bd08f4d@gmail.com> To: linux-bluetooth@vger.kernel.org Cc: Sam Lantinga X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1707768157; l=669; i=emil.l.velikov@gmail.com; s=20230301; h=from:subject:message-id; bh=bHLjtE0BG3PUYg6Jf5Zv16cafv879d0HdvZOTdHzrz4=; b=lPBdaDdiQpidYd3FrEXZfUvhbbag4qQnneh3NTvUU1h3AliGylEKB+1kEq0S7FyDiuzNgM6Rk P4sznH5RHq2AWWw/dc1KsyovnQo3mHWoaaKai7N4c+mXcd0ukyW6A1L X-Developer-Key: i=emil.l.velikov@gmail.com; a=ed25519; pk=qeUTVTNyI3rcR2CfNNWsloTihgzmtbZo98GdxwZKCkY= X-Endpoint-Received: by B4 Relay for emil.l.velikov@gmail.com/20230301 with auth_id=35 X-Original-From: Emil Velikov Reply-To: From: Sam Lantinga This fixes Bluetooth AVRCP certification test AVRCP/TG/MDI/BV-04-C, which requires a valid response from the get_element_attributes command. --- profiles/audio/avrcp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c index 439fa27a9..36ce01a14 100644 --- a/profiles/audio/avrcp.c +++ b/profiles/audio/avrcp.c @@ -1210,6 +1210,10 @@ static GList *player_list_metadata(struct avrcp_player *player) GUINT_TO_POINTER(str_to_metadata(key))); } + if (attrs == NULL) + return g_list_prepend(NULL, + GUINT_TO_POINTER(AVRCP_MEDIA_ATTRIBUTE_TITLE)); + return attrs; } -- 2.43.0