Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1873-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <CACvgo50dSAw_L3uC7WST_+9ixMWLBdfVJc8cQNQNZ48dWdUijw@mail.gmail.com>
 <CABBYNZLrg=gYTuzB=u60_AJPSQ6YVs87u1s47fjD6v7S45M3GA@mail.gmail.com>
In-Reply-To: <CABBYNZLrg=gYTuzB=u60_AJPSQ6YVs87u1s47fjD6v7S45M3GA@mail.gmail.com>
From: Emil Velikov <emil.l.velikov@gmail.com>
Date: Wed, 14 Feb 2024 19:15:07 +0000
Message-ID: <CACvgo519JTmp1B4pMGJzHyeVsKzBxyC9ODqq9SFmcxspEX7_yg@mail.gmail.com>
Subject: Re: Re: [PATCH BlueZ v2 00/10] Distribution inspired fixes
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, 
	Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 14 Feb 2024 at 18:01, Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Emil,
>
> On Wed, Feb 14, 2024 at 12:04=E2=80=AFPM Emil Velikov <emil.l.velikov@gma=
il.com> wrote:
> >
> > Hello Luiz,
> >
> > Due to a bug in the CI bot, I've scraped this off the ML. Hope it's
> > not too badly formatted :-)
> >
> > > Here is the summary with links:
> > >  - [BlueZ,v2,01/10] Return at least the title attribute from player_l=
ist_metadata()
> > >    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3Df2671bf8f=
951
> > >  - [BlueZ,v2,02/10] adapter: Remove experimental flag for PowerState
> > >    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3Dd3aeae79d=
e4b
> > >  - [BlueZ,v2,03/10] test: consistently use /usr/bin/env python3 sheba=
ng
> > >    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3Dd31f04aa9=
28a
> > >  - [BlueZ,v2,04/10] profiles: remove unused suspend-dummy.c
> > >    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3D1313351f7=
144
> > >  - [BlueZ,v2,05/10] obex: remove unused syncevolution plugin
> > >    (no matching commit)
> > >  - [BlueZ,v2,06/10] obex: remove unused mas/messages-tracker impl
> > >    (no matching commit)
> > >  - [BlueZ,v2,07/10] obex: remove phonebook tracker backend
> > >    (no matching commit)
> > >  - [BlueZ,v2,08/10] build: ship all config files with --enable-datafi=
les
> > >    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3Dbe0e79629=
9b0
> > >  - [BlueZ,v2,09/10] obex: Use GLib helper function to manipulate path=
s
> > >    (no matching commit)
> > >  - [BlueZ,v2,10/10] Allow using obexd without systemd in the user ses=
sion
> > >    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3Db16b19885=
c53
> >
> > Massive thanks for applying the above.
> >
> > Out of curiosity: is there anything wrong with the few remaining ones?
> > I had a look through the ML archives on lore.kernel.org as well as my
> > inbox and could not find any replies.
>
> I don't think we should remove the syncevolution and tracker backends,
> they shall probably be disabled first so we don't break platforms
> still using them. As for the GLib helper I don't think that is really
> needed, at least there doesn't seem to be a problem with current
> handling.
>

Unless I am missing something, all four backends/implementations are
effectively disabled and unused.

Ignoring the first that you've merged already, the other three are
syncevolution, messages-tracker, phonebook tracker. All of those obexd
specific and have been practically dead code for approximately 6
years. In particular ever since the obexd git repo was imported into
bluez, they were never wired into the build system.

In order to use them, one has to manually hack the bluez build system.
Furthermore for people using the release tarball, the source files for
syncevolution, messages-tracker are missing all together.
Based on my archeology session - distributions (Fedora, Gentoo, Arch,
Debian and OpenWRT at least) use the tarball and none of them change
the build system to support/enable these.

So I think they are pretty much safe to remove.

Will have another look at the GLib helper and reply inline, with a
specific example/failure mode.

Thanks again o/
Emil