Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1910-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Silviu Florian Barbulescu <silviu.barbulescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	iulia.tanasescu@nxp.com
Subject: [PATCH BlueZ v3 7/7] bap: Set generated BASE on all setups from the same BIG
Date: Thu, 15 Feb 2024 23:23:56 +0200
Message-Id: <20240215212356.310301-8-silviu.barbulescu@nxp.com>
In-Reply-To: <20240215212356.310301-1-silviu.barbulescu@nxp.com>
References: <20240215212356.310301-1-silviu.barbulescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ppUCoZuvcvIqL/n/JuvlDN/zkAl/rBW3EqY5Oy54fFYylNBi9Q3P03GTC8QR?=
 =?us-ascii?Q?JAVND7IVDmu2vZwlK1mYvOnoOOkGFxNAThD4mxcxSkrp9jIeSCXnsCgdYR8e?=
 =?us-ascii?Q?JpuDtKqOB6Ta6bfZLszixtnE8tqiFLoDfdH4x1wjqS0RNw2t7aM/zbL85lSv?=
 =?us-ascii?Q?Qhw5ux2CAaHjubev4ba8zY1iM2Lulo/xQSmknGTtVuPOAscuaUzwC/5if8hH?=
 =?us-ascii?Q?bQWpnXuDEQL6WvIzthIwfbaR0YLog+H/aYrpZ9Pz0xvG1LTWpkdAbrFAtvkk?=
 =?us-ascii?Q?Lw+9J1gWVVHUK0e1OrUvihATLzZrRVIR3VlbSjJYZxNTgsS44qmZyKGJmwUe?=
 =?us-ascii?Q?eaOfRiTa5rhMDX2Q++q8uDwPH79q6HygYlCrfHzSVMo/hodbxiGl/y0a71eU?=
 =?us-ascii?Q?PxoiXyY2mV3j6DW7r02D/AnPdbJl1TntsPdTCwqIFL71sNd3S91M6flmaeTf?=
 =?us-ascii?Q?+oNb83vR6b3WBKMDwa/wN5mCsRHVXE5jncBenXy9gk0KMyBz6Qgy28NBodTq?=
 =?us-ascii?Q?Q7T73RlPis70nCkYG3Yhe7NJ8cVec/YWxFj2i2bozrhgdkQHFD0Nwmgf0P/Y?=
 =?us-ascii?Q?M2lq872NytlVQsrHHcNjFAFZmD7ec6ABnxGJww76qb9UizMXuzWZA/jR7stg?=
 =?us-ascii?Q?xJsr6pi7b+lDYl6WvoBDnSKSNAklAEsb139O4p+bbUtEcwb140YVOU213ylP?=
 =?us-ascii?Q?iOqT4g+70y5N3I/6ItodcEXozTUIKM4G3qldjehBUhVpE+KuAzhvX/H9+q+4?=
 =?us-ascii?Q?wvdImlcJULyXvjmMj82XWqmMz4doNyYNHM9vNqUOtauak5VsgaIyoiiBO87C?=
 =?us-ascii?Q?DOEPQ7aQw9R9ZyZHt8iMk8rn/zIMsEHkrtuzmsCbxe2Db3iiP25VzS9dDJ6t?=
 =?us-ascii?Q?merlQbX3WC38QRFDmdutFz9cbpT9t4hdc3XmySeFXNO/a6F3qQHfVMOQlLsj?=
 =?us-ascii?Q?S88GG6pg+BZozzrJJr8MJNb7FW8J3WQiBs0l2bbFQO+1AdHSNVCK2vPBdB5p?=
 =?us-ascii?Q?uvwkiLwMd91lAE2UjY9t0bf6up7VxUm1g9l+3nQ+aIwf49fThd6lCi9szxAr?=
 =?us-ascii?Q?K0FS0mPDFWV+K2X+rzp7rl5x2sO6P5FnXvy+531XHu8YXj+LMvTbgcbYfcfJ?=
 =?us-ascii?Q?rDP2z4Z9vJQFEAVL1sJCR1R/rrm9Oh99+F93lXbNRLc/TyPglefBsBuxMVgo?=
 =?us-ascii?Q?PNFPy3QU0N9XLKgtWkfmdSyju/jpRFjp1oduyZH9Sm7X+ztyynnRMzCxjR1L?=
 =?us-ascii?Q?Mq/NK37UZ+HLhRkYVfuwG0JOsE/93Pzx67TlX8XxAbPKzyYblxoM4zyGQM92?=
 =?us-ascii?Q?Pax31FoWmxV7X7usnf7x2jcVkzRKXAVyaYylGifseRYe1ha3vEm6Qe+w1Z7B?=
 =?us-ascii?Q?txOXe12llQoHO/lcorfv3dJf81yLeTyX3ltFxcvGK8PzCTHWtMmqYQechDbh?=
 =?us-ascii?Q?LzE/TPQEtB2CB49vjHAu1OS1frEccnRpRoc+fobZydpltTNVDbroTUe8XRFR?=
 =?us-ascii?Q?umYdi9PKthRBtdgKIE65lKB9lg33D69+upFXYw8DFhr7DzRYT++rDy4mUXEx?=
 =?us-ascii?Q?NslhfLgnfhtsWvoKpRThjjO0b1HB90DRy4ao+eaQaERIaOoOAjwmx2X3y1DP?=
 =?us-ascii?Q?cw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad53f06f-5310-4a18-ed1f-08dc2e6c79a2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB10073.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 21:24:21.2780
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oromHn8pi5VGIzaYrkXM/HoJ10U5k8YHSFkr5X3StAlG8DQo63jU0vPnqzyugI9TtkEk6CAdV3zKX9tarkcRvYjd/0FtmIszeerhhFjPr+8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8275

Set the BASE generated in BlueZ on all setups from the same BIG,
and use defer to inform the kernel when to create the BIG.

---
 profiles/audio/bap.c | 160 ++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 144 insertions(+), 16 deletions(-)

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index b4acdd9ef..def5e1432 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -943,8 +943,12 @@ static DBusMessage *set_configuration(DBusConnection *conn, DBusMessage *msg,
 	if (dbus_message_iter_get_arg_type(&props) != DBUS_TYPE_DICT_ENTRY)
 		return btd_error_invalid_args(msg);
 
-	/* Disconnect IOs if connecting since QoS is going to be reconfigured */
-	ep_close(ep);
+	/* Broadcast source supports multiple setups, each setup will be BIS
+	 * and will be configured with the set_configuration command
+	 * TO DO reconfiguration of a BIS.
+	 */
+	if (bt_bap_pac_get_type(ep->lpac) != BT_BAP_BCAST_SOURCE)
+		ep_close(ep);
 
 	setup = setup_new(ep);
 
@@ -980,7 +984,6 @@ static DBusMessage *set_configuration(DBusConnection *conn, DBusMessage *msg,
 		if (bt_bap_pac_get_type(ep->lpac) == BT_BAP_BCAST_SINK)
 			setup->msg = dbus_message_ref(msg);
 		else {
-			setup->base = bt_bap_stream_get_base(setup->stream);
 			setup->id = 0;
 		}
 
@@ -1846,7 +1849,7 @@ static void setup_connect_io(struct bap_data *data, struct bap_setup *setup,
 static void setup_connect_io_broadcast(struct bap_data *data,
 					struct bap_setup *setup,
 					struct bt_bap_stream *stream,
-					struct bt_iso_qos *qos)
+					struct bt_iso_qos *qos, int defer)
 {
 	struct btd_adapter *adapter = data->user_data;
 	GIOChannel *io = NULL;
@@ -1883,7 +1886,7 @@ static void setup_connect_io_broadcast(struct bap_data *data,
 			BT_IO_OPT_MODE, BT_IO_MODE_ISO,
 			BT_IO_OPT_QOS, qos,
 			BT_IO_OPT_BASE, &base,
-			BT_IO_OPT_DEFER_TIMEOUT, false,
+			BT_IO_OPT_DEFER_TIMEOUT, defer,
 			BT_IO_OPT_INVALID);
 
 	if (!io) {
@@ -2012,9 +2015,6 @@ static void setup_create_bcast_io(struct bap_data *data,
 
 	memset(&iso_qos, 0, sizeof(iso_qos));
 
-	if (!defer)
-		goto done;
-
 	iso_qos.bcast.big = setup->qos.bcast.big;
 	iso_qos.bcast.bis = setup->qos.bcast.bis;
 	iso_qos.bcast.sync_factor = setup->qos.bcast.sync_factor;
@@ -2031,9 +2031,10 @@ static void setup_create_bcast_io(struct bap_data *data,
 	iso_qos.bcast.timeout = setup->qos.bcast.timeout;
 	memcpy(&iso_qos.bcast.out, &setup->qos.bcast.io_qos,
 				sizeof(struct bt_iso_io_qos));
-done:
+
 	if (bt_bap_pac_get_type(setup->ep->lpac) == BT_BAP_BCAST_SOURCE)
-		setup_connect_io_broadcast(data, setup, stream, &iso_qos);
+		setup_connect_io_broadcast(data, setup, stream, &iso_qos,
+			defer);
 	else
 		setup_listen_io_broadcast(data, setup, stream, &iso_qos);
 }
@@ -2121,11 +2122,77 @@ static void bap_state(struct bt_bap_stream *stream, uint8_t old_state,
 	}
 }
 
+/* This function will call setup_create_io on all BISes from a BIG.
+ * The defer parameter will be set on true on all but the last one.
+ */
+static bool create_io_bises(struct bap_setup *setup,
+				uint8_t nb_bises, struct bap_data *data)
+{
+	const struct queue_entry *entry;
+	struct bap_setup *ent_setup;
+	bool defer = true;
+
+	for (entry = queue_get_entries(setup->ep->setups);
+				entry; entry = entry->next) {
+		ent_setup = entry->data;
+
+		if (bt_bap_stream_get_qos(ent_setup->stream)->bcast.big !=
+				bt_bap_stream_get_qos(setup->stream)->bcast.big)
+			continue;
+
+		if (bt_bap_stream_get_qos(ent_setup->stream)->bcast.bis ==
+				nb_bises)
+			defer = false;
+
+		setup_create_io(data, ent_setup, ent_setup->stream, defer);
+		if (!ent_setup->io) {
+			error("Unable to create io");
+			goto fail;
+		}
+	}
+
+	return true;
+
+fail:
+	/* Clear the io of the created sockets if one
+	 * socket creation fails.
+	 */
+	for (entry = queue_get_entries(setup->ep->setups);
+				entry; entry = entry->next) {
+		ent_setup = entry->data;
+
+		if (bt_bap_stream_get_qos(ent_setup->stream)->bcast.big !=
+				bt_bap_stream_get_qos(setup->stream)->bcast.big)
+			continue;
+
+		if (setup->io)
+			g_io_channel_unref(setup->io);
+	}
+	return false;
+}
+
+static void iterate_setup_update_base(void *data, void *user_data)
+{
+	struct bap_setup *setup = data;
+	struct bap_setup *data_setup = user_data;
+
+	if ((setup->stream != data_setup->stream) &&
+		(setup->qos.bcast.big == data_setup->qos.bcast.big)) {
+
+		if (setup->base)
+			util_iov_free(setup->base, 1);
+
+		setup->base = util_iov_dup(data_setup->base, 1);
+	}
+}
+
 static void bap_state_bcast(struct bt_bap_stream *stream, uint8_t old_state,
 				uint8_t new_state, void *user_data)
 {
 	struct bap_data *data = user_data;
 	struct bap_setup *setup;
+	bool defer = false;
+	uint8_t nb_bises = 0;
 
 	DBG("stream %p: %s(%u) -> %s(%u)", stream,
 			bt_bap_stream_statestr(old_state), old_state,
@@ -2146,14 +2213,75 @@ static void bap_state_bcast(struct bt_bap_stream *stream, uint8_t old_state,
 			queue_remove(data->streams, stream);
 		break;
 	case BT_BAP_STREAM_STATE_CONFIG:
-		if (setup && !setup->id) {
-			setup_create_io(data, setup, stream, true);
+		if (!setup || setup->id)
+			break;
+		/* If the stream is attached to a
+		 * broadcast sink endpoint.
+		 */
+		if (bt_bap_stream_io_dir(stream) ==
+				BT_BAP_BCAST_SOURCE) {
+			setup_create_io(data, setup, stream, defer);
 			if (!setup->io) {
 				error("Unable to create io");
-				if (old_state != BT_BAP_STREAM_STATE_RELEASING)
-					bt_bap_stream_release(stream, NULL,
-								NULL);
-				return;
+				if (old_state !=
+					BT_BAP_STREAM_STATE_RELEASING)
+					bt_bap_stream_release(stream,
+							NULL, NULL);
+			}
+		} else {
+			/* If the stream attached to a broadcast
+			 * source endpoint generate the base.
+			 */
+			if (setup->base == NULL) {
+				setup->base = bt_bap_stream_get_base(
+						setup->stream);
+				/* Set the generated BASE on all setups
+				 * from the same BIG.
+				 */
+				queue_foreach(setup->ep->setups,
+					iterate_setup_update_base, setup);
+			}
+			/* If there is only one BIS create the io
+			 * with defer false
+			 */
+			if (setup->qos.bcast.big == BT_ISO_QOS_BIG_UNSET) {
+				setup_create_io(data, setup,
+					stream, defer);
+				if (!setup->io) {
+					error("Unable to create io");
+					if (old_state !=
+						BT_BAP_STREAM_STATE_RELEASING)
+						bt_bap_stream_release(stream,
+								NULL, NULL);
+				}
+			} else {
+				/* The kernel has 2 requirements when handling
+				 * multiple BIS connections for the same BIG:
+				 * 1 - setup_create_io for all but the last BIS
+				 * must be with defer true so we can inform the
+				 * kernel when to start the BIG.
+				 * 2 - The order in which the setup_create_io
+				 * are called must be in the order of BIS
+				 * indexes in BASE from first to last.
+				 * To address this requirement we will call
+				 * setup_create_io on all BISes only when all
+				 * transport acquire have been received and will
+				 * send it in the order of the BIS index
+				 * from BASE.
+				 */
+				nb_bises = bt_bap_get_streams_by_state(
+					setup->stream,
+					BT_BAP_STREAM_STATE_CONFIG);
+
+				if (!nb_bises)
+					break;
+
+				if (!create_io_bises(setup, nb_bises, data)) {
+					if (old_state !=
+						BT_BAP_STREAM_STATE_RELEASING)
+						bt_bap_stream_release(stream,
+							NULL, NULL);
+				}
 			}
 		}
 		break;
-- 
2.39.2