Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp294642lqg; Fri, 1 Mar 2024 05:40:16 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWThglzz1Bh4RuNG/P/iBGF1/ekyUPMNoUIoZfjuSTY/PcTC1eUz/BsImZduelMNz2ebzdV/Iv+GT67lxCuDkME4BUWT+qtc6oirICuvA== X-Google-Smtp-Source: AGHT+IE1oybrKQwiN/za22o2Fi8DAM5jKvsJ2dZY1ATMEyUJNudjdquKlVtBveBK4NF6bgUNrvoU X-Received: by 2002:a05:6a20:a11e:b0:1a1:1f7b:5214 with SMTP id q30-20020a056a20a11e00b001a11f7b5214mr2634523pzk.15.1709300415869; Fri, 01 Mar 2024 05:40:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709300415; cv=pass; d=google.com; s=arc-20160816; b=Iwjp4TzemoOgvMl7SUzR04A2CVJqw81sVyjmcA08iIEVwSte6Oc2FwsoLStRltU5rs vSf//Ja6IjxMvF0rkYda71E8ng5BsMUw4G0OJUxMJpsXsETsicd17oSLGtIkNnVz3m/N rZc3EE0cGQY5GfApopGGuZDGlRwSxye5hD4YGDZlLUS5fy8VaDry/Rxui5YHdnB5CY1O c8MWjywubR2WXBmlvBa8EhqqbkKawF4J8uTbu7iqHP6MYmB1JuLnHyqv2HD4Z8Qz+QFu kclcWRMULj9JA+hkVAypz00cgU64cclVgvi6T3zGZ5r/KYcdu2GyPnuBZvJs8wMfX5UK DUug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=dqM/7Huxurjj326o312CY70Gh/3WcV1rHKV4Be0fCEk=; fh=vS2DIshGwiXnQOBX+JfohZLp+LIEjgFwWtpde/H2ycQ=; b=e2P7B0BBm1A/CcmIeNQMxs/OvBa+8eVM7IjUQV+35cnS8VSMDI25MvnKXczkyh7Af7 g9qw3CZu64F1rLrqAzOg5URoyAYcYh/eHGbQMEC38MbUDaFXoetzk5WB3vcjzbodje+e Z9fX4fYVqNE2cAmWkn1UC+gbiIzkjE5nDbvYgrjUD3KsPGsl+XWVADIXJlfvmzrkjKnz oi1q7VTlUEHjz8MrfebhHVBiZhWQ0MYgyM0RUbcvUHPDLbIxt7/YUU7MMm9zRGDdCgaj uoVUmaml26BGcoLIt9x3yH7Xuu2W2jqbVpguDl49gUOG9jqjnVdfsb8KSNXRXjbMmYll PC9g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-bluetooth+bounces-2228-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-2228-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id t124-20020a628182000000b006e56d76ca22si3467743pfd.140.2024.03.01.05.40.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 05:40:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2228-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-bluetooth+bounces-2228-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-2228-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7DBB1281AED for ; Fri, 1 Mar 2024 13:40:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 74B896EEFB; Fri, 1 Mar 2024 13:39:50 +0000 (UTC) X-Original-To: linux-bluetooth@vger.kernel.org Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 856F56D50A; Fri, 1 Mar 2024 13:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709300390; cv=none; b=Ib+H7qM0NQI/+EU9+s/2zYeAbqlnclfpcH6lQ7MHBOae9U/fuT9aB3/itOiA7EdB+/+qnsyBXJoIhUWDNlwm3qLJExeMtUnIrHW9HWBD0cBxU3mWxg9AYx/IR+mkYB8KWwtirxWhtOKejOewUOViu6Gpkqvm1I7yWuxZhil+CKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709300390; c=relaxed/simple; bh=Sh9E/gkk6zKcCqGFDs3nWgIrwzR1EwNjJIGq/iqvfnU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e7IoCqJNyw1opBQeTtT80w6yLo6ydA7uFyDud9TzXy2VfnSleYoJ09mqP0eOT73ajE642Lr7bTtaJqsffelY9TfO5ms4GHB677R9DLhppAcS6o4N8vTmkmOE05ziY5cRSb8KStgZOQtnBUInA3zScYOkp5H1XIg9645ZYUlVFmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from r.smirnovsmtp.omp.ru (10.189.215.22) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Fri, 1 Mar 2024 16:39:34 +0300 From: Roman Smirnov To: Marcel Holtmann CC: Roman Smirnov , Johan Hedberg , Luiz Augusto von Dentz , Sergey Shtylyov , , , Subject: [PATCH v2 1/2] Bluetooth: mgmt: remove NULL check in mgmt_set_connectable_complete() Date: Fri, 1 Mar 2024 13:39:15 +0000 Message-ID: <20240301133916.1268403-2-r.smirnov@omp.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240301133916.1268403-1-r.smirnov@omp.ru> References: <20240301133916.1268403-1-r.smirnov@omp.ru> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 03/01/2024 13:19:36 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 183893 [Mar 01 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: r.smirnov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;omp.ru:7.1.1;r.smirnovsmtp.omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 03/01/2024 13:26:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 3/1/2024 10:14:00 AM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Remove the cmd pointer NULL check in mgmt_set_connectable_complete() because it occurs earlier in set_connectable(). This check is also unnecessary because the pointer is dereferenced just before it. Found by Linux Verification Center (linuxtesting.org) with Svace. Signed-off-by: Roman Smirnov Reviewed-by: Sergey Shtylyov --- net/bluetooth/mgmt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index bb72ff6eb22f..cd8c4e094c55 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -1702,8 +1702,7 @@ static void mgmt_set_connectable_complete(struct hci_dev *hdev, void *data, new_settings(hdev, cmd->sk); done: - if (cmd) - mgmt_pending_remove(cmd); + mgmt_pending_remove(cmd); hci_dev_unlock(hdev); } -- 2.34.1