Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2235-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Andrei Istodorescu <andrei.istodorescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: luiz.dentz@gmail.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	iulia.tanasescu@nxp.com,
	Andrei Istodorescu <andrei.istodorescu@nxp.com>
Subject: [PATCH BlueZ v5 4/6] shared/bap: Do stream configuration in bap_bcast_config
Date: Fri,  1 Mar 2024 17:00:27 +0200
Message-Id: <20240301150029.14386-5-andrei.istodorescu@nxp.com>
In-Reply-To: <20240301150029.14386-1-andrei.istodorescu@nxp.com>
References: <20240301150029.14386-1-andrei.istodorescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?SX+1iuyVNbc2WOWqpmemvSVUEhSeOx2fN2iRuoak3aKtdLnyTaXCppDl2RX/?=
 =?us-ascii?Q?QnmTbKhweh342KM7xumlACA6wCr94SdhTcxn7etT53t/TFlcqNQUZl9kK55w?=
 =?us-ascii?Q?qJpLaxXoRs5r+WqZ/VvGqi5FidGtr3xWwqABn61SQjDhFv1o2e6WmDFDRz7A?=
 =?us-ascii?Q?x2qJpXvrlAlbyOmT48z4mJix5mdoEuIJkAazA/VGHfrtH3mqseenWWiqgBCn?=
 =?us-ascii?Q?2LEGxYCXB4muyisA1GJtzCoB0v1RmU3jp+g5qA/FR+7Xe/Znp+MEIV0gY+OJ?=
 =?us-ascii?Q?Q6SSDtZxlWKqYep1ACqWTtu88yB27pjSbqmuuOp5X+jj8Xpxao/JvP/6wqs7?=
 =?us-ascii?Q?Z3f8NwSSwkKnm5EFEZcibELPZRAehFbpReVDlnEKiYbWm/bJDAp4H5SrRLLa?=
 =?us-ascii?Q?9frJMKD2wvwHxRXMy73mFnffNl84KH84y2nX8zFgCpEI0MRUJrg6M592i8Fp?=
 =?us-ascii?Q?MGrV2doUONkqK5XPeXyRWcm5cKbMji9GFUv7T+J5ePx4SKIipQHdTmD7UHKT?=
 =?us-ascii?Q?Yi74ySPl8oz0mVw+bME0kpSXtQoNUxm8hSwU9ymH0HPDsmmnixKnhMcTyqAE?=
 =?us-ascii?Q?Kgh0M/waWiOXxOkw+Hyha2M2hjv6hsq8KqXItDuH7N9HeP9OhOMEjmGzkZ2N?=
 =?us-ascii?Q?UhR422HrXDn1oHZfLKhBEa/cC3ZOTibyKM6gC5p82NUn4JWiJp+MhuX4rOCS?=
 =?us-ascii?Q?+yDiFj1ApydFeiLCxktsog/kisLo7mTJONOc/+x6bbhyOYslpSzWb+FVnZMo?=
 =?us-ascii?Q?Fygm1Y4hvf/FUnLUYnjQHl6jTTbDDiTS2QABeVDfNEaEXqG/rb6sqguZloXf?=
 =?us-ascii?Q?IM7ChmqiAPD+vCr0RFgSAGEK3wRwKKnbq1W8dbXEyABgvAoo8R2FfNJMSoCk?=
 =?us-ascii?Q?2aXhuJV/TVvnGkODWeIDcP9cegBFSAjtLNSJ+TO3puNInbgy4mn3MXQjj1P/?=
 =?us-ascii?Q?+Y0SgXxDD+KvSTul3gmx5rwtmLeenl27diFW9W9yvW1YZASVOaWxle6v5LH7?=
 =?us-ascii?Q?bUOOKygAI3WHHzJoF5mglVtuqbExL3G6+nA9oKzYDQdqVZbmE6nUuB3hdnSu?=
 =?us-ascii?Q?ZaMjssZYFRyjkIW5cjNkDZ5CiV9XWgZryPn/REnLVbgHehcnOhm6+LP0b2LD?=
 =?us-ascii?Q?6hJcbK3j34qFbeD+WjJQC8p1XUEhQRHbjmZ99sb+L8Qm63DozagpXUVewICI?=
 =?us-ascii?Q?cYJk39qqMx3s48LacTb+fbWuOPJNngG9sKhL7ZiPYBoOMnTPRocsO9Z25Yck?=
 =?us-ascii?Q?KnO7/lUG100WhDUdrsUhUeK1lzHnrAN2jOgfHIK3P6oOcsJpPUWDu6ycDj+H?=
 =?us-ascii?Q?SQhIXKW30glBuPUP0AMCuT37eXkHzqxNHF0dUbswBHFOcCC31sKVY8GBruaq?=
 =?us-ascii?Q?PSOciFQAx71kIA6hDQKoEOBsbDfgYOFpQTyfBuAM11Vh0bQhZbo74aKHFQVB?=
 =?us-ascii?Q?fpeUny2W8srZPwWJSgCyvpOvB70O6dozi5dxVs6WVEvfmnTOq93Pwvdra8CP?=
 =?us-ascii?Q?V86DESAF9DIMKu5+0An7NfGioBSiKlqV4x6KRwbeyMVm4sh3mfgU4WtXViUM?=
 =?us-ascii?Q?els1aDme9g/7tXTIvL9T2IIANvU7oQbZq/Qpicw8cMBsFYQnNeiCUWf9JKjP?=
 =?us-ascii?Q?WA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8113ee48-1e30-42fd-7d7a-08dc3a005e0a
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8938.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 15:00:43.3011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YXITEvptE7TIbEawdCJK1DYCkY7FbO++alw0ro3Uhik35WeAdzkL93Vlmk8brzCfmEjbrTNtey7HD1KCf20Np4XCoOhlh//jpVKXPGfZUW8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9837

Stream configuration for BAP broadcast streams should be done inside
bap_bcast_config and not when setting the user data.
---
 src/shared/bap.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 638c6f8a4947..50d03456e6cd 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -1693,11 +1693,8 @@ static unsigned int bap_bcast_config(struct bt_bap_stream *stream,
 				     bt_bap_stream_func_t func, void *user_data)
 {
 	stream->qos = *qos;
-	if (stream->lpac->type == BT_BAP_BCAST_SINK) {
-		if (data)
-			stream_config(stream, data, NULL);
-		stream_set_state(stream, BT_BAP_STREAM_STATE_CONFIG);
-	}
+	stream->lpac->ops->config(stream, stream->cc, &stream->qos,
+			ep_config_cb, stream->lpac->user_data);
 
 	return 1;
 }
@@ -5369,10 +5366,6 @@ bool bt_bap_stream_set_user_data(struct bt_bap_stream *stream, void *user_data)
 
 	stream->user_data = user_data;
 
-	if (bt_bap_stream_get_type(stream) == BT_BAP_STREAM_TYPE_BCAST)
-		stream->lpac->ops->config(stream, stream->cc, &stream->qos,
-					ep_config_cb, stream->lpac->user_data);
-
 	return true;
 }
 
-- 
2.40.1