Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2281-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Iulia Tanasescu <iulia.tanasescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: claudia.rosu@nxp.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [2/2] Bluetooth: ISO: Always release hdev at the end of iso_listen_bis
Date: Mon,  4 Mar 2024 18:50:50 +0200
Message-Id: <20240304165050.3430-3-iulia.tanasescu@nxp.com>
In-Reply-To: <20240304165050.3430-1-iulia.tanasescu@nxp.com>
References: <20240304165050.3430-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6bzyqRPWny3h0EPRZtXryD2/n/yQkxbgsYsn/ocyewUcAGCqPv/DocBTmBDH?=
 =?us-ascii?Q?DWWSCf8kTyZwIFBpMDe+c4HyP5xvUYUWiHGCIjMvu4ju8gZn3/mF3vEwkEgO?=
 =?us-ascii?Q?T4augwLJdiJsO+hsLJnXr219H0pBd2yCiTPI+6N6BqH7gYhjl1ORE5RZ6kKb?=
 =?us-ascii?Q?0tghSOS/+wIJBk6HXvgIpDi1sxtNXVnSnpbGCVkpRW7hHzarJJHODJ67IYAe?=
 =?us-ascii?Q?/cGWHz/GgM7o/Dr0cEr0TroWV/vdh9VzMdQM9VxbBXF29PAcOa5PMoiNuZ3S?=
 =?us-ascii?Q?2QTifLDIG3xQbCKZ7rTjV23dRZRryIntEwTpbsTZvWyMjGniHT/OZ+7w1Qx3?=
 =?us-ascii?Q?gJnvvwtw6rDEu8rYeFhIUS3rVpBkc1YE0jMlyP5I1902as7jdnZ7G4DOSX6s?=
 =?us-ascii?Q?iqjauV/PIAJtJbjf6qpTxvXZpFD2Gf6iLYx7VVCwLKyRpUFRIUPSyo0+oDfj?=
 =?us-ascii?Q?bPnlsLzZQGQLaV3UA+qKs/HILsC1MPHhIn2+cZMbMwPhJjoh+46gErZSnnrs?=
 =?us-ascii?Q?FtI/6IPhhiCj+xaQHmOM/jpbwrl4rVwaPo7SNGoLTKds16VtuYtnMOGRXAaf?=
 =?us-ascii?Q?f1nw+dDEQmjBo8f0RaWl4E5KQJLd2mpQCovRhdngE/QaYCGrc6biclLFNf69?=
 =?us-ascii?Q?+WkgsRBiYQB2M2zKccaoJWil0d27VqfCwN47yemlgzJmdfwu/z56Czq6BnwK?=
 =?us-ascii?Q?tOnSdJL/x4r4Z1Vg6G8WBoecGC3sfRz31uw3EMatOZ5brnyftnoviq/9GHut?=
 =?us-ascii?Q?HRPuL6Y2NAOhlMUbLFod741JwsKP7+44p+NKSe+SBRPzhRtl/t/x2C1y5ono?=
 =?us-ascii?Q?Gdx9+XtPX0bOVSd3Gok5y5e9zu+RVrY3eUFIXrOwmsoIHCQ4GQf74GNOFQv4?=
 =?us-ascii?Q?N0L/PUVY0pSSu8YWhB3abX8KoI5a7ZikeOQdsUVqKAKCMRSOa/j7xxgaWD8/?=
 =?us-ascii?Q?S2uipcpiVExisi3hg+qJ3ooEBFbL6MojAOCIjPb1hPcXaUwstCESMF+RShbY?=
 =?us-ascii?Q?gIfAqr6uTFp9QKSLU0GQDLG1reNXl6Pt7DNDVJ6wczwke3y6T9fEJbmKuklv?=
 =?us-ascii?Q?ic/t/UBFs9+vEu49YY58Yf3XzymCq5ZstNpu57qEgsmVr6p6yeZfYsMydVAG?=
 =?us-ascii?Q?aPurIv3sLS9hTJuP0wOd6s5WhdNx7wBtCWRIFTUaXocu0dWHDOIW2Y1wDgB4?=
 =?us-ascii?Q?Ok+DBSij5kJ6JSwD24nG6XkgZap9XfptLkf4MMvclQN+VyE9OR/BYGPHjzCl?=
 =?us-ascii?Q?/gx8cdKemTR2MXLySSjHeOXI1zH4ZMuYzjNc+36WodofCT7LqVMF5pByi7cj?=
 =?us-ascii?Q?/ZyzG8nvJ6vHhCb8bSoylRDjV1iiP3iPXZtHw18vnQU2nvtiDYPUW9RCsWie?=
 =?us-ascii?Q?dR10QWj4HJdhAL2hz9oCXw4XhB7f27kTFVyIlDN5pnYn7FT2p9Qt7ab8na81?=
 =?us-ascii?Q?fRdyaKky8Jt80dvhQ9UKK5lKJ1MHepn5U3J7pjVGZBH1JwlZkxfWQGLFHEb6?=
 =?us-ascii?Q?TT2iUM7aCsTBVTGiHSOXAWadoZlIsCseuUVkqXspcURLrJeTGLPDFRgSCLMf?=
 =?us-ascii?Q?77dyv+MnhHEP5KIQjA2cXOVCTVgZ8kFF1xZ2v262+Y01+wD7B5sW5ryxavt+?=
 =?us-ascii?Q?cA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f217564-9c3b-4cc1-d9ea-08dc3c6b4ae9
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 16:51:09.6821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9E9eA3iZL6gJVHMUejYcp7mRQ5qZsDvjfYavXFYEIeF9yUncIHEz3q9hR0+9/A6ah42KntedrkGKV0BTBrtAvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7064

Since hci_get_route holds the device before returning, the hdev
should be released with hci_dev_put at the end of iso_listen_bis
even if the function returns with an error.

Signed-off-by: Iulia Tanasescu <iulia.tanasescu@nxp.com>
---
 net/bluetooth/iso.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c
index 163b07db575d..b1a211b75625 100644
--- a/net/bluetooth/iso.c
+++ b/net/bluetooth/iso.c
@@ -1131,13 +1131,13 @@ static int iso_listen_bis(struct sock *sk)
 		goto unlock;
 	}
 
-	hci_dev_put(hdev);
-
 unlock:
 	/* Unlock order should be in reverse from lock order. */
 	release_sock(sk);
 	hci_dev_unlock(hdev);
 	lock_sock(sk);
+
+	hci_dev_put(hdev);
 	return err;
 }
 
-- 
2.39.2