Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2286-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231018145540.34014-1-marcel@ziswiler.com> <20231018145540.34014-2-marcel@ziswiler.com>
 <ZWEG40nzRhm6oVEq@francesco-nb.int.toradex.com> <20240304165215.GA11208@francesco-nb>
In-Reply-To: <20240304165215.GA11208@francesco-nb>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Mon, 4 Mar 2024 12:34:24 -0500
Message-ID: <CABBYNZLaWadMieheoUV=XVXfBmJGsU4L_+k+MuNiP_oCsvrVnQ@mail.gmail.com>
Subject: Re: [PATCH v1 1/2] Bluetooth: btnxpuart: Fix btnxpuart_close
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>, linux-bluetooth@vger.kernel.org, 
	Sherry Sun <sherry.sun@nxp.com>, Johan Hedberg <johan.hedberg@gmail.com>, 
	Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>, linux-kernel@vger.kernel.org, 
	Marcel Holtmann <marcel@holtmann.org>, Marcel Ziswiler <marcel.ziswiler@toradex.com>, 
	Amitkumar Karwar <amitkumar.karwar@nxp.com>, =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>, 
	Marcel Ziswiler <marcel@ziswiler.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Francesco,

On Mon, Mar 4, 2024 at 11:52=E2=80=AFAM Francesco Dolcini <francesco@dolcin=
i.it> wrote:
>
> Hi Luiz,
>
> On Fri, Nov 24, 2023 at 09:26:11PM +0100, Francesco Dolcini wrote:
> > On Wed, Oct 18, 2023 at 04:55:39PM +0200, Marcel Ziswiler wrote:
> > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > Unfortunately, btnxpuart_close() may trigger a BUG: scheduling while
> > > atomic. Fix this by properly purging the transmit queue and freeing t=
he
> > > receive skb.
> > >
> > > Fixes: 689ca16e5232 ("Bluetooth: NXP: Add protocol support for NXP Bl=
uetooth chipsets")
> > >
> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > > ---
> > > This is the kernel trace this commit fixes:
> > > [   29.270685] BUG: scheduling while atomic: kworker/u3:0/55/0x000000=
02
> >
> > I just hit this bug with 6.7-rc2, I think it would be worth to
> > apply this fix.
>
> Do you need any change for having this patch (1/2) applied? Do you want t=
his
> to be re-sent without the second patch (2/2) from this series that is
> maybe more controversial?

Yes please just resend it.

> Let me know how I can help,
>
> Thanks,
> Francesco
>


--=20
Luiz Augusto von Dentz