Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2333-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240307004006.1173879-1-joakim.tjernlund@infinera.com>
In-Reply-To: <20240307004006.1173879-1-joakim.tjernlund@infinera.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Wed, 6 Mar 2024 22:40:39 -0500
Message-ID: <CABBYNZKixCvfq-eZLVgq7ccv_mui-h6QH+5WJ0=mUPut-z4P5Q@mail.gmail.com>
Subject: Re: [PATCH] obexd: Install D-BUS service for non systemd
To: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Cc: "linux-bluetooth @ vger . kernel . org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Joakim,

On Wed, Mar 6, 2024 at 7:40=E2=80=AFPM Joakim Tjernlund
<joakim.tjernlund@infinera.com> wrote:
>
> From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
>
> non systemd(like OpenRC) machines need D-BUS activation for obexd as
> they lack --user service.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> ---
>  Makefile.obexd | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/Makefile.obexd b/Makefile.obexd
> index 385e5618d..cfcc115b7 100644
> --- a/Makefile.obexd
> +++ b/Makefile.obexd
> @@ -1,7 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  if OBEX
>
> -if SYSTEMD
>  systemduserunitdir =3D $(SYSTEMD_USERUNITDIR)
>  systemduserunit_DATA =3D obexd/src/obex.service
>
> @@ -10,10 +9,6 @@ obexd-add-service-symlink:
>
>  obexd-remove-service-symlink:
>         rm -f $(DESTDIR)$(SYSTEMD_USERUNITDIR)/dbus-org.bluez.obex.servic=
e
> -else
> -obexd-add-service-symlink:
> -obexd-remove-service-symlink:
> -endif
>
>  dbussessionbusdir =3D $(DBUS_SESSIONBUSDIR)
>  dbussessionbus_DATA =3D obexd/src/org.bluez.obex.service
> --
> 2.43.0
>

I guess you want to revert 9cc8b97b8f5d060e334207136100e947732aed08,
but then we need to fix the checkpatch error:

commit 9cc8b97b8f5d060e334207136100e947732aed08
Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Date:   Mon Mar 4 12:44:08 2024 -0500

    build: obexd: Fix make distcheck

    This fixes the following error:

    /usr/bin/install: cannot remove
    '/usr/share/dbus-1/services/org.bluez.obex.service': Permission denied


--=20
Luiz Augusto von Dentz