Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2336-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <660e13ab-0139-4acf-a4b5-8fd817eef213@molgen.mpg.de>
Date: Thu, 7 Mar 2024 07:52:09 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH BlueZ v2 1/2] shared/lc3: Add definitions for Audio
 Configurations
Content-Language: en-US
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
References: <20240306230440.3983598-1-luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
From: Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20240306230440.3983598-1-luiz.dentz@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Dear Luiz,


Am 07.03.24 um 00:04 schrieb Luiz Augusto von Dentz:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This summary could be:

Define macros for Audio Configurations

> This adds defines for Audio Configurations so it can be used for
> upcoming tests.
> ---
>   src/shared/lc3.h | 482 +++++++++++++++++++++++++++++++++++++++--------
>   1 file changed, 401 insertions(+), 81 deletions(-)
> 
> diff --git a/src/shared/lc3.h b/src/shared/lc3.h
> index e0b2cdfc346d..41b29d4d1c8f 100644
> --- a/src/shared/lc3.h
> +++ b/src/shared/lc3.h
> @@ -88,77 +88,200 @@
>   			0x02, LC3_CONFIG_DURATION, _duration, \
>   			0x03, LC3_CONFIG_FRAME_LEN, _len, _len >> 8)
>   
> +#define LC3_AC_BITS(_ac) (BIT(_ac) - 1)

I’d appreciate a comment, that AC means audio configuration.

[…]


Kind regards,

Paul