Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2345-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Iulia Tanasescu <iulia.tanasescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: claudia.rosu@nxp.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH v3 2/2] Bluetooth: ISO: Always release hdev at the end of iso_listen_bis
Date: Thu,  7 Mar 2024 15:58:34 +0200
Message-Id: <20240307135834.3941-3-iulia.tanasescu@nxp.com>
In-Reply-To: <20240307135834.3941-1-iulia.tanasescu@nxp.com>
References: <20240307135834.3941-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mUCmvlSudjVklL8qPnI6qgCYluqSvBBVi9y+XeOv709nqm5gx1FGRyJWSmfh?=
 =?us-ascii?Q?mn5snOZRAz2WHCjFFpoPiRR4q76W5lxGs/tpZHhsuvb+5gMh8Nymyl5IfNI+?=
 =?us-ascii?Q?b1sGNFx4VDoKX0lY5NKYAKKqprwsQNOkGlZbm40bHnngd5oZ+xXGBXkzeHGI?=
 =?us-ascii?Q?lqAF8eCkW6fzzNhbtHF0iZ1Ec71DnaN6Q/jHSYhwEHJhWb6UWKd6oSWB2BIJ?=
 =?us-ascii?Q?VFUDL7y5tk11rtLpkB8MF2IWp4yMGe4d5y1bXmFoha/mcQq7Vyckbod8wbAF?=
 =?us-ascii?Q?MpgF3d5G4YQ7BGkeb3Z+RhS2jpC8WrvBaZlP1GJ3hh6diJZce8jYHLi3sGVI?=
 =?us-ascii?Q?mSg3mdKH23vO63CqAOqTrTb2aWMHrvVRhRInsmn0xLjRDOHNVMYQ87pzjgKS?=
 =?us-ascii?Q?StJTkq03l7ZLxa5uz5GxZHNra4kqf+gSbk/D8q4+4O7xJGJaLEAyd4PC4EhE?=
 =?us-ascii?Q?srTrr6vyxYjqEvYLUhYvZKa/uPo1h+jas+GpeBapjCb5wD/dXNqJgSLuYww/?=
 =?us-ascii?Q?XF5uV2RDID9s9cB6b4+EkvJ+riBnr1/E1bRDx9MQRMotLz+pSc2Oo0fmglG6?=
 =?us-ascii?Q?aWq6YV6uYXFZxex0/ZqsLs3eKsTkoP48ZhpXLNEzvWlZwYQpIN+GrtsnMZrN?=
 =?us-ascii?Q?mXFo+FbkyZ36gGwgnx9meg6TEQcP38n8yGAmlWe+kcODmR8ic7/s2Vr63T08?=
 =?us-ascii?Q?9yj3ABgd4rn/Igx+piktB64S6zmj6VPtLbVJen9OlKORTnBUw+InT51tQamR?=
 =?us-ascii?Q?PTKxDGUoyCjnUVBuRu6WXJl06lTWwpN/QAD7bu0XWb971nGcT5M1wEVR58+Q?=
 =?us-ascii?Q?055xtJk/WJ2RwZac/KG8Ua9YtgofRHG+KtdzPc46JOlwrrrIY+hlgZQEOWJi?=
 =?us-ascii?Q?CvLboXwW+siVFua0Qm1izb+7TqKa9k3eeQK9lWXVgaCOr9LY84I0U2CjppD3?=
 =?us-ascii?Q?mh8GOJuEINEoM2wgsLtyhgbR95KzLaBuCOHDeLWAKfqXSTr1QzArZJWpweaC?=
 =?us-ascii?Q?KT4PQ0m/lMAervA77hhgrZl/jj2btkNb9YIkd4ke5bsOhhpdIQZQsTO/5rUV?=
 =?us-ascii?Q?2nI+kC+sHg8okxBAGdcxH3sxiPy2bxEP7jKFq5h/+SXx0o+wM0gBZUFW1LA2?=
 =?us-ascii?Q?vVb0oeqC8p/eXAK9uZvE4rqHp5V24vfSs2CvkzDxV9Eb7kcYecfd3OezZH/S?=
 =?us-ascii?Q?1MLgO4ZXA4xTqiZ24GpFWgqmFJn7jLyhdShhC0G/vDeqoz0PbXNXIHWQVmAf?=
 =?us-ascii?Q?LRIeCqKbi93ej6xeqB2lntqNMCFDbv6ORsrxwr9JrZEyjBbpvHiDWwtJ7o9W?=
 =?us-ascii?Q?2q3WAGvLGcPSoge1YjeatLf+nBp3jqpjBhdfejJfndFc8sVoy9Jx5SP/eiPr?=
 =?us-ascii?Q?6Z9AQBrt6LtpphKIlAkvo7+0VHhyeQlOMFiDzvjzhg/zu/JKQmXei2WRHbl5?=
 =?us-ascii?Q?+ZiyKPCxFR9CWD0xfFnmjpS48Pkq+3b4lbk6h5CGleAeeldaB6vdKih40vZw?=
 =?us-ascii?Q?lEhrkQhrI/OgqaWy0GNat4M9ZJRRPpwLmyxuTO5AISqPxJyb8fx71Dg3kNOi?=
 =?us-ascii?Q?Tq6EHSXc00MkD2YpUgGp8cmIKa4B0aSvnQg7LwQEymtOzwX0LPiyt5WTkhdJ?=
 =?us-ascii?Q?ZQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86899e51-98f7-4c46-90f1-08dc3eaeb74e
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8909.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 13:58:50.1347
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a2j2Qp0Nnl7TiBJzSVh+yWipbcKQVOfTOVRrazMdrC17R8sT+6YYGGbnMcB/tDsHP1Dko6R4yer9iS0syfv13g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8424

Since hci_get_route holds the device before returning, the hdev
should be released with hci_dev_put at the end of iso_listen_bis
even if the function returns with an error.

Signed-off-by: Iulia Tanasescu <iulia.tanasescu@nxp.com>
---
 net/bluetooth/iso.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c
index d1608387fd85..bd2271cba359 100644
--- a/net/bluetooth/iso.c
+++ b/net/bluetooth/iso.c
@@ -1134,14 +1134,14 @@ static int iso_listen_bis(struct sock *sk)
 		goto unlock;
 	}
 
-	hci_dev_put(hdev);
-
 unlock:
 	/* Unlock order should be in reverse from lock order. */
 	release_sock(sk);
 	hci_dev_unlock(hdev);
 	lock_sock(sk);
 
+	hci_dev_put(hdev);
+
 	sock_put(sk);
 
 	return err;
-- 
2.39.2