Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2351-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Iulia Tanasescu <iulia.tanasescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: claudia.rosu@nxp.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH BlueZ 1/4] client/gatt: Quit shell after user input has been processed
Date: Thu,  7 Mar 2024 17:58:47 +0200
Message-Id: <20240307155850.68395-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20240307155850.68395-1-iulia.tanasescu@nxp.com>
References: <20240307155850.68395-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Xcu0PCpimq7qhGcxg17lvFLnwDJuUkyNkGw/mg08JA6ISS2ShZOzceokQZdF?=
 =?us-ascii?Q?lrmD2MiQFWH5S6G5X+rZzzy+K36IKe3pNTakVUthaE3hPhMHtcqVkq6mnQ7L?=
 =?us-ascii?Q?Gehu0ie7xuYpHUX8YxSqRgdxv0sV5GPi7SYGP9My09qe9b5yjoVuWXYast/r?=
 =?us-ascii?Q?vekjkcKdfRHarHUk4N/pKJJlt2DZ7CSFcBd1Rqqw9z2PBTSsTuVjzrM8hGnH?=
 =?us-ascii?Q?61JU235PJRhWWKtj5uGrkofmIPjdlff4Ih0F0I292sulhiHQeXEfzMOJD62v?=
 =?us-ascii?Q?CGUpzMuqwnF8Bux3tKpbpRpvjUHOhuE7udJfMKLDHPpmkvNI0A22ifwSUm45?=
 =?us-ascii?Q?v8dOhVtG0YMdlfE3K6n7XfwBJqJo5n+2Yf69NUife2Qb+8/ju9uZRo5f1y98?=
 =?us-ascii?Q?407fvndLiLT9sUfzLUjWqpFtZXxKxztN0CLUaFdtIobPvfSKMLLx6PDWDziU?=
 =?us-ascii?Q?qifaCrwVm3/u/vnduHq4lZV37e7bFbfQpoMZEjVtgxbxLiplfKgbb2KakSEL?=
 =?us-ascii?Q?cx8UTuS5QuJK9qEYMweKpZPk5LcQGlI8sKZcF4IrKc0NJ+LCY9LIiPaKUzg0?=
 =?us-ascii?Q?Zq970etMgFZ3zkKNlvNUV0bp1yD9mdPttmzcqBYZBmAs322v29ETYqb3mbVY?=
 =?us-ascii?Q?ld6Vm6Uo0sdQ8p8GIzJOWfrCzvvsZHkWbCyyUKI9DORS7QUNG7U8KQI+F2aQ?=
 =?us-ascii?Q?9sAYgokYfu3/4u6MgJrrzCR40wUqJVa2ZzuBNzjYhPG+nr22JcFKoSNW9NJA?=
 =?us-ascii?Q?ONGXgbBkbMuD8qAQem+g9Q6dcpIS6tDMeiR3yIr39BJlQ27I66ksV+DdMElA?=
 =?us-ascii?Q?LrV/MiSbhBwJM3Aqbr/6GEMYGi9gWynKdSCPqQEjCvfNXoLzILLY+TSuwlV4?=
 =?us-ascii?Q?FHOOrW4fLE4I7fl0R7b+BK9l+0exu+t60jEE/bIrHMfrJc69KEyCEMqteJxo?=
 =?us-ascii?Q?QWjbq47lLAlMsTEQEtddrdAqF81GhfmUQmWUtIgY+IpITJYJjgc4aJzWh/TQ?=
 =?us-ascii?Q?7le092ZCGwIhW2hpocf+wG5hNBQ83ABXx1okQTbTZ8PTS/Aw+FWKkWPYWVFt?=
 =?us-ascii?Q?h7WhklPUXI4K1A9dOpEfzXXO7C+A2w+EOLQCnZn8YYt0mZlqA//dszToA+0b?=
 =?us-ascii?Q?IEe4yr1Jp9ND+UfID390e0p5E4wkk9Wmfh9ZMHujltDmBXzUjLRHUWbK5kUs?=
 =?us-ascii?Q?pDORCRaSonUBhW7jmYh0/WZ6S1dc4RdMHYzyt6v7+Gi0n0eJbVL49UUKYc9L?=
 =?us-ascii?Q?ZlCHV7zHZeNr+KALfOiKKxspDMuCVSIDlU6z7xT9/ofC9G3JVCtgLktR1aDh?=
 =?us-ascii?Q?6GV/HHZdC3rUuMFIHaTGo/HsQMHMkhhKGGGuSRlq96LOEtxqziKcReRUrcfP?=
 =?us-ascii?Q?7xWLNRdcchAlbTPJhAmU3A+4KxlKXxS6HDRDECWuQcjsA5+tS3erge4Ee8L6?=
 =?us-ascii?Q?tsif0+3WySdb5QBZG/E7QjyinOsgU9pXsWJWvOsn+Unrjb+Fpf95MRRTxqgC?=
 =?us-ascii?Q?Eh4X22Gb92jCde0yh6aRiOZYJR+B1ZE3FL4/E/f5T/9uOuWqs40Z0dWrUwlR?=
 =?us-ascii?Q?8b24xsP9vWP7DKpym+9sNaQXuDNqc3RH2rdUieKPFRn36oGSxecAuLYw7JKD?=
 =?us-ascii?Q?rg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: adbb34bd-631f-4734-2da8-08dc3ebf8396
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8909.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 15:59:04.8744
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ga/N+DZIq+iQQF65bimKLi38XvZVjNMJHY2znjkX29bD97QG0tZkghOCuxLfnDvC37UNVzICzODLWXkbzJuYoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9417

Inside gatt_register_service and gatt_register_chrc,
bt_shell_noninteractive_quit should be called after
the input was processed.
---
 client/gatt.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/client/gatt.c b/client/gatt.c
index f03fc1526..84b7f3f49 100644
--- a/client/gatt.c
+++ b/client/gatt.c
@@ -4,6 +4,7 @@
  *  BlueZ - Bluetooth protocol stack for Linux
  *
  *  Copyright (C) 2014  Intel Corporation. All rights reserved.
+ *  Copyright 2024 NXP
  *
  *
  */
@@ -1685,6 +1686,8 @@ static void service_set_primary(const char *input, void *user_data)
 		g_dbus_unregister_interface(service->conn, service->path,
 						SERVICE_INTERFACE);
 	}
+
+	return bt_shell_noninteractive_quit(EXIT_SUCCESS);
 }
 
 static uint16_t parse_handle(const char *arg)
@@ -1737,8 +1740,6 @@ void gatt_register_service(DBusConnection *conn, GDBusProxy *proxy,
 
 	bt_shell_prompt_input(service->path, "Primary (yes/no):",
 		 service_set_primary, service);
-
-	return bt_shell_noninteractive_quit(EXIT_SUCCESS);
 }
 
 static struct service *service_find(const char *pattern)
@@ -2761,6 +2762,8 @@ static void chrc_set_value(const char *input, void *user_data)
 	}
 
 	chrc->max_val_len = chrc->value_len;
+
+	return bt_shell_noninteractive_quit(EXIT_SUCCESS);
 }
 
 static gboolean attr_authorization_flag_exists(char **flags)
@@ -2817,8 +2820,6 @@ void gatt_register_chrc(DBusConnection *conn, GDBusProxy *proxy,
 	print_chrc(chrc, COLORED_NEW);
 
 	bt_shell_prompt_input(chrc->path, "Enter value:", chrc_set_value, chrc);
-
-	return bt_shell_noninteractive_quit(EXIT_SUCCESS);
 }
 
 static struct chrc *chrc_find(const char *pattern)
-- 
2.39.2