Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Iulia Tanasescu <iulia.tanasescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: claudia.rosu@nxp.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH BlueZ 2/4] client/adv_monitor: Remove shell quit from adv_monitor_register_app
Date: Thu,  7 Mar 2024 17:58:48 +0200
Message-Id: <20240307155850.68395-3-iulia.tanasescu@nxp.com>
In-Reply-To: <20240307155850.68395-1-iulia.tanasescu@nxp.com>
References: <20240307155850.68395-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?reW4lj3OLbuLouZiM+ZHFml0K2RsERKSFij75F4OV2M/wJFzT28Jt6KM+oty?=
 =?us-ascii?Q?HKqFWtqBQ626cGXY0z1l9ShvBw9xk/hpZnMnpr6ADLgqD8TvBtRRlOGPNZJv?=
 =?us-ascii?Q?AdHkcjjQVe3GMS/MYvrq1mGf5uZQmFapKgP5jRPsHRlLP2qv9v1IHdX5yJq0?=
 =?us-ascii?Q?wZGeyGbwGpgw4qeS/gO0SCqpweiithudEyNRlnshiiNjPzkqOnmhIV/bskv9?=
 =?us-ascii?Q?WjbTgsu++NFbVJco2nWlnUu01YzBEDRb9mwN+0+gdBDHdaCTQbz7wwjeRRrK?=
 =?us-ascii?Q?M1oCPh3yS/QBsiGNmQm+4witxITkhhdKlRZKnlo/UxJNSAohUwAUMEkKIPi8?=
 =?us-ascii?Q?mE2es7vKF18iZmel3EFmiTv8kvVBUFijR7yk8yQozDmeYGE39s81e8zHDQs6?=
 =?us-ascii?Q?TdKdCPQVk2tGOYNus/Pyzo2nE3hmpYpCi2xhqTPhiAqQ3msisMHB2f25QEPY?=
 =?us-ascii?Q?gHIuM6jltpVwm3JN2l1xRK/3maJbxil0VU/pVQxjRa8B19P/r2wGaL9zDjxM?=
 =?us-ascii?Q?eJ/cOjJ6NcFaEzbmOJYZSswqM/YrLizdI2pYxjvPNkQ4RAHNGEkfTNvcT8wY?=
 =?us-ascii?Q?Gnemx5SiHGLGfDDSYDj8Ye8fdCsaRCdVb3ykeiGoVkZ5DLVxWRvRXtwUU6iY?=
 =?us-ascii?Q?mNPV3mRdEQjYNUbSlZFw/Cy25e6kWHpSOlDW9ct0+YiKUMlaihG7Rdwp2tIS?=
 =?us-ascii?Q?zkKVSLlMgrBvKW85Ad+Q5707lZ2XSUTC2ntrolCUTVGS9l6mNkKi2Uz2iwKd?=
 =?us-ascii?Q?mgVWHcTZFef73dUUFxgf4cmL7IGnJsvqBgLQ2i/38yErBZdSKbaX3DqCkK9q?=
 =?us-ascii?Q?N/HDxVCYe3gIEm0LulYD4N99vlYNyEibqXAGoxG2hXLJ3U0irjtA0Q49EzxT?=
 =?us-ascii?Q?JjYPMmqytDXjT9Jsm31i0/tuCteT6Y7xSPsHgkX7J0C4KZHkbbJEvrRa8f6z?=
 =?us-ascii?Q?or03pscw+k3yp4ucXBxM1Qy36np62LHAy+bFk2WmobjV1A3fNe/zq4dO+joo?=
 =?us-ascii?Q?k0dtg/lbbaKI3bmMmyDJCbOzZETwggX4mVAtFUwl48DDOMYi4nW7fmwBM7D2?=
 =?us-ascii?Q?ePZEpIQ40kNANC9wMhIpvK9+rOO5cAnKM6qZ5kHanT4gM6SPfp6hGVtHzCOH?=
 =?us-ascii?Q?6hzWFi2WvNLj3AeInXQWnXbJxyV0cWp5Im8sNjxQ9fkXFurnwpDuZwSkdBd9?=
 =?us-ascii?Q?svaNWTy79GIAwBIpD52soW1Bp4KWpmDrtCD2xe9YeAYF7sEM59V/4LU7X1wh?=
 =?us-ascii?Q?Ztqj745a71SaXKK6QfgRmxo1zHskCVzgJFY3kV3vKOn6iocKNaWPlQqUbZD8?=
 =?us-ascii?Q?/iKcO6mdmqkNuACCN11YmSW1Hwu++6k4fEwQvsmsI9G3kJ8OGE+/YZsv7kQ6?=
 =?us-ascii?Q?9foV8SdoNDrBM+t/MuygNdhFLd3/K2bckOgnVaCeOev4sN8BTvvGzbDejmaf?=
 =?us-ascii?Q?NlgF/SMLybszCoFAXVgtSWmae3B96YUntS3CsByhC0AYuMwE/Vg+VtVTEsKl?=
 =?us-ascii?Q?rFznTN/ARlXPunamqNDJpjfbtIhpiCe7raNpXHPKaOiIZ0wmCenmJW0rxfxj?=
 =?us-ascii?Q?MhoU7cz18Racdu3ixwL2jfh5osIzB4dKcYrBBbrqAWO9krGuRrjdqUyUp64J?=
 =?us-ascii?Q?Zg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b2c54e8-068b-489d-602a-08dc3ebf859c
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8909.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 15:59:08.1967
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 91dsn0j27wUG9eQ6SkIJ7KL6+uPfMSwTVc5hLrN0ail5158eG4ZUVhZuhXEOHst/pszEikeEN2ZPdL0QYgqgfA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9417

In adv_monitor, adv_monitor_register_app is called when an advertising
monitor manager proxy has been added, when a new adapter is added.

This commit removes bt_shell_noninteractive_quit from this function,
since it causes the shell to exit without a user command having
executed.
---
 client/adv_monitor.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/client/adv_monitor.c b/client/adv_monitor.c
index 792379fc4..29e670960 100644
--- a/client/adv_monitor.c
+++ b/client/adv_monitor.c
@@ -4,6 +4,7 @@
  *  BlueZ - Bluetooth protocol stack for Linux
  *
  *  Copyright (C) 2020 Google LLC
+ *  Copyright 2024 NXP
  *
  *
  */
@@ -372,12 +373,11 @@ static void register_reply(DBusMessage *message, void *user_data)
 
 	if (!dbus_set_error_from_message(&error, message)) {
 		bt_shell_printf("AdvertisementMonitor path registered\n");
-		return bt_shell_noninteractive_quit(EXIT_SUCCESS);
+		return;
 	}
 
 	bt_shell_printf("Failed to register path: %s\n", error.name);
 	dbus_error_free(&error);
-	return bt_shell_noninteractive_quit(EXIT_FAILURE);
 }
 
 static void unregister_setup(DBusMessageIter *iter, void *user_data)
@@ -408,13 +408,13 @@ void adv_monitor_register_app(DBusConnection *conn)
 {
 	if (manager.app_registered) {
 		bt_shell_printf("Advertisement Monitor already registered\n");
-		return bt_shell_noninteractive_quit(EXIT_FAILURE);
+		return;
 	} else if (manager.supported_types == NULL ||
 		!g_dbus_proxy_method_call(manager.proxy, "RegisterMonitor",
 					register_setup, register_reply,
 					NULL, NULL)) {
 		bt_shell_printf("Failed to register Advertisement Monitor\n");
-		return bt_shell_noninteractive_quit(EXIT_FAILURE);
+		return;
 	}
 	manager.app_registered = TRUE;
 }
-- 
2.39.2