Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2386-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240308165232.53906-1-silviu.barbulescu@nxp.com> <20240308165232.53906-3-silviu.barbulescu@nxp.com>
In-Reply-To: <20240308165232.53906-3-silviu.barbulescu@nxp.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Fri, 8 Mar 2024 12:41:28 -0500
Message-ID: <CABBYNZ+vH71y1bEhLDtnmsfvMLJ7wUnA60R3-DJ_kB7w2NzgEA@mail.gmail.com>
Subject: Re: [PATCH BlueZ 2/3] transport: Add support to update the transport configuration
To: Silviu Florian Barbulescu <silviu.barbulescu@nxp.com>
Cc: linux-bluetooth@vger.kernel.org, mihai-octavian.urzica@nxp.com, 
	vlad.pruteanu@nxp.com, andrei.istodorescu@nxp.com, iulia.tanasescu@nxp.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Silviu,

On Fri, Mar 8, 2024 at 11:52=E2=80=AFAM Silviu Florian Barbulescu
<silviu.barbulescu@nxp.com> wrote:
>
> Add support to update the transport configuration
>
> ---
>  profiles/audio/transport.c | 23 +++++++++++++++++++++++
>  profiles/audio/transport.h |  1 +
>  2 files changed, 24 insertions(+)
>
> diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c
> index 159fbd575..c8492d4a1 100644
> --- a/profiles/audio/transport.c
> +++ b/profiles/audio/transport.c
> @@ -1483,6 +1483,29 @@ static void bap_update_bcast_qos(const struct medi=
a_transport *transport)
>                         "Configuration");
>  }
>
> +void bap_update_bcast_config(struct media_transport *transport)
> +{
> +       struct bap_transport *bap =3D transport->data;
> +       struct iovec *cc;
> +
> +       cc =3D bt_bap_stream_get_config(bap->stream);
> +
> +       if (((int)cc->iov_len !=3D transport->size) ||
> +               (memcmp(cc->iov_base, transport->configuration,
> +                       transport->size) !=3D 0)) {
> +               free(transport->configuration);
> +               transport->configuration =3D util_memdup(cc->iov_base,
> +                                                       cc->iov_len);
> +               transport->size =3D cc->iov_len;
> +
> +               g_dbus_emit_property_changed(btd_get_dbus_connection(),
> +                       transport->path, MEDIA_TRANSPORT_INTERFACE,
> +                       "Configuration");
> +       }
> +
> +       bap_update_bcast_qos(transport);
> +}
> +
>  static guint transport_bap_resume(struct media_transport *transport,
>                                 struct media_owner *owner)
>  {
> diff --git a/profiles/audio/transport.h b/profiles/audio/transport.h
> index b46bc8025..6df419a67 100644
> --- a/profiles/audio/transport.h
> +++ b/profiles/audio/transport.h
> @@ -16,6 +16,7 @@ struct media_transport *media_transport_create(struct b=
td_device *device,
>                                                 uint8_t *configuration,
>                                                 size_t size, void *data,
>                                                 void *stream);
> +void bap_update_bcast_config(struct media_transport *transport);

Lets not bypass layers here, so the config updates probably need to be
pushed thru bt_bap_stream somehow, perhaps via a new callback or a
state change where the transport.c can query the new configuration and
update its D-Bus property.

>  void media_transport_destroy(struct media_transport *transport);
>  const char *media_transport_get_path(struct media_transport *transport);
> --
> 2.39.2
>


--=20
Luiz Augusto von Dentz