Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2388-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <67b5221c6ff05cf78070fbbe7f7f06f974b52e3d.camel@perches.com>
Subject: Re: [PATCH] Bluetooth: bfusb: Updated code to follow style guide
From: Joe Perches <joe@perches.com>
To: Ayaan Mirza Baig <ayaanmirza.788@gmail.com>, marcel@holtmann.org, 
	luiz.dentz@gmail.com
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Fri, 08 Mar 2024 10:08:46 -0800
In-Reply-To: <20240308162037.100226-1-ayaanmirza.788@gmail.com>
References: <20240308162037.100226-1-ayaanmirza.788@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-03-08 at 21:50 +0530, Ayaan Mirza Baig wrote:
> Added indendations, removed trailing spaces, added empty lines after decl=
aration.

indendations/indentations.

Do please try to not just mollify checkpatch message bleats
but try to make the code more intelligible.

I think the tests are backwards would better be written
with fewer block indentations and direct returns without
creating used-once temporaries like:

---
 drivers/bluetooth/bfusb.c | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
index cab93935cc7f1..68587424187e6 100644
--- a/drivers/bluetooth/bfusb.c
+++ b/drivers/bluetooth/bfusb.c
@@ -273,33 +273,27 @@ static inline int bfusb_recv_block(struct bfusb_data =
*data, int hdr, unsigned ch
=20
 		switch (pkt_type) {
 		case HCI_EVENT_PKT:
-			if (len >=3D HCI_EVENT_HDR_SIZE) {
-				struct hci_event_hdr *hdr =3D (struct hci_event_hdr *) buf;
-				pkt_len =3D HCI_EVENT_HDR_SIZE + hdr->plen;
-			} else {
+			if (len < HCI_EVENT_HDR_SIZE) {
 				bt_dev_err(data->hdev, "event block is too short");
 				return -EILSEQ;
 			}
+			pkt_len =3D HCI_EVENT_HDR_SIZE + ((struct hci_event_hdr *)buf)->plen;
 			break;
=20
 		case HCI_ACLDATA_PKT:
-			if (len >=3D HCI_ACL_HDR_SIZE) {
-				struct hci_acl_hdr *hdr =3D (struct hci_acl_hdr *) buf;
-				pkt_len =3D HCI_ACL_HDR_SIZE + __le16_to_cpu(hdr->dlen);
-			} else {
+			if (len < HCI_ACL_HDR_SIZE) {
 				bt_dev_err(data->hdev, "data block is too short");
 				return -EILSEQ;
 			}
+			pkt_len =3D HCI_ACL_HDR_SIZE + __le16_to_cpu(((struct hci_acl_hdr *)buf=
)->dlen);
 			break;
=20
 		case HCI_SCODATA_PKT:
-			if (len >=3D HCI_SCO_HDR_SIZE) {
-				struct hci_sco_hdr *hdr =3D (struct hci_sco_hdr *) buf;
-				pkt_len =3D HCI_SCO_HDR_SIZE + hdr->dlen;
-			} else {
+			if (len < HCI_SCO_HDR_SIZE) {
 				bt_dev_err(data->hdev, "audio block is too short");
 				return -EILSEQ;
 			}
+			pkt_len =3D HCI_SCO_HDR_SIZE + ((struct hci_sco_hdr *)buf)->dlen;
 			break;
 		}
=20
@@ -365,9 +359,8 @@ static void bfusb_rx_complete(struct urb *urb)
 			buf   +=3D 3;
 		}
=20
-		if (count < len) {
+		if (count < len)
 			bt_dev_err(data->hdev, "block extends over URB buffer ranges");
-		}
=20
 		if ((hdr & 0xe1) =3D=3D 0xc1)
 			bfusb_recv_block(data, hdr, buf, len);