Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp1391023lqt; Wed, 20 Mar 2024 02:30:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXnqzhDU/bjRWTjwsSE6V2UBfyirdl1NlzfUHYrydf2KdMryqqmgZZmd9Ej6Wq7ZVrrgnEgqweBIuLng4TzBbtMIWXjgbJR6u0BN3Zxvg== X-Google-Smtp-Source: AGHT+IGAB+q6xlS7p5kbSRl0fs/uAn2fWYLIqhzgY97AnwUhYoklhtF5C2nXuenP8EdfxLeFS6MS X-Received: by 2002:a05:6402:43cf:b0:568:d74f:bb8e with SMTP id p15-20020a05640243cf00b00568d74fbb8emr5711751edc.3.1710927042741; Wed, 20 Mar 2024 02:30:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710927042; cv=pass; d=google.com; s=arc-20160816; b=gEwd7GZXxiw4AbfavkQccEimu6PvXWRgfTHWD4fDZ5KY/G3+a3BSIijy0kyaM37blw kqgHg3gcIsstm7PUYKMXDeNp2BAgE9d16O1AOpo/Ys6o3lFnYiHxYzdSqMtCm50ZiBwp OHdoe4aJgFs2mnz7L3Ztg4Q7ANgmbtS3x2HmeD0E+v/7xoGire8opurW/k5HU8qj+oRW aWXflLCiMtJNJvkfNEnerA8GNP9ww9BSj+3cslpJYj/q1p7NaWbqwl4r8TsApD2vyitU VRzlNTr9jHGnMnOZY7zFYg9ha/+kSG/Enjt3wvsTPcXaidhKZLGZYzlYrYyHDN/FJaHH cvTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:date:message-id:from:subject :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=lmYBbB9Lk8pO0vFIyq84Kv/NHCKtWKarWVMBjZ7p1dg=; fh=fAVvqa29TMCSLQ1BWo+IkeTh9vOt2h2EvlnFWIq0DOI=; b=jW1zguE3Czatr4i3NnSFLzEixIp82QVGrO3De2UJx3MM49TlGvjq3AcIyO7GFlZz2X WCw5tqKOPwtLIyfqZWVzyBmsPCs3XR9YMD4KZzKsrgRdJIA/aHofwqy12QmSzpjc51fM 5Oakaa+R2n5QXzPUko4Wdfbko83L8UL7StnyvUyq5MJTM6cz1YK7YOoDzRldmZZoRCvJ /bLtl9zNg6G/RcHZOjUE+Gk8DDO0tp+TcX9+pax886bWdygnxJ8sGL0FfckO0Df1prrN cmrzSOYRypM0Wt/5WFn8S5dPS6MFjwEz2+4BhHrK7weChNEB6RJzHCf1yaz4tTTKB12L l/9g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t0MLInpM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-2657-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-2657-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id f22-20020a056402195600b0056bb5dc509bsi217628edz.148.2024.03.20.02.30.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 02:30:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2657-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t0MLInpM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-2657-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-2657-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7771B1F23182 for ; Wed, 20 Mar 2024 09:30:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD9133B2A1; Wed, 20 Mar 2024 09:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t0MLInpM" X-Original-To: linux-bluetooth@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D7283C068 for ; Wed, 20 Mar 2024 09:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710927033; cv=none; b=iNzTDhEi5iAWZigAflJEmzikFEwAUHm0yCA513c8EQXUMXJXYaSt6bJYbDN6yfel6fvpUjfi6MF0nj7UAcv9KjhJXUvw5qoFdWkqzV0NMriROO+brLXqSsJxRy60helaZhykcGI1mT1JzXiZEGVf2FeUlVBgRojEVlQD5LlE2ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710927033; c=relaxed/simple; bh=lAVGXd989nU/QV8U2uoEJTgErF63RupFCXZ1eokGQuk=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=mqDjLXjtCDpd32Yd9UxRyJ2Zt5Rwy2ZsNTRkBlZpaZ/IEoMtwbILkI/12K5FeVm4SPKBjKEl8fj2hx8grz/Sh/1Vja7d1pEhDvHhEpmgVFXaqXgS2kRkkIXdISEj8jDqH2GfjuYT6eR4tFfxG+Jq4HPsq6rQoBJ8ji5r+Ft/SgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t0MLInpM; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id D127AC43390; Wed, 20 Mar 2024 09:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710927032; bh=lAVGXd989nU/QV8U2uoEJTgErF63RupFCXZ1eokGQuk=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=t0MLInpM7mjQZ3yZvMX//mE+bsAZ7e7g0DYXgnhtBrLIyzmE1nWgmDCPGvkaxkJgJ 9dSAFu8+at0J517W/03JfmitTvFFm4qbvcCbWHEY9rXSoOmAb1BjOJT/Z0zDyiMWUS eA1IgB0+dpbMU6DUAA1oenxmxVuY/6W4Zz9tD10ha/ugl5VAhlte+kUICdMHhvJVAj CjgOMZIXVruByLoRxN5y4I6WdGU669M9GImZtrm2+b+CfSRpZL40lqZCdRI+T226sa lQoP57wn46YSmld8ZMMJK7wdExzKdb6ZRMS7UJ/ecS5w1cfZ6hikm/CWMudw+dEg1z K25oPJO5C256w== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id C4CDBD84BB1; Wed, 20 Mar 2024 09:30:32 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH BlueZ] a2dp: fix setup->err use-after-free From: patchwork-bot+bluetooth@kernel.org Message-Id: <171092703279.20558.12930550090274246801.git-patchwork-notify@kernel.org> Date: Wed, 20 Mar 2024 09:30:32 +0000 References: <154e1a604eb8c3d924699489da72ea905915fb88.1710614196.git.pav@iki.fi> In-Reply-To: <154e1a604eb8c3d924699489da72ea905915fb88.1710614196.git.pav@iki.fi> To: Pauli Virtanen Cc: linux-bluetooth@vger.kernel.org Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz : On Sat, 16 Mar 2024 20:36:38 +0200 you wrote: > setup->err is set to values that either are on stack of avdtp.c > routines, obtained from callbacks, or allocated on heap. This is > inconsistent, and use-after-free in some cases. > > Fix by always allocating setup->err ourselves, copying any values > obtained from callbacks. Add setup_error_set/init and do all setup->err > manipulation via them. > > [...] Here is the summary with links: - [BlueZ] a2dp: fix setup->err use-after-free https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c04b96dda5ce You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html