Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2697-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240322143830.1476938-1-xiaokeqinhealth@126.com>
In-Reply-To: <20240322143830.1476938-1-xiaokeqinhealth@126.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Fri, 22 Mar 2024 15:28:53 +0000
Message-ID: <CABBYNZK64cAFTm7221QxN2T4Eip0=LbpmWUX_bJ3w+O4wAG2UQ@mail.gmail.com>
Subject: Re: [PATCH BlueZ] avctp: Remove redundant UUID checks and additions
To: Xiao Yao <xiaokeqinhealth@126.com>
Cc: linux-bluetooth@vger.kernel.org, Xiao Yao <xiaoyao@rock-chips.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Mar 22, 2024 at 2:39=E2=80=AFPM Xiao Yao <xiaokeqinhealth@126.com> =
wrote:
>
> From: Xiao Yao <xiaoyao@rock-chips.com>
>
> ---
>  profiles/audio/avctp.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c
> index 8ad146df1..6199ee951 100644
> --- a/profiles/audio/avctp.c
> +++ b/profiles/audio/avctp.c
> @@ -1597,12 +1597,6 @@ static void avctp_confirm_cb(GIOChannel *chan, gpo=
inter data)
>         if (session =3D=3D NULL)
>                 return;
>
> -       if (btd_device_get_service(device, AVRCP_REMOTE_UUID) =3D=3D NULL=
)
> -               btd_device_add_uuid(device, AVRCP_REMOTE_UUID);
> -
> -       if (btd_device_get_service(device, AVRCP_TARGET_UUID) =3D=3D NULL=
)
> -               btd_device_add_uuid(device, AVRCP_TARGET_UUID);

Patch description makes no sense to me, this code is adding the UUIDs
of AVCTP if the device over its PSM because at this point perhaps SDP
discovery is not complete.

>         switch (psm) {
>         case AVCTP_CONTROL_PSM:
>                 avctp_control_confirm(session, chan, device);
> --
> 2.34.1
>
>


--=20
Luiz Augusto von Dentz