Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2741-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Vlad Pruteanu <vlad.pruteanu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	iulia.tanasescu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Vlad Pruteanu <vlad.pruteanu@nxp.com>
Subject: [PATCH BlueZ 1/1] bap: Fix setting adapter address type for unicast
Date: Mon, 25 Mar 2024 15:19:10 +0200
Message-Id: <20240325131910.324811-2-vlad.pruteanu@nxp.com>
In-Reply-To: <20240325131910.324811-1-vlad.pruteanu@nxp.com>
References: <20240325131910.324811-1-vlad.pruteanu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MnIhMLcy4uzPJ5sXY3RRrdKcJPEK+kmRFMlTs2iyBapAR3+MqBQRbZ8lnzn9?=
 =?us-ascii?Q?LiJ5Ze8Ne5RG2CpZMvLzferBdlwzwOb5E5LtRdABKW2RHrLo2aHbSoPka9W7?=
 =?us-ascii?Q?ywrE05GxSaERZuvqtvDXWIGKShpRLP8AE8IwP6LRnxSqnzuiKEXmOC4iBBeJ?=
 =?us-ascii?Q?hn1ah4U9jqJmqvD0lq7hV4tM9iZF+n1Z611LuVp0MJMYW/2IXrDsqDT511Aq?=
 =?us-ascii?Q?Fkheu3u86qabCsqwhl2DUpxxMILiHrCnllV2wgl6oG1bn+BPUNfZETSzqFti?=
 =?us-ascii?Q?9aRiv69n4y29fw6DbBtGKvQ6uM2WMTBpgr3r07L+/3Pm9T3QYhIdWtZj2hsn?=
 =?us-ascii?Q?4VuXSSgEgrK8XX4JhgFDoYkcxx5YqDX+3IW4tRrtVqC7RrLjTVsj23SSH588?=
 =?us-ascii?Q?0Jqc6STLLb/qhZcWwc+Wpe2j2Skhyno6mLl0hJr8vA90mFlYOkXwG8cJRZ4X?=
 =?us-ascii?Q?VVjfyKTyKmgbdSEMkPAVV0MTK/RaH17LcmPCuH1HKLNiiepBf4LAwXqsnft5?=
 =?us-ascii?Q?yT3mvjIoMw6bLiZ4YwgzCAyqQAZo+7OWX1Fv5QlVvQL94sKS/fw5b8lH4kEi?=
 =?us-ascii?Q?CleMA6iBrSruzJuG6TxD7TE8YcEpTJW3nDpVvProRGUCeWPrFSdj8uuFVxnD?=
 =?us-ascii?Q?6096AJVrazEKPoHARbaUAFQzWc6PfvwEOoUvU3GunYWHPDTm5Jgg+ZgFhEjJ?=
 =?us-ascii?Q?XhFLbC/f/Yuw16eUgLynwiApPVzmSiIjUbQ6XHWubKg4bRaT3aanM0tO082c?=
 =?us-ascii?Q?SaOI+GmX8xoDXROBhSe7mvYJxKSIGHAR1S/uiMKuckm9EqW6vCAFnADHo9oP?=
 =?us-ascii?Q?BB/nIWMa22ts0WnR4R+ywTCoAi9VFUOcWxzWVrR3WfXw55IyV1L864KPUZda?=
 =?us-ascii?Q?EBNZCz3KjqJA/iJBTsGS5R/Ug/6X5QZAGq4ACr/+P0TfuDJ6EAplZcSQnfjn?=
 =?us-ascii?Q?0YEH365LwmonwECFnZbGQNQszI2tcw2NCp5vnZzOrRAoGgadwn329q9Sateg?=
 =?us-ascii?Q?RfVfI+4a3lEdMZtz3LaYdhRCyo0g6H0dIJVv5s6tmrLm/U9XlChyrb2NTLO+?=
 =?us-ascii?Q?mxQQhkzLjr/4NqTB/wSHhJ1Olo/ES4EagxSmyLLGYli4Xl9ICEcFM1buJRbC?=
 =?us-ascii?Q?ZrS4bTHmMGHfcctAj2UyR0oePwCtm4eXEPVuaObxKm9+u6ya+PENXFg4WMZV?=
 =?us-ascii?Q?t9IFugXrmXOXAS3/iIykG4wlV+qoBtsK6yJbRAcChL7HmH1H61dHQ4CO4sOB?=
 =?us-ascii?Q?lGGcxlEeF+kch4I0a63rU2WH66fpP3XtYzMFMl/wSeXd4DMAX3lOZqPnUVZC?=
 =?us-ascii?Q?GMgInEzFDRqvRUk4O7tE2SQpyToaHjmduUSerSxoHhv7BqXR9wr8Qv/Dafrs?=
 =?us-ascii?Q?ye5mXfvA+PhKMUGDgOJU7GxxFLGzkmrq4vC/2MZLAn3FopvWGUEIbLiJquxL?=
 =?us-ascii?Q?q+PC52khGnL4KsJ0YkAomaTMXiKIfiR2SAG6NK+KKLi2VQOk9T13zf456rfG?=
 =?us-ascii?Q?QrrDdHocul65zFdxi82OkU4ADe13I/CktMSe0nZunGf4pSo3oUFbYQHZc8eh?=
 =?us-ascii?Q?/nh5yVns5TD8han9HDs9plaUHqIgs9zZZl5MhsYo?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a630aee9-5816-4660-ad18-08dc4cce57ff
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5389.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 13:20:30.4681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FOlJQQ6TiJ/VeCH47+SbqdIvlAzcEjhj3lsZyqQP33Ii3R34YiCVTbydfnEsgaKttlhFZn3FIzHHZlwNbLcaDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9238

This fixes the settin of the adapter address type for unciast
scenario. Currently the address type is searched in data->adapter
however, this pointer is null and leads to the crash listed at the
end of this message. Instead, the address type should be taken from
the adapter variable, which is initialised using device_get_adapter
at the beggining of the function.

==321444==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000016
(pc 0x5601d284e03e bp 0x000000000016 sp 0x7ffdb164b740 T0)
==321444==The signal is caused by a READ memory access.
==321444==Hint: address points to the zero page.
0 0x5601d284e03e in btd_adapter_get_address_type src/adapter.c:545
1 0x5601d27a3f78 in setup_connect_io profiles/audio/bap.c:1860
2 0x5601d27a3f78 in setup_create_ucast_io profiles/audio/bap.c:2053
3 0x5601d27a3f78 in setup_create_io profiles/audio/bap.c:2106
4 0x5601d27a57cd in bap_state profiles/audio/bap.c:2143
5 0x5601d29d30df in bap_stream_state_changed src/shared/bap.c:1250
6 0x5601d29d71e2 in bap_ep_set_status src/shared/bap.c:4395
7 0x5601d293d592 in queue_foreach src/shared/queue.c:207
8 0x5601d2975c84 in notify_cb src/shared/gatt-client.c:2257
9 0x5601d2964217 in handle_notify src/shared/att.c:1012
10 0x5601d2964217 in can_read_data src/shared/att.c:1096
---
 profiles/audio/bap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 315eff729..030aa6ffe 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -1857,7 +1857,7 @@ static void setup_connect_io(struct bap_data *data, struct bap_setup *setup,
 				BT_IO_OPT_SOURCE_BDADDR,
 				btd_adapter_get_address(adapter),
 				BT_IO_OPT_SOURCE_TYPE,
-				btd_adapter_get_address_type(data->adapter),
+				btd_adapter_get_address_type(adapter),
 				BT_IO_OPT_DEST_BDADDR,
 				device_get_address(data->device),
 				BT_IO_OPT_DEST_TYPE,
-- 
2.39.2