Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2855-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Iulia Tanasescu <iulia.tanasescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: claudia.rosu@nxp.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH BlueZ 1/2] btio: Remove POLLOUT check from bt_io_bcast_accept
Date: Wed, 27 Mar 2024 18:10:18 +0200
Message-Id: <20240327161019.3078-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20240327161019.3078-1-iulia.tanasescu@nxp.com>
References: <20240327161019.3078-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tKvIdQlWxvdRn/hsbH56TdeA0L6D8+DR1evseq89icTVWoSds+S7MOcIbgtN?=
 =?us-ascii?Q?LDMalbIYN4DAd2mBSqubAyhEsYHtyAavBS8kv40N5U3xiP8M95+s2caZanFH?=
 =?us-ascii?Q?xIs5QjcxlQ6/KqkAXI7cgu7c53URhtLRsZuyL2gOatdbhlLIkAWbASiWvbf7?=
 =?us-ascii?Q?0f8pY2aMc6bF9JP8I+cq691gmfulR2bZbW+ypFVfV7KsRKnUAT43kIXbihIu?=
 =?us-ascii?Q?9JhV4LiIT25lcDj4aY/g0VDLwnR/S/KJCYnjAkvvfvrVj4t+NOBnsWiR4d3v?=
 =?us-ascii?Q?rWYmGqmash/dUugMeIsv0f+V7qS/H84yudBBRuHqGkwD0jZg8+n98yDAxnBT?=
 =?us-ascii?Q?dPzRHVDfGKvFU+HW12YrYeMmjIOgEkM1m5H+38lvr2m57KgtGu9qD79F5Cvg?=
 =?us-ascii?Q?gS+rGlxa0XNFoe3E59r38YoXullT+NIV91jHdeL28ZO0VHi3H9AvkJi0JQug?=
 =?us-ascii?Q?QQr9KL13XGM/MjuBT55/cBSxrDO6gIBqLKJHbqiFMDIRBkYQHMYVhz/A+t8e?=
 =?us-ascii?Q?mNN9ps95zW6DaBtztBfsB9cEGRHdmToRRISnm2CjQe5AR0Ieyhg/YHBPN8rr?=
 =?us-ascii?Q?DCNPUfs+ciscWAWrlQT9IWnFiIslT1yaYc3aAKuhZjDdoGvFf4V8eO+FC3/8?=
 =?us-ascii?Q?Z66yBQxf7I7ouK7B7g7Mm+Z7zur1z0GdgAhpruJyNSC3h+hKAUmlWfH7jgzI?=
 =?us-ascii?Q?Whseug7diJrVt+Sd2F2qBXr02BcFtwirdb66ljUPhk7H+fFDc9raxUWPTmQk?=
 =?us-ascii?Q?vfCGPX6ISYcErPdxuUK5NOBvvqU3119XQ9ZEmlv8pPM1YAH3xV7mIZ3Aml9W?=
 =?us-ascii?Q?pl3ANxMZDzTB305Dd3yNksyK9czAzwqZS90b8OhEJcTRt3ayT3VlwuEJYkgp?=
 =?us-ascii?Q?GUsZe14Qyjf1/+d1T2JzDR18uWmVH7qTUkyZ9B/cLlg+nnIk64lmvu975LcN?=
 =?us-ascii?Q?jcAMOLJ2HKAJ3uZ1D8ksmyjTBxQ/8avcG+ss4+KKNyfW//AlxOWAOSGIZfvd?=
 =?us-ascii?Q?xQijliPssYqQNPDFI+czOL1J+xSRfmO0TB1dUTsQ3emA7MG9Liz5q76IQ3Gt?=
 =?us-ascii?Q?Aae6AR6oCmm+oNGLajWo/1ndO6zn9CEFzFN24OWuN8GxLefkYgNQrtdlbOUR?=
 =?us-ascii?Q?K0mNZPED2zyGjMB0CbslY7U/R7FAYhSMx74ZfXaWGTadlaZDotRrNZB2LmrR?=
 =?us-ascii?Q?pACjih2Rt7Vgst748y1rcin5FOMdudgVTEFOB4SPe+KPt2dx+Eq3o/0UxNnS?=
 =?us-ascii?Q?5IRxZu7PkYgl3r5HKl206ecCOX9o5YQxFyYGKSFB/lPLOi4TugN4Zw/nb7RG?=
 =?us-ascii?Q?L2vSUPE0vHjGi64kB8jEoB9U2N/5fCkELRKWl6nZCyeGXdgpGviCpvdziWjj?=
 =?us-ascii?Q?BAzUp7/K0H45TNCwpultgRGbAkfNXeje/sieNTXgnXQ8uO08HdFccnfVmoQr?=
 =?us-ascii?Q?cSjERgyzX8RbGNq52aJkJOcS1+2fj96+TTZZnkTODUz0VScjaX+3CsR6Xd6H?=
 =?us-ascii?Q?k00axZEf9XfS5P5klNMSKJ8KXcrxVseOLn1BmrwTaQuE6MHOUiptw2GJ7m5N?=
 =?us-ascii?Q?0UjmxaCTpv4YYNbMdiZdj7RDB1MOOFRfO+61jWYVTAYrcf3zKTIxucACy/X9?=
 =?us-ascii?Q?zA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61ef5eee-1f5c-4eca-08a6-08dc4e786a53
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 16:10:26.7727
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DE04yRMb2cvBgSAOgnRihJ5k5CvQm6kX7+ZIDfzyxYLV3uq3o5hxVDazqGkuN1BcGXuppD1wI/80llKCgCYLHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7648

For the Broadcast Sink defer setup scenario, there is no need to check
for the POLLOUT event on the PA sync socket before calling "read" to
issue the Create BIG sync command. This check has been inherited from
unicast, but it is unnecessary for broadcast, since currently after
accept and read, the event to signal BIG sync established is G_IO_IN.
---
 btio/btio.c | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/btio/btio.c b/btio/btio.c
index d30cfcac7..2d277e409 100644
--- a/btio/btio.c
+++ b/btio/btio.c
@@ -5,7 +5,7 @@
  *
  *  Copyright (C) 2009-2010  Marcel Holtmann <marcel@holtmann.org>
  *  Copyright (C) 2009-2010  Nokia Corporation
- *  Copyright 2023 NXP
+ *  Copyright 2023-2024 NXP
  *
  *
  */
@@ -1800,7 +1800,6 @@ gboolean bt_io_bcast_accept(GIOChannel *io, BtIOConnect connect,
 {
 	int sock;
 	char c;
-	struct pollfd pfd;
 	va_list args;
 	struct sockaddr_iso *addr = NULL;
 	uint8_t bc_num_bis = 0;
@@ -1857,22 +1856,11 @@ gboolean bt_io_bcast_accept(GIOChannel *io, BtIOConnect connect,
 			return FALSE;
 	}
 
-	memset(&pfd, 0, sizeof(pfd));
-	pfd.fd = sock;
-	pfd.events = POLLOUT;
-
-	if (poll(&pfd, 1, 0) < 0) {
-		ERROR_FAILED(err, "poll", errno);
+	if (read(sock, &c, 1) < 0) {
+		ERROR_FAILED(err, "read", errno);
 		return FALSE;
 	}
 
-	if (!(pfd.revents & POLLOUT)) {
-		if (read(sock, &c, 1) < 0) {
-			ERROR_FAILED(err, "read", errno);
-			return FALSE;
-		}
-	}
-
 	server_add(io, connect, NULL, user_data, destroy);
 
 	return TRUE;
-- 
2.39.2