Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2903-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ee6259a2-05c3-4d6d-9dda-7a7b8f55fbfe@molgen.mpg.de>
Date: Thu, 28 Mar 2024 14:23:19 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Bluetooth: btintel: Add devices to
 HCI_QUIRK_BROKEN_LE_CODED
To: Werner Sembach <wse@tuxedocomputers.com>,
 Marcel Holtmann <marcel@holtmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Christoffer Sandberg <cs@tuxedo.de>, linux-bluetooth@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240328131800.63328-1-wse@tuxedocomputers.com>
Content-Language: en-US
From: Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20240328131800.63328-1-wse@tuxedocomputers.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Dear Christoffer, dear Werner,


Thank you for the patch.

Am 28.03.24 um 14:18 schrieb Werner Sembach:
> From: Christoffer Sandberg <cs@tuxedo.de>
> 
> For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
> connection issues when enabled. This patch disables it through
> the existing quirk.

It would fit in two lines with 75 characters per line.

On what hardware with what clients do you experience this exactly?

> Signed-off-by: Christoffer Sandberg <cs@tuxedo.de>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> Cc: <stable@vger.kernel.org>
> ---
>   drivers/bluetooth/btintel.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index cdc5c08824a0a..6dbfb74d0adf9 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2881,6 +2881,8 @@ static int btintel_setup_combined(struct hci_dev *hdev)
>   	case 0x17:
>   	case 0x18:
>   	case 0x19:
> +		/* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */
> +		set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
>   	case 0x1b:
>   	case 0x1c:
>   		/* Display version information of TLV type */


Kind regards,

Paul