Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-2939-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <e7dfb37d-9163-4d58-aafb-2a2ebca73c4d@molgen.mpg.de>
Date: Fri, 29 Mar 2024 10:13:01 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH BlueZ v1 1/1] Autoconnecttimeout max value increased to
 20000 msecs from 16384 msecs
To: Mahesh Talewad <mahesh.talewad@nxp.com>
Cc: linux-bluetooth@vger.kernel.org, devyani.godbole@nxp.com,
 luiz.dentz@gmail.com, sarveshwar.bajaj@nxp.com
References: <20240329063534.56892-1-mahesh.talewad@nxp.com>
 <20240329063534.56892-2-mahesh.talewad@nxp.com>
Content-Language: en-US
From: Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20240329063534.56892-2-mahesh.talewad@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Dear Mahesh,


Thank you for you patch.

Am 29.03.24 um 07:35 schrieb Mahesh Talewad:
>   - In implementation Autoconnecttimeout max value is 16384 msecs.
>     Increased this Autoconnecttimeout max value to 20000 msecs.

Please do *not* format it as a list item. I’d also rewrite the commit 
message summary/title to use imperative mood:

> Increase autoconnect timeout max from 16.384 s to 20 s

Please also add, why this change is necessary.

> Signed-off-by: Mahesh Talewad <mahesh.talewad@nxp.com>
> ---
>   src/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/main.c b/src/main.c
> index b1339c230..8ce72badc 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -656,7 +656,7 @@ static void parse_le_config(GKeyFile *config)
>   		  &btd_opts.defaults.le.autoconnect_timeout,
>   		  sizeof(btd_opts.defaults.le.autoconnect_timeout),
>   		  0x0001,
> -		  0x4000},
> +		  0x4E20},

Please add a comment with the decimal value. (Or why not use a decimal 
value?)

Also, isn’t

2 * 16 + 15 * 256 + 4 * 16^3 = 20256

Why not just use 0x5000 (= 20480) to make it easier to calculate?

>   		{ "AdvMonAllowlistScanDuration",
>   		  &btd_opts.defaults.le.advmon_allowlist_scan_duration,
>   		  sizeof(btd_opts.defaults.le.advmon_allowlist_scan_duration),