Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3200-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Mahesh Talewad <mahesh.talewad@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: devyani.godbole@nxp.com,
	luiz.dentz@gmail.com,
	sarveshwar.bajaj@nxp.com,
	mahesh.talewad@nxp.com
Subject: [PATCH BlueZ v2 1/1] Increase autoconnect timeout max from 16.384s to 20.480s
Date: Thu,  4 Apr 2024 14:40:54 +0300
Message-Id: <20240404114054.4987-2-mahesh.talewad@nxp.com>
In-Reply-To: <20240404114054.4987-1-mahesh.talewad@nxp.com>
References: <20240404114054.4987-1-mahesh.talewad@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ljnfFPufk2iOhSE2j7n29gOknRCpFZibs5kLVINxVk1peHVQ0TJNQUHKBDyo?=
 =?us-ascii?Q?zxZEcrIGrGCXMsIp96mSEK2uLhk1uixdf0pjjNtQEFwm5BVZnn9yz+0kcvaA?=
 =?us-ascii?Q?tC0mo3GfVfKSykBD8mvtfAQj7a9FzAfsZKd9OSB/xXQORZ24RJlsV2xNnYL8?=
 =?us-ascii?Q?3ycgUPswy14EcwUAZp1qoFjehrBDE7ty7sth2Gd6qYPasVn7SMW3m/JbN0PT?=
 =?us-ascii?Q?45461vKZe+NxNS/ieB7uKBXAZpVRnYqdd2tv+8S2sihsVvkkVwCqCjfLE5Gn?=
 =?us-ascii?Q?nKGQMjWH83pHNX+NjYwT1yvIA6RNQwJZLiXtMFqg1ZeU6jQCw6Yz96IVcMk/?=
 =?us-ascii?Q?VW21v6UXtzHZnxB2rarXAY1A5Eq29CUGNlsRf3rXC2/yGAy9CM0GI3HIAqPI?=
 =?us-ascii?Q?IYxwU5sfrFBvw8Rn4QbWoxNC/y0SPy6LglL/Nc9Lp21qEKU59MzBQE9cQE7b?=
 =?us-ascii?Q?d14iP1RrO8j/bHgQlTE6Jbia8p98IG2/ZokcbkSlIvHoVCxFO0j4olTg/n9R?=
 =?us-ascii?Q?THwhZgM80zm+58WCCeO3Qt1DigxoNv5OmdAgZ550CvrvuVGQVQ7hBQAlKSOP?=
 =?us-ascii?Q?qokT2CLqQ4DVseRtXwMRjfN1tz4A7LoGp/RXI+yeZ19le1Ky8dfGx8zhHj6D?=
 =?us-ascii?Q?c4pwdbzmwdIDz51wCcm7SwM7Q7aKMjO3ZN5iKya7aMtA0QwAe+6d3Ie3G30k?=
 =?us-ascii?Q?F/fhGVluneq/IkFAnLgjKnRTYx27gVLvHzfIkf3bBTrYvyqxork+iv8LAP7E?=
 =?us-ascii?Q?OquRJSayRN/gEp0jZMHFEcHl7/9b0ERy7ShEVIAEKPFZFSdtTVURckW/aj0r?=
 =?us-ascii?Q?HAe/7zBQKdmMAiG5JAble/laoU7ANN1qMBUk8xU0Ya722pH5BodMNuZPYWym?=
 =?us-ascii?Q?HOaYsMz7U5AQ7Suv1wkRDBjw7JjN+mpLWAJjjRYjB1amlx5vpYkWBhfSq74K?=
 =?us-ascii?Q?eR2RZmKsWscDAhBad6rZzvVBlrnNOvG2F0NawbH/wXaFulJgKhk5m3RqVPhd?=
 =?us-ascii?Q?iKl3JaWqPsiJbBf9ykw6oKhS4yzIyvJzSMLewhmeG5zjTMP85cCKD0EOQhky?=
 =?us-ascii?Q?dMWBu2kLXARI9SnMx3DulBZJA9LoWQoYzDQpk9XEeeJIocFg+kabqkdm/FR5?=
 =?us-ascii?Q?5Rm/JKNK073PAscAmc+tvgewLWo2k5xMAt7fmSmHIN2wo46ljA0K8D+hMJ5S?=
 =?us-ascii?Q?O6BHpcaufA1iNNeZufYB+YRaIvWz5mAwxZWMc/XWnf/mDQUTNT1bk6NvE9Kf?=
 =?us-ascii?Q?rN1dtu1lPFsa5SE23iOE6c/K0CiOHz48sNkwAmCshfpIjDBxQDhCf5z1sRR9?=
 =?us-ascii?Q?gXA3KvIRAmGVMji08go+ya5tgMUpLx70/OZbWS+/bGDtmZ5kQ8f3fuQnunmR?=
 =?us-ascii?Q?fznBSJWZmfbByqpcWmXnk/bG+TRRQwRtMsfW7BsAwBq2BhkfJYNbqyWWPqZa?=
 =?us-ascii?Q?pbxLno7F4nQoqt0lmPgNpXDpq/Oa3MckQNQwngdY9K9y9JdeOiGmczyTMoVF?=
 =?us-ascii?Q?Jmp8KGMx5B9D99bNUURcUHj7cGlH+boWOOaNjwRy7jqv9dEf7Va0AXlYrPpE?=
 =?us-ascii?Q?9tcvuKNzytcKVEGGrlzb2bX4P7RCPPPlKKpl6yVfg0xmN7VpIzXjYYI+vqbB?=
 =?us-ascii?Q?EA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f591f88-082c-45f1-07ff-08dc549c29ff
X-MS-Exchange-CrossTenant-AuthSource: AS5PR04MB9754.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 11:41:27.8482
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pXRRuvxDiCMq9Y0DqXVPtwawXwYnedFL3/x6ncEpRp7ynYUE3F+tJI8jraB1+UhGGYU+NOQHhl69w9DmlIzgow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10443

 - In current implementation Autoconnecttimeout max value is
   16384[0x4000] msecs.
 - Since some controllers need some more time to respond to cmd
   'LE Extended Create Connection' hence increased this
   Autoconnecttimeout max value to 20480[0x5000] msecs.

For ex:
- In some controllers, If we include LE-Coded PHY in the initiating
 PHY List, BLE INIT scheduler selects the 1M and Coded PHY scanning
 as an initiator in round robin manner, and due to this available
 bandwidth gets distributed between 1M and Coded PHY, and this
 results in longer time taken for connection establishment by
 the controller.
- If ref device is advertising at 1.5 sec intervals, with create
 connection timeout of 4 sec,  the controller gets only 2 opportunities
 for the connection. Without the inclusion of LE-coded PHY,
 DUT takes ~3.8 sec for the connection establishment.Hence as described
 in above point  with the inclusion of LE-coded PHY it is difficult to
 achieve 100% connection success with the device having
 adv interval of 1.5 sec.

Hence increased Autoconnecttimeout max value to 20480[0x5000] msecs.

Signed-off-by: Mahesh Talewad <mahesh.talewad@nxp.com>
---
 src/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main.c b/src/main.c
index f774670e4..081a388ad 100644
--- a/src/main.c
+++ b/src/main.c
@@ -657,7 +657,7 @@ static void parse_le_config(GKeyFile *config)
 		  &btd_opts.defaults.le.autoconnect_timeout,
 		  sizeof(btd_opts.defaults.le.autoconnect_timeout),
 		  0x0001,
-		  0x4000},
+		  0x5000},  /*max val: 20480 msec*/
 		{ "AdvMonAllowlistScanDuration",
 		  &btd_opts.defaults.le.advmon_allowlist_scan_duration,
 		  sizeof(btd_opts.defaults.le.advmon_allowlist_scan_duration),
-- 
2.34.1