Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3289-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240404123602.2369488-1-edumazet@google.com> <CABBYNZJB+n7NN2QkBt5heDeWq0wbyE1Y4CUyK9Ne7vBRnmuWaw@mail.gmail.com>
 <CANn89iLweXJRLdn=v6WbqtvW6q0yLz_Dox87+GAnZUmx0WevKA@mail.gmail.com>
 <CABBYNZK08zDX07N9BTcFku=RSzc=W_74K2n2ky5f+qSexSLM+g@mail.gmail.com>
 <CANn89iLO9hO9QqQtNh=qEmLy+tE2Dr7fe9Nuj2dxYrG-z0Cy5g@mail.gmail.com>
 <CABBYNZ+F44x3aYK1kKUi8vLJT04QF48ONzrW06YJz=aq_oSHzA@mail.gmail.com> <CANn89iJzJc+qNgwnEuzGReXqp6Gs7hWnex0_+f2CP9eTuohZyA@mail.gmail.com>
In-Reply-To: <CANn89iJzJc+qNgwnEuzGReXqp6Gs7hWnex0_+f2CP9eTuohZyA@mail.gmail.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Fri, 5 Apr 2024 13:38:37 -0400
Message-ID: <CABBYNZK=oKCcMv8GEx__XiR+tSUwoTnwRkh2-6tJw1He9oGr6w@mail.gmail.com>
Subject: Re: [PATCH net] Bluetooth: validate setsockopt( BT_PKT_STATUS /
 BT_DEFER_SETUP) user input
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, 
	Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org, eric.dumazet@gmail.com, 
	syzbot <syzkaller@googlegroups.com>, Marcel Holtmann <marcel@holtmann.org>, 
	Johan Hedberg <johan.hedberg@gmail.com>, linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Eric,

On Fri, Apr 5, 2024 at 12:30=E2=80=AFPM Eric Dumazet <edumazet@google.com> =
wrote:
>
> On Fri, Apr 5, 2024 at 6:24=E2=80=AFPM Luiz Augusto von Dentz
> <luiz.dentz@gmail.com> wrote:
> >
> ave used this so far (without risking a kernel bug)
> >
> > Fair enough, if we don't really have any risk of breaking the API
> > (would result in using uninitialized memory) then I propose we do
> > something like this:
> >
> > https://gist.github.com/Vudentz/c9092e8a3cb1e7e6a8fd384a51300eee
> >
> > That said perhaps copy_from_sockptr shall really take into account
> > both source and destination lengths so it could incorporate the check
> > e.g. if (dst_size > src_size) but that might result in changing every
> > user of copy_from_sockptr thus I left it to be specific to bluetooth.
>
> Make sure to return -EINVAL if the user provided length is too small,
> not -EFAULT.

Sure, there was also a use of -EOVERFLOW and the fact we are using the
return of copy_from_sockptr so if it fails we just return -EFAULT
anyway, so if we do start returning the error from the like
bt_copy_from_sockptr then we better figure out the errors it returns
are proper.

Btw, do you want me to spin a new version containing these changes or
you would like to incorporate them into your patch and spin a v2?

--=20
Luiz Augusto von Dentz