Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3395-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <000000000000b0848f061553f0d5@google.com> <tencent_D423A78448F764177A26CAB3716365096705@qq.com>
In-Reply-To: <tencent_D423A78448F764177A26CAB3716365096705@qq.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Tue, 9 Apr 2024 10:13:52 -0400
Message-ID: <CABBYNZJ-XJv8nLC9WMcMskYtAkzir5JC+wFNZwk+5k-85g2gRg@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: fix oob in sco_sock_setsockopt
To: Edward Adam Davis <eadavis@qq.com>
Cc: syzbot+b71011ec0a23f4d15625@syzkaller.appspotmail.com, 
	johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, 
	linux-kernel@vger.kernel.org, marcel@holtmann.org, netdev@vger.kernel.org, 
	syzkaller-bugs@googlegroups.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Edward,

On Tue, Apr 9, 2024 at 9:49=E2=80=AFAM Edward Adam Davis <eadavis@qq.com> w=
rote:
>
> If optlen < sizeof(u32) it will trigger oob, so take the min of them.
>
> Reported-by: syzbot+b71011ec0a23f4d15625@syzkaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@qq.com>
> ---
>  net/bluetooth/sco.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
> index 43daf965a01e..815646d9e72b 100644
> --- a/net/bluetooth/sco.c
> +++ b/net/bluetooth/sco.c
> @@ -890,7 +890,7 @@ static int sco_sock_setsockopt(struct socket *sock, i=
nt level, int optname,
>                 break;
>
>         case BT_PKT_STATUS:
> -               if (copy_from_sockptr(&opt, optval, sizeof(u32))) {
> +               if (copy_from_sockptr(&opt, optval, min_t(int, sizeof(u32=
), optlen))) {
>                         err =3D -EFAULT;
>                         break;
>                 }
> --
> 2.43.0

https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.gi=
t/commit/?id=3D289bfd91fcf22f7864f3817acff5d8ce9fe73307


--=20
Luiz Augusto von Dentz