Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3585-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Vlad Pruteanu <vlad.pruteanu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: claudia.rosu@nxp.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	iulia.tanasescu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Vlad Pruteanu <vlad.pruteanu@nxp.com>
Subject: [PATCH 1/1] Bluetooth: hci_event: Fix setting of unicast qos interval
Date: Mon, 15 Apr 2024 17:44:30 +0300
Message-Id: <20240415144430.34450-2-vlad.pruteanu@nxp.com>
In-Reply-To: <20240415144430.34450-1-vlad.pruteanu@nxp.com>
References: <20240415144430.34450-1-vlad.pruteanu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vsZxfUxm7U513nt66dZO0PwVABZW0SMtJKE8R1wPcskiLdkqHUPQit8oAEIS?=
 =?us-ascii?Q?NtwOZXzL/Z67RFzmzPaRM9nlVn1Pm4p0ShjGAtFSU6NC8MbVbgmERKmptQ96?=
 =?us-ascii?Q?+zIdyCuQOLhu8BlAMLb621LX9kTM99Mm0UKpEfnoKobfyKd5kQPU1YO3+yH9?=
 =?us-ascii?Q?8D3lyjej1DTg0E9kL0OaD0gSeTsBmEAat3kQQtYNDHqGuu4CpEPCBlMKAcrD?=
 =?us-ascii?Q?luVJDKR5PqMTSrXI9Y1A8TtEDvkxzrkiqTEuBir+KZUkg6/jtRSmfjkJDncl?=
 =?us-ascii?Q?K8bEhyRw7fz2tnRlOfI0NQhSx0DrOdBfzef/qXfc3o8ZBzAPNsjgLu7igEiI?=
 =?us-ascii?Q?t+Ybkfgj8tuikoVD3XgpJIxEaR+cKRuQOL+9q6WsJ3FpXNCqwHJHv1Ccf6EC?=
 =?us-ascii?Q?sC5qH9C98n3ASSo1kyZ3ZifV/pJAYfM5tyh4aV4Hrn0CXsoceJwCzHrS+H5d?=
 =?us-ascii?Q?jNd1NNFTA/VjWohCsmBLzv1KlRRZhOB+doHf7713oHWbu6cekmJyURzrqb+o?=
 =?us-ascii?Q?May/L+hUuOofaFJnPdOIk7jcvEU483nl00bt8GuufuA6Jaebvi3+7vMS4dDG?=
 =?us-ascii?Q?GpgdffL8nGOBwQ1dSplkgv8NcASFRD4cBlgE/u66nEQ252dNrd+O/K6n79qY?=
 =?us-ascii?Q?XGFjMv3+/3IEAI3V/fFQzjTFtWNH6w1cOTKI8w4Sv9RbhAgzHM5bTC1gPlUy?=
 =?us-ascii?Q?OL7an5Rw7CM1D22PrJOa2rReIYz2VXtKqoNxhjV9NMp1Lz3i1kynct+jch97?=
 =?us-ascii?Q?8VRKrkG+T5i1xUaqESwp8Qu7FkvQZFI67NSR5D9i6q+kg6OVtgf0n4ybaPKP?=
 =?us-ascii?Q?1SjGgxOfJTKkeVGgJExKeXF1pBwR07hjvSaYZe56gLpf7BEU1m4peCaebJ9Z?=
 =?us-ascii?Q?NLKKfV1ICroNNktVVu4HRWg7x21jfekQ9Xc0w/L29UA0rqjzdT6mOLpGDLKP?=
 =?us-ascii?Q?PNGLUtk7KdRMW0zcAoAZywju6q2SZpbIga9TGb5WuAS7RWiRRsVSqvmlYNy3?=
 =?us-ascii?Q?UAhO9aoRHzw8Sk6ZhTS7NuFbsHSqwYoC0y/BGk7+UbTg87o/V+2oFQzdvfgM?=
 =?us-ascii?Q?ihw7jRU3Ez0yDBPto8qAD7uIlcHYQIVT9z5szGWaHxn9QCSF/UidRMX6IMFb?=
 =?us-ascii?Q?3DUxOFZnTmeTHlgtudwIW/vDEqd1NmgPa8AlgGRMlWXY/+WkMTi6SvwllV9Q?=
 =?us-ascii?Q?kfvipoXKMm4G0idSz96Obn98bQV6LCxOKWl5itiorFrnZ19CodzBTRHKmtu+?=
 =?us-ascii?Q?3gNxqE7pzxIubc0O7JL5GTnOYta55Wm/d/1ZkieF/TFvov5UL+ELA49Afcj9?=
 =?us-ascii?Q?9w8YDEN1cVt9T7puUoEyESokdnjUkeSPxsO0AS49FLq6j0xCWbsaiviQACU7?=
 =?us-ascii?Q?6N0IpwHKI3NjVEXCdLsOKDPJkwSz1y+gBC/7ecGNPwVvbAgyuvykktO2wLLW?=
 =?us-ascii?Q?E+5ypkzyjxRBNnMJ0IwLUQITLBReYW7KU3N8zqGVB1zMINttsyHZHEaOMoFp?=
 =?us-ascii?Q?dbgq7ZOWNSCpffdQi7yQGGU4oigeE1mefYhxnL+bG+qGONxbABslV/R/4zvw?=
 =?us-ascii?Q?+zBM20L6F5fPJqjyMv3YD+cTfrNaJC2ManYntYKH?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 151e7aa4-b5da-446c-f995-08dc5d5aaac2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5389.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 14:45:17.4567
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: czVNZOL4ZgFX3jHqDvGTp8qzxa4xUvM9VPKV5QZfKskMpwm8+UoV6N9Yzb2KRc4+GuU8ioGE9AMp9CEovUtIOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9151

qos->ucast interval reffers to the SDU interval, and should not
be set to the interval value reported by the LE CIS Established
event since the latter reffers to the ISO interval. These two
interval are not the same thing:

BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 6, Part G

Isochronous interval:
The time between two consecutive BIS or CIS events (designated
ISO_Interval in the Link Layer)

SDU interval:
The nominal time between two consecutive SDUs that are sent or
received by the upper layer.
---
 net/bluetooth/hci_event.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 868ffccff773..83cf0e8a56cf 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -6824,10 +6824,6 @@ static void hci_le_cis_estabilished_evt(struct hci_dev *hdev, void *data,
 
 	pending = test_and_clear_bit(HCI_CONN_CREATE_CIS, &conn->flags);
 
-	/* Convert ISO Interval (1.25 ms slots) to SDU Interval (us) */
-	qos->ucast.in.interval = le16_to_cpu(ev->interval) * 1250;
-	qos->ucast.out.interval = qos->ucast.in.interval;
-
 	switch (conn->role) {
 	case HCI_ROLE_SLAVE:
 		/* Convert Transport Latency (us) to Latency (msec) */
-- 
2.40.1