Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3597-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH BlueZ v1] shared/uhid: Fix crash if bt_uhid_destroy free
 replay structure
From: patchwork-bot+bluetooth@kernel.org
Message-Id: 
 <171321062687.2386.3115334938013550773.git-patchwork-notify@kernel.org>
Date: Mon, 15 Apr 2024 19:50:26 +0000
References: <20240415145444.857497-1-luiz.dentz@gmail.com>
In-Reply-To: <20240415145444.857497-1-luiz.dentz@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 15 Apr 2024 10:54:44 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> Id replay structured has been allocated it shall be set back to NULL
> after calling uhid_replay_free otherwise it may cause the following
> crash:
> 
> Invalid read of size 1
>    at 0x1D8FC4: bt_uhid_record (uhid.c:116)
>    by 0x1D912C: uhid_read_handler (uhid.c:158)
>    by 0x201A64: watch_callback (io-glib.c:157)
>    by 0x48D4198: g_main_dispatch.lto_priv.0 (gmain.c:3344)
>    by 0x49333BE: UnknownInlinedFun (gmain.c:4152)
>    by 0x49333BE: g_main_context_iterate_unlocked.isra.0 (gmain.c:4217)
>    by 0x48D4DC6: g_main_loop_run (gmain.c:4419)
>    by 0x2020F4: mainloop_run (mainloop-glib.c:66)
>    by 0x20254B: mainloop_run_with_signal (mainloop-notify.c:188)
>    by 0x12D6D4: main (main.c:1456)
>  Address 0x53ae9c0 is 0 bytes inside a block of size 40 free'd
>    at 0x48468CF: free (vg_replace_malloc.c:985)
>    by 0x1D8E19: uhid_replay_free (uhid.c:68)
>    by 0x1D8E19: uhid_replay_free (uhid.c:59)
>    by 0x1D8E19: bt_uhid_destroy (uhid.c:509)
>    by 0x1591F5: uhid_disconnect (device.c:183)
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] shared/uhid: Fix crash if bt_uhid_destroy free replay structure
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b94f1be656f3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html