Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp55783lqb; Tue, 16 Apr 2024 08:40:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV9tHW4uY6GyQOubS5AAkHU3izjMCbRo5Sv/siPCY2bYa9/pci51555Ec1e3x+My/Bn0FWC1w/zSqnLbTWPr+GnOnS11s9FaE3Enk69YA== X-Google-Smtp-Source: AGHT+IE7+ZGHTaSKb4AeU5VT84x/Gy2fT7Lx92Nm47nxloqUxVzmPYRxh4yQX/yr21KBkxxLIcQN X-Received: by 2002:a17:906:3293:b0:a51:d0e6:57ff with SMTP id 19-20020a170906329300b00a51d0e657ffmr8108382ejw.45.1713282047624; Tue, 16 Apr 2024 08:40:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713282047; cv=pass; d=google.com; s=arc-20160816; b=eR5FO94qBNI0JrKPxZby3tRZaYKpFEgHAKjRk13YskPNmEDVJfUrEGlogTo8zOgAnk f5LvqS7j3VVf4b1tiGJROpnWbKKOBrK0R+gmki10EWfPHBNeMrIU5RpWwYu2lQ6OetaW WdcTBQyOUVxnYpljSUmoPxfEKFpq+pmBinuBu3TyK1m7/hL6cXi46WcRVk7C9rjZ14DE CrzUtICqKUQT9/SA4XjMzj7oTNTeoJO3jAYXBGp6gxc5B9mgFfNq47OQq/bfbQUUq6bK 4rCjK2eKIEpQrXzBIOGOcinD7gpuDIz7TC+LtZ3Xw2iiuqNUGhr3Uh91iZfMkBVfJiiB v7BQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:date:message-id:from:subject :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=iKv2xN0zV2av9WqMWC+5ZQSOQq3DoD7l86lTT9bKJ8o=; fh=fAVvqa29TMCSLQ1BWo+IkeTh9vOt2h2EvlnFWIq0DOI=; b=c0T87/7HuzOJS7zFs7DgtOg3oVIywjhbflcZ8UNtaH5n3t/yXYYce2DJtr9zpFdgxh S09uwrC8m21wiQXqV7KRepLGtT12Irn9i0DECWh65TXkdFkYS0Jbq6t9tOM3xg21H+DK kgE5dyvURWycqBOnlFTfGfHekXzIxc8zRlU250YMGfvW2qT4QTB6IkAjCcdfiYpRZhcH 4DqfuV1ZuLoquxj6XhfLh66hH+kpDr2dSsqXLFm6Go30KGFtnfRkQP31Zx35GVtSVnO1 ejETNO9vhOqYd/FUM9GrlB60vX5fQvC1ELcRDRXeXLylc3ME+QGu5/o+dYB7pC5d6TzP Go3g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ieGCqeXj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3639-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3639-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id f8-20020a170906ef0800b00a526e91e175si2034214ejs.897.2024.04.16.08.40.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 08:40:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3639-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ieGCqeXj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3639-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3639-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3817C1F221A9 for ; Tue, 16 Apr 2024 15:40:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0DE8D1311B0; Tue, 16 Apr 2024 15:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ieGCqeXj" X-Original-To: linux-bluetooth@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C053130491 for ; Tue, 16 Apr 2024 15:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713282029; cv=none; b=e9d+X/45g9gXb6KzTl4zVfNOKEMhnUcoLJCFQqc/MuwP/uIsah8yPKr/ry92eKH6GBUq49f2lo5MkVzoMjcNfFgAVcwSF5AtEWANY9LDg66xf8zomxFl38ai2uetu/KmLVVAFerzwewGusYSZgo6mXVFvLg5y4NgzOB9cAu9IKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713282029; c=relaxed/simple; bh=2q5ai9V6hcdFkDRwdmMqrKpUuBsf4FbILAitbJ0WR90=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=ora36KrCaA2FamXpMTYPEBVUSUo2M3Slo3kH8NbIMlWbcL45oFYupnx1RdCC5htgTJVKsOJQU0DwqWsvCAjNmn2fCDveaWk81h1pmmSI+vuYB4h1GWpXBFm7qLdzpjYxaPIIoxffNbgA/9W4KFRqs+OxvvuEhv7Ybx0Jv4IJKXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ieGCqeXj; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id ED383C4AF07; Tue, 16 Apr 2024 15:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713282029; bh=2q5ai9V6hcdFkDRwdmMqrKpUuBsf4FbILAitbJ0WR90=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=ieGCqeXjYeH64UcrNoxQUy3q3MbpXqGv6xbRiqmjIsCWdte3fnWAu+l7E4zD/u1/H VNA0XghHgdR2uOS/5QAqoRLwlzxnoKASCR8gXgx+DYYA8/Ywj0bfgBo7CXtWL+hEfe H2q9TSb8PVHMBcE64JjpyRyitPTSDXiwRmTTgJX13W+UXUjeG1Yf/bYEAYpPMaQ5cp NZwNTbfWoD4G3V12WEqMNJccqEKnXYMPaxG64XVjp+QOAc6qAerzJO83ZhK5TQYYoe ZoCKhGjM3+n7odtSzeo5dJ+BE++RRoAp66ipHrDZJHWme3+BFA+y65WuSiERr61PrI JczagCWVeOMIg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id E235CD4F15D; Tue, 16 Apr 2024 15:40:28 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH BlueZ] set: don't modify input sirk key in btd_set_add_device() From: patchwork-bot+bluetooth@kernel.org Message-Id: <171328202892.2661.4948820778449077936.git-patchwork-notify@kernel.org> Date: Tue, 16 Apr 2024 15:40:28 +0000 References: In-Reply-To: To: Pauli Virtanen Cc: linux-bluetooth@vger.kernel.org Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz : On Sat, 13 Apr 2024 13:04:26 +0300 you wrote: > Currently, btd_set_add_device decrypts the sirk in-place, modifying the > key passed to it. > > This causes store_sirk() later on to save the wrong (decrypted) key > value, resulting to invalid duplicate device set. > > It also allows devices->sirk list to contain same set multiple times, > which crashes later on as sirks-set are assumed to be 1-to-1 in > btd_set_add/remove_device(). > > [...] Here is the summary with links: - [BlueZ] set: don't modify input sirk key in btd_set_add_device() https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b411b98bf4f5 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html