Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3800-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Pauli Virtanen <pav@iki.fi>
To: linux-bluetooth@vger.kernel.org
Cc: Pauli Virtanen <pav@iki.fi>
Subject: [PATCH BlueZ] bap: call select_cb on bt_bap_cancel_select() to clean up
Date: Sat, 20 Apr 2024 17:52:48 +0300
Message-ID: <7f5110805a5180fb910d735f631c6f3b9a19dee4.1713624621.git.pav@iki.fi>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Have bt_bap_cancel_select() to trigger the callback function with error
code, simplifying the cleanup when ep is freed while SelectProperties is
ongoing.

Fixes bap_data->selecting not being decremented when ep setup is
canceled, which results to transports not being created thereafter.

Fixes: 41d6c4e1c92f ("bap: cancel ongoing SelectProperties() before freeing the ep")
---
 profiles/audio/media.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/profiles/audio/media.c b/profiles/audio/media.c
index 144f6bfc4..07147a25d 100644
--- a/profiles/audio/media.c
+++ b/profiles/audio/media.c
@@ -1055,7 +1055,6 @@ static void pac_cancel_select(struct bt_bap_pac *lpac, bt_bap_pac_select_t cb,
 			continue;
 		}
 
-		req->cb = NULL;
 		media_endpoint_cancel(req);
 		l = endpoint->requests;
 	}
-- 
2.44.0