Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp1841588lqt; Sun, 21 Apr 2024 11:41:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVinKfXn3pKjIM0lTYc9dBXNiOoAaxLBH5IU1xZasIKmN46AZTe8zrD5ur94+D8BypbbiDjAnLd2SDXlTqmzdid/aAoUcqwdqaz86166w== X-Google-Smtp-Source: AGHT+IHwakg2vPTVLAF0ooj9ZkFpWqBvS0Ur121rr5pVzUF69NQCTwCNkpUTxmp+OhOn7oRhC0qr X-Received: by 2002:a17:907:94ca:b0:a55:8a04:d729 with SMTP id dn10-20020a17090794ca00b00a558a04d729mr8463166ejc.72.1713724887244; Sun, 21 Apr 2024 11:41:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713724887; cv=pass; d=google.com; s=arc-20160816; b=gGdxYE02ersI2Wqglg6nns3Rjk/HngyCGS3gL49a9F1WzeH8glUAOcs6R4MBoKmVD7 +LMlGuKjqPC58K+jb63oit1i9kA2vKPvmX3jktYE6l7aNlW18LawDrLvF/ylct5Sse00 /W/nW1o3J0q/eh2wz3uAYevTrDOvztO1FBHSRvotDaHRbYuS86jv6hAzynkNnLM1exVX gjMoSxzubxefe+CzuVD0uJaYQu6kAhSZrEgU/Vabwc+iCcvnisaKEmKjyQMxYnLid9eb j6RgTD45kuVFqBd+JVuQzxfQqEQ6NxmzDVkJ9wytxNdQzQbIoLoU03RetOapTqmb/KGd /w0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=xNjWc73cKzJKI968VgHKDytsDmegRzhHRd23Kr7kYMk=; fh=/17cU5F/FmySbaUSu3t75GvvuNaPB2qvvObT2VIdeDg=; b=0rD6uvLIcjJ/aXignmCOfWR/Zr5SGKrrINs6m5qTcte1Ihli+v2NMrU/A4S2pS80SD Cr+vmACPNGna3cnPSKUKRsFNV9xS0TAS9u0MULzRuEo5L62lsysXIO5lV+zZoyWKTBKQ kZCLVzf96Fqr497xa5H643NrDOWma7topg8RngFo4cfHWFzJqowd1iszymchF5WQgOgy QwmOvD89UTzSocC5pa7icdeUJ4dnjuRD3Taa0eTEJVrprojym/P6/Zup5o8DVqwjVIEU YrpXG32mOCZtdrlzeBCMFConmOB1FOCSR9BbbjYKJzgVm1FsDusH9tB2bUGGOA7KmDlV lH7Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Txlh1EDx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3816-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3816-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id dt9-20020a170906b78900b00a51a20c3aafsi4916172ejb.1043.2024.04.21.11.41.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 11:41:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3816-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Txlh1EDx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3816-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3816-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E7B281F2130D for ; Sun, 21 Apr 2024 18:41:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B162A3C684; Sun, 21 Apr 2024 18:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Txlh1EDx" X-Original-To: linux-bluetooth@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2162B18637 for ; Sun, 21 Apr 2024 18:41:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713724880; cv=none; b=nOtYvn7hIn6+yHoDno/W4WQl0esiiNl4tn2uJbj7QBVUqL5z7NWy+9y/YspBgo9EX7TBI0e3xZ++dMayiyb8JFUrnJQlwN+FQ1gUNg59WpEMrj4qyZBrh+4DBbbtnssQiNvlU/uzAgRTdR2vfd9f6wU6t9HfvoRQsNoEJ78FJq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713724880; c=relaxed/simple; bh=LJK9kz8kBnRTPBuNFBB8iNRhs3plrYSiP2IPTJxw4mE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Mrmz5k5NTRa3uXasnVwYBTuV5dWGxDG4rd6AOUv98pB4XF39My+raczBvHaKpwMGW39RW7dswPDfI8mNBpK9f3QCVUqjhm2T2bi++nMrzoJ/v8Li9XjqLFt/UvghAQk9uEFMEIYhgaaNWJrbMSWdgMvr5lpPj9qNDswl04BUXmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Txlh1EDx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BFA3C113CE; Sun, 21 Apr 2024 18:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713724879; bh=LJK9kz8kBnRTPBuNFBB8iNRhs3plrYSiP2IPTJxw4mE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Txlh1EDx+etRp63tzoZde6QpDO0JXQGuFgD+uFlcV8sr7GgsZA6u3NakdkT6XvWaC Syl25/iNE3U3ny+aHiGrznE0mDcrAW2vbvHIhS2+otGzeAP8voCZA3J3Dvfo1+ulkK Kw24mM4u1AYbYRfYlW3MDnj80+9uZCWR2G/tSxkxTMJEORcJwdsWi+maACysrbeirD pnNbJAmZ9F0KZ5+e6TjdN57SzrjiTx3TY6MkNaeH1y+HxefaKWaZCBDrMIJ87MjmWO YxAbCcmGGqU+zJfVeeZE7hlIoIgUqp6B9zB3sGw+7RHZjP4ZHvpsuk7YWCaF/qYl3X utyT56F66Nygg== Message-ID: Date: Sun, 21 Apr 2024 20:41:14 +0200 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/2] Fix two regression issues for QCA controllers To: Wren Turkal , Zijun Hu , luiz.dentz@gmail.com, luiz.von.dentz@intel.com, marcel@holtmann.org Cc: linux-bluetooth@vger.kernel.org, bartosz.golaszewski@linaro.org References: <1713564212-21725-1-git-send-email-quic_zijuhu@quicinc.com> <1713650800-29741-1-git-send-email-quic_zijuhu@quicinc.com> <369512e2-f091-4370-bce5-9ac32178dc4d@penguintechs.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <369512e2-f091-4370-bce5-9ac32178dc4d@penguintechs.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/04/2024 09:44, Wren Turkal wrote: > On 4/20/24 3:06 PM, Zijun Hu wrote: >> This patch series are to fix below 2 regression issues for QCA controllers >> 1) BT can't be enabled once BT was ever enabled for QCA_QCA6390 >> 2) BT can't be enabled after disable then warm reboot for QCA_QCA6390 > > @Zijun @Krzysztof and @Bartosz Would it be helpful for me to test these > to ensure they fix the issues I reported? > I look forward to someone testing these on other hardware, not yours. On the hardware where the original issues were happening leading to this changes, e.g. RB5. Anyway, the problem here is poor explanation of the problem which did not improve in v3 and v4. Instead I receive explanations like: "this is shutdown of serdev and not hdev's shutdown." Not related... "now. you understood why your merged change as shown link of 4) have problems and introduced our discussed issue, right?" No. I did not understand and I feel I am wasting here time. Code could be correct, could be wrong. Especially second patch looks suspicious. But the way Zijun Hu explains it and the way Zijun Hu responds is not helping at all. Sorry, with such replies to review, it is not worth my time. Best regards, Krzysztof