Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2228153lqt; Mon, 22 Apr 2024 05:28:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCULhfrMSYtlvxrrxTkBX6D5hiHoB+69IBU/6sgKQ8osBXikFFDEsIk2NDPUhyRy0IgUT209cKT4wFGtgGAOgzBf9U26EyI8IX+5/q4edA== X-Google-Smtp-Source: AGHT+IG8yS6jxo04KK+jkYHfORLKZ5N7lVEoSBMH+sbO8gjmXcGWW8koCQv/CPNc7VNaYtBv5utH X-Received: by 2002:a17:906:c04e:b0:a52:42e4:96e5 with SMTP id bm14-20020a170906c04e00b00a5242e496e5mr6156327ejb.6.1713788927014; Mon, 22 Apr 2024 05:28:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713788927; cv=pass; d=google.com; s=arc-20160816; b=LFbmMgMcRIaMZT0wmQUP/e1/rufwn1xkGCxBgjdTh4ZI/dmAJ0Dhbvv1vBWX7dMdEc Dn01LW1Rbk33Dz72QxbvaBkx25Ztrpfq43uiPezeLS+HNPHKu80oruowZMBY2el0c/0R K3wW9+nFXSQGmS6lMtshl5tgoPVEyUJyuOHL2ZgILq1mnVGBadYMsuy5Qz9SPP6N4OxC Bh2nf5THM/Yn8/iz2Rmqzc417IAGw6dk0uGyGq1h0wGR0TxUsEpmSnVxJAkCs/kgc67h /cPQk6gndfj2djSNho+L+z0ax0ZAhEqRlpuv/VbRyh2Il6IItYIDNsyxgDKA1hl2wM1u Qjew== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=/9iMXbeFxSIXiZmxUkrdGcecgFP59Xy7Fp0R24hhs5U=; fh=5SKpfDtSBJtIlCv5J/Lwepmb+faJOtfia644XosAi9I=; b=rdA0y2pGf/oiIkpsuFRSYn4YKWbPgON9ngno4RwUDdyP2g8x3NRsjMp+kUlKkVaoGW H/+AG6hCS+W42iqW/lJRPb4f12Ol4uMdAMFdBPwYDXwmsqsnQcLsUUpyEcbdjABSLVl0 kPhMcvHHJXy6b1AviLglvjHKXx4i1PkCkUxe/hVQv8uI7R8L3uWFBIKCVx4gwqNLVun3 a7T2GbdCcYGreaRroxQxF5bzW32y8wYwy5uK661Cw8KG7AtxHTs5CMumGqf1ERIpk1q9 64AYWpxwtsM1GHtZs5oZCB9WamRdDhll6ovCK8dAoV5xZqgtNkVjZEH6SelN8OM49oSZ dbLw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lx7yMB76; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3854-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3854-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id p22-20020a17090628d600b00a520d167203si5509565ejd.974.2024.04.22.05.28.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 05:28:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3854-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lx7yMB76; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3854-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3854-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BB33A1F22298 for ; Mon, 22 Apr 2024 12:28:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4948C1474C8; Mon, 22 Apr 2024 12:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lx7yMB76" X-Original-To: linux-bluetooth@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A48284AEE0; Mon, 22 Apr 2024 12:28:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713788921; cv=none; b=C4ouENt7MqlN3/gVtE9Jen4CC/GNs0DgQSCXAwOBLVWUuDbS4S5oMmNPUP4S5Je8oxmImnnV2vjXTFkEiJ+rcJ29n9ZPaUbN2B8Vaqag+ljNCEgBNlWh0KurYYtr2cVP0BMn8CUTjCiaF7pgQCWIQOwHpzLHODkQZR9zscdrRGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713788921; c=relaxed/simple; bh=eaYm2Uu0QWHzjY18UgzPa0DZyWpa4ImaNflt3uaJ6Us=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WJkmkfuSfAVhzs8dfdrU/a0QTIQvURnG4keFztAbGqt8c7j/Bua7vS8Mk0tgeI+0HdrLLXJW09MoHrDiDnzV/f5tgNSoO5Uj6tUKS1eVnTp10YMUsEhHErAnm1oSwt6vAFp51NLS/9Ra8Wn3neJ8+htktGn2c7L0di+5lUahMjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lx7yMB76; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBA1AC113CC; Mon, 22 Apr 2024 12:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713788921; bh=eaYm2Uu0QWHzjY18UgzPa0DZyWpa4ImaNflt3uaJ6Us=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lx7yMB76km0UGZ+3BR3j3bMtInPKyZMWbqxcKbx3hFSZbckT8qw01PVp1fPw4OzWm 4Lq30BfL+MW2X0gc+ajdtvHMGGd76Lhenl59quVqwImBSF/6FTm7z52t3Q1s4Xj9/i PORK3o/wXJrlxuKrvTXqUqBYFbcKYukthvmqSla6ACY4N+eL8zmtdyxeP6DLFloysH bxQE3qyVVV50Uc7ekfo9cWr92jEi9zhYUjzzfmwSF974fYtB96OisqotprN+CDoft6 RdpmxMAhCLKyOm8u4jMyUcdFNiWWNVUtaQvvsAej9kLTwUYWrpxMAdtOaIP2ubwiuq oMKqxi+HPiyhA== Message-ID: <44d9ebf9-3621-4c67-bfa5-c10df24bc058@kernel.org> Date: Mon, 22 Apr 2024 14:28:37 +0200 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/2] Fix two regression issues for QCA controllers To: quic_zijuhu , Wren Turkal , luiz.dentz@gmail.com, luiz.von.dentz@intel.com, marcel@holtmann.org Cc: linux-bluetooth@vger.kernel.org, bartosz.golaszewski@linaro.org, regressions@lists.linux.dev References: <1713564212-21725-1-git-send-email-quic_zijuhu@quicinc.com> <1713650800-29741-1-git-send-email-quic_zijuhu@quicinc.com> <369512e2-f091-4370-bce5-9ac32178dc4d@penguintechs.org> <2bd1f1bf-f867-4430-8ce5-c691485665e1@kernel.org> <96702ddc-ef5c-499c-abd4-95f89eb3aeba@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <96702ddc-ef5c-499c-abd4-95f89eb3aeba@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/04/2024 12:05, quic_zijuhu wrote: >>> 3) qca_serdev_shutdown() is serdev's shutdown and not hdev's shutdown() >>> it should not and also never get chance to be invoked even if BT is >>> disabled at above 2) step. qca_serdev_shutdown() need to send the VSC >>> to reset controller during warm reset phase of above 2) steps. >> >> Anyway, any explanation providing background how you are fixing this >> issue while keeping *previous problem fixed* is useful but should be >> provided in commit msg. I asked about this two or three times. >> >> BTW, provide here exact kernel version you tested this patches with. >> Also the exact hardware. >> > there are almost no commit with tag Tested-by also provide exact kernel ?!? So this was not tested at all by you on mainline kernel and you push downstream patch? That's how shall we understand this? > version. for one type bt controller. different h/w has different config. > important is that this issue is fixed in reported H/W and don't cause > issue for other issue. Amount of pushback from your side and ignoring questions raised during review is way too much. > > let us stop here and wait for other comments. So why do you push again in v5? Best regards, Krzysztof