Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3901-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Sarveshwar Bajaj <sarveshwar.bajaj@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: vinit.mehta@nxp.com,
	devyani.godbole@nxp.com,
	mahesh.talewad@nxp.com
Subject: [PATCH BlueZ v1 1/1] Fix null pointer deference in bap_get_ascs()
Date: Tue, 23 Apr 2024 13:14:25 +0530
Message-Id: <20240423074426.62480-1-sarveshwar.bajaj@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tHm8vshlmKaNsJuy+nal6TxDsjiFpYhfjXwLIWslATIymBNRNb3Za6fHD2JR?=
 =?us-ascii?Q?j+iRYprVMMosQ14R/Mreo0PK1pxVjYk/97NYzQtcEP2T3mpPloppR/dDnhHK?=
 =?us-ascii?Q?SrofRuuNvTo4bXDlzqdeEV8kf4t3XjqXXpO7y+NGyTMFTfGdAGaZzTHCuFuu?=
 =?us-ascii?Q?VPOxmLMBpq+W9L7PUE8eWuVahUj7HKWWsMcfhGXoQKIehA3wjGfs3Tqcko68?=
 =?us-ascii?Q?ZTWrHsW02gCqBPOGADDDjkj5Cc3DiRL5zlemst+3WI9EQdboAXv3LfrVzPw3?=
 =?us-ascii?Q?RKLexZk8R4fHyHw7VL1pCsl7HN8FkJnvn+59u6A+oOPSKZMTUVQCGUDUiVjn?=
 =?us-ascii?Q?MVX3+PnGQ+PKf5EwJxlbEwSnWwIIAlxHjP0GqGUpVjqQ4OaoeST2nAvgauut?=
 =?us-ascii?Q?bcNrEgPgFGNsbIl1N1+xfOtRD85sRK4mQlPYhFu3zY0hpvHU/VXbm4NGUDIC?=
 =?us-ascii?Q?tX8hG04QUgqhxTSXb25sqKDHvJ6fpKUexy/XW/YWLRiPbEpY5yg099o/zxm9?=
 =?us-ascii?Q?p1JscJmioDerzJsnt07XnrPMjjEPZebNu3aNTQDCEMbcpbcuFB2tTesgBGnc?=
 =?us-ascii?Q?OrwJx0/6Rcth2QVNfKoa3t2SyhzM3hmz45096+p/YmZAIeEl4HVp/Ag3Rk8n?=
 =?us-ascii?Q?9/Q7c32wMmYw2T7FY0bmOERNEysPz5pdVoYjiStXKXlOri3I6NS46hfaxTyC?=
 =?us-ascii?Q?fz5Hs0hlB98fBlgnLB+2jcCYH+KnCJahfQsSzN6QC4tuV0v3OlaJ25nw2AHv?=
 =?us-ascii?Q?JZN9imNggacUK6JwGJZi8oaiY2//8+LRfc6/JK7ROy946cSxKF80/CNBTuvt?=
 =?us-ascii?Q?WdxP/GSMeIGthI1jMVNKfHG8boIvbz8+nZhmGlcKZgCKS+QBGYw59T8ZsuXh?=
 =?us-ascii?Q?Hhs8IhRw6fNOeZfRjU8OSQ5pZdSC28IHAnp5qtEaYLPDj51BMEEuFUm2NFf3?=
 =?us-ascii?Q?C22rcJE1mXTYLiKMOlTYYE4dzAXUHNR1aHtkdyJAKT3EcAocSzr41VHO9kDZ?=
 =?us-ascii?Q?Ggi+yrCpH2s3ajnLAYMEmeze5QO9h4p0nrPM0Xv21YTtPDXt/MrsZeQQ/yrC?=
 =?us-ascii?Q?T0XductIsTmb7a9ONgE2iJupqBhVn2jH/7QXyY6cH1zoQzo6BW7rTU7OoIwJ?=
 =?us-ascii?Q?J1HhoJJfM/ujoc3gklyWfxVh9sctW8/sQ88VnpICy8OWRfYcnQVre2vK28D0?=
 =?us-ascii?Q?1PzFXCSSrI4LjosbritEMYvvWU2cehvFzyDfSiJGFuqTWa16aTR1yy1TYFPA?=
 =?us-ascii?Q?/dE/tgkJ5N9ttAF84m5qsVQozZOuITaMrYDrKxsMJydlM1xd2b8YAJ5wHbol?=
 =?us-ascii?Q?tCZYAXhbjx89VfEbivvXFXyFEMVgNknG86M+UL2hOW7MyNC3/SevlxHpqeCw?=
 =?us-ascii?Q?B7SCQPcTgK37G0uxewPGqpH4fQAkmR8wgZP09eAsdOcJfDykdRy/4SJEtCPb?=
 =?us-ascii?Q?Ore8W/qMN4dJwd2TTIBC7UJO1Fy7UaBHj9uLKuK3AWRS8foNZsccGvSnkgpM?=
 =?us-ascii?Q?3F7aZPDE0D9T2B+Q9qwjVGIS9j07fZJja1wnSOO84WPnLUnth7xZnagvswmi?=
 =?us-ascii?Q?rU7yzo4LgTYYdojW0JLUOLqNqah7+lqbaFPJvpaYoNu1EU88CIrY2jFVvvmh?=
 =?us-ascii?Q?EA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20be2008-3971-4f1f-2920-08dc63693cc9
X-MS-Exchange-CrossTenant-AuthSource: AS1PR04MB9630.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 07:44:42.5942
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EFOACHfpJHtKZm2RfDX4Fg1P3c5A+YMyGuEvHUyeIt1a3hbrZYcNafxd26q9S0RhkkBnsnNQx6d8mb2x3VU1y8vUiVNdGIy5vFoKCf2EJTk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6920

Ensure that bap and rdb pointers are valid before accessing or
allocating memory for ascs. Added  null check to prevent potential
crash
---
 src/shared/bap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 71eadbdb6..0db9ba285 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -1405,7 +1405,7 @@ static bool match_req(const void *data, const void *match_data)
 
 static struct bt_ascs *bap_get_ascs(struct bt_bap *bap)
 {
-	if (!bap)
+	if (!bap || !bap->rdb)
 		return NULL;
 
 	if (bap->rdb->ascs)
-- 
2.21.0.windows.1