Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp183265lqd; Tue, 23 Apr 2024 21:06:19 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU6ykWZNh1zVonsWbYQwgsvD65zK8csMVx+X1tv+U+CeOukjl4S98c7gNIILKB40jNVV+PT6Oc+cWAP2DYwZEw0KVX6jecLlEInHyJCQw== X-Google-Smtp-Source: AGHT+IFSGemaBgCC+7F6O1Re9mebwnx3gbdh5dVNH0dQokGoIONVoR0gH2ywH3/KPvys8G34+iwl X-Received: by 2002:a17:906:d9d0:b0:a58:8864:8f1b with SMTP id qk16-20020a170906d9d000b00a5888648f1bmr662036ejb.17.1713931579651; Tue, 23 Apr 2024 21:06:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713931579; cv=pass; d=google.com; s=arc-20160816; b=swdsYUU4gcRBb1x3oLUE8Q8J+gVmny5Hi9U2cMiiF+FY4SzJVnmQxzy8DGA3Xqmo/K FoNTyy6g+LerFPWmJTEodn5xHZ8PDfP3Nxp6SU9qGFZsrQGngPctAqyllLE4EfVcag0/ vS5vhKyFg2ltGMl+3gS3eH/JpoHMZBZEEmef4lWKEomJKk8lC2r6cSNaRq8bkmpl5i+o lHxkNU4g8M4tPTB9U5bov8jFsbCJ2nTYJxwhdByesptakePef/Y+6QWUqLGI2OIBa1GU wwogWQFPyCDsa8wDI/yjDUflTE/g6WLBNbiH4O04aivQvxsWOobXf5KsZDnbze6W04Me ecXA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=DrKjln2jbc6BqI7vY+7KpOE21FpiyKa3pr0LjZh7EEk=; fh=vfui12khHDzuedjy8+7gjiHbqzajm2/ZVgetjUzZ0hA=; b=OnC42JGDFckHES5mRLtOTXL9uPadR2S8vAyx90iGmmPsH3pJojbJ19w1eXtqsmcrjo Mp3Nl1YfpZ0i/JKtEJVEzOT9U53KKzy+2ObrZyWGQ5Zfn1wwNd6Kg31lQZs7VwHuDaC0 4zgrTwXVv91SuptBcHganuk8aQhCgfQRjFwCRJjvQnKCQ3bXxGzmvLxWCEOQXDYaA7XK Hew/GOjkGNd0N1OeejAOV7yW9zCNYMLKxjpkhV/dbB5mMxQqJoj0ORTEwtnsESrFIlo2 INt8V777Ixbf6BS4lhBAJRLfNJasU/zPdoCBODeVFkltT+DCbKmVd9cSi9Cj90K+UXLv 0HZg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a4CRcb0V; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3923-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3923-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id cd13-20020a170906b34d00b00a52194f72d6si8016862ejb.777.2024.04.23.21.06.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 21:06:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3923-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a4CRcb0V; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3923-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3923-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 377F81F24297 for ; Wed, 24 Apr 2024 04:06:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6455D142916; Wed, 24 Apr 2024 04:05:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a4CRcb0V" X-Original-To: linux-bluetooth@vger.kernel.org Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C19661422D4 for ; Wed, 24 Apr 2024 04:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713931550; cv=none; b=nUnws8nBTmZ16KquiSKxajJV4fyqj3aMHgZQA8+WtQh3ozgERa/U5XVirVCxUDlZu+MAEnF6DP+a/l0e0X/IJXavjEYIKb+cNfM9Vq6R49wTbiuJe5kYsI8yC0yZ0MuE220jtaBFHhiJ/8gvUPS53+Es+YsmzATyoc77MhMFNzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713931550; c=relaxed/simple; bh=v7Tg9TunZnHUXmL3YQhlby+rVAt53e9xRDDXgPmVY/M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WQhi21lXL8AuyJjt6i7YLK8AwqhgrT12if9dZ2YjM5yaUybeaVwjbslMjQpV14MphocfOPg+2CDV6NJw5/l0M6S/ZRsxSuAKvaLm4aUjFbz2d2mK9TflmjA2EtSFz0OlJRMgtzP4Dh7T8rb2HGdknO8HGa12PD1j39fwdk7vxSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=a4CRcb0V; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-51967f75763so7586904e87.2 for ; Tue, 23 Apr 2024 21:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713931546; x=1714536346; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=DrKjln2jbc6BqI7vY+7KpOE21FpiyKa3pr0LjZh7EEk=; b=a4CRcb0V4y1WQAR4HXiVA78lsLmn2kN+1dPASRbYYYlhF6AoZ/Fbh12AMElBlYvzPF SMKkfS0gGNCSD6vJUkSI9jlBaw1D2FTLmgHQdJABdcadjPuxEuRyJMzJUvk3BQhmFmpn OdumJFzT6Vxx5bq1MFkyKmqqF4ESmsBW66yQR+aNKfrgZtl/ixAx4gxq9DSnXLzXwVGN cc2v5/bPxzhWxB+F4S8Za8y6d2X45fgFHXjPzFGuRTWxat1UD6cQ8rUN8nT5JSxwGcOb 1tW6prTsRaQVbQw9i4Fngpky62u6uC9MX8LkJ6A5kCMEm+TCyOstq22zJP/uSWYVfsWt 6eRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713931546; x=1714536346; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DrKjln2jbc6BqI7vY+7KpOE21FpiyKa3pr0LjZh7EEk=; b=flaeoZSizobkdqCFNCr+rh5YfUWYYPGsXOzV3mkiRSZvBUKMjXimq22oTvODOaf/j8 uHe6Y79Ny7vOf6KuBR/rixBCQ9/UiiVhDX0hBbq+DwIYct16vxJdTyjStgq0bJKoyaf9 mIhrletDxisN2QQ0BggoZEcQ+U28aRZJZfKU6TI97HL2XHhuG/0kMeAU/GXJdLaj2QsQ cKq8oXA5HeupNvgInC+gGHnYc3ESvuO3xznOFMyQJouB/VxhdYbRmbdTqkjLerAC6cEa 916CRio/0O2RgCfJgWdms/JInCzCtZ07X+piUKCsJ+x+LkqAERD0n0HDpCxwjtwp7o52 OBDA== X-Gm-Message-State: AOJu0Yx/25TreGbELuTag3bSlW72vIWD28RPAsTyy+VvyQ5Zqzj7fjLP mLiuJSQsQRQukrfF6f3hX+IuSyWsYoIX0Le37xN733YjcU765DfOSkudL2WJrHs= X-Received: by 2002:a19:434e:0:b0:51a:f573:1fce with SMTP id m14-20020a19434e000000b0051af5731fcemr813566lfj.61.1713931545908; Tue, 23 Apr 2024 21:05:45 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id 15-20020a0564021f4f00b00571d74c6074sm5760666edz.46.2024.04.23.21.05.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 21:05:45 -0700 (PDT) Message-ID: Date: Wed, 24 Apr 2024 06:05:43 +0200 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional() To: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Wren Turkal , Zijun Hu References: <20240422130036.31856-1-brgl@bgdev.pl> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240422130036.31856-1-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/04/2024 15:00, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Any return value from gpiod_get_optional() other than a pointer to a > GPIO descriptor or a NULL-pointer is an error and the driver should > abort probing. That being said: commit 56d074d26c58 ("Bluetooth: hci_qca: > don't use IS_ERR_OR_NULL() with gpiod_get_optional()") no longer sets > power_ctrl_enabled on NULL-pointer returned by > devm_gpiod_get_optional(). Restore this behavior but bail-out on errors. > > Reported-by: Wren Turkal > Reported-by: Zijun Hu > Closes: https://lore.kernel.org/linux-bluetooth/1713449192-25926-2-git-send-email-quic_zijuhu@quicinc.com/ > Fixes: 56d074d26c58 ("Bluetooth: hci_qca: don't use IS_ERR_OR_NULL() with gpiod_get_optional()") > Signed-off-by: Bartosz Golaszewski Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof