Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp251230lqd; Wed, 24 Apr 2024 00:38:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUIgQde1ysO7DSWaRXY3emxcwACMH++BMOnL1jcId/Brfq19a8AqONXAsNIkDNHuaNQdoqhns47PNEFiLU5Yc7qFDXvHgk6HzgF9h6vKA== X-Google-Smtp-Source: AGHT+IEDjYeuSyOm9kY4+5fEJFPQ09LI4xlpyHV+BIBUx5rWRLTx16y/+2wiV7O5YNCtODWcfPx2 X-Received: by 2002:a05:6358:795:b0:183:645b:cfa4 with SMTP id n21-20020a056358079500b00183645bcfa4mr1863114rwj.16.1713944306218; Wed, 24 Apr 2024 00:38:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713944306; cv=pass; d=google.com; s=arc-20160816; b=RhZb5UmX5X4g064r1NzbVoUpSS8DvH7z11R8c7LODty+BuLDzisBint0hrBYmCQbRb dEYtWd7uVgQb1EaC0RyosMDGjNtmFnnUlS1ttcnb/Ui8uh0Bbw4QdbMbGSwAouYRvHST AMKKmXBgJn7D60d0sww+dYbETV1LEY8+AptI4es824HzYxcH43MUZSSt8ZDE/bfOkZnh DAhao1n0LYCcRCLmXY7Pog3yOISvKFFdd9dZLN8Tt4TmmfDE6l15VeNd25nDkCmA5UGR gL1jaXhswEK9rDXpQhfOcAiYmX9SBMGWNSmZG1lT77hdI7+PyDtd7IB15xmM6VygWH/N WMug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=LdlJebGacmLHw7EfczJyFSAkGNP6szRGsnHxr7Maih8=; fh=KRoUNGg5ODr+eCXRNPjn+Y2VFGRHkSLZLknwM40JEAA=; b=Wq3BEFNpLHdMh8Lq67Hma2TdrX7deMzt3K2zH7jQjp5C2ke112vEifaWvsjhCC3ZyY pHSda5t+dJgDDdOj+i9Te/KulPkvmzD929tJNT/6XH6HSQ6zZprw5eJBKt07BpkZWA8b dzVNj343x707l+M+IOyiyLUn/uu7p/ZqaIwQSw1dw96rqfRlMNYrQCXsLNj0ZtiAcg5M A+dMriPgc0qLbNizN3ND3r1795B0hUGcTyfp4Y3DIdgb55LeE12Pe8f4kkOh3mWIN0PC A27xmphmuj9iz0KxCn+NwTVdIcyaCZQEupFzS1qZlBu9rY3jiGrOs2DJ1oGwHB4VPzM3 EwoA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GSU9hTUL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3947-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3947-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id ea8-20020a05622a5b0800b00436969a8c4csi13288473qtb.572.2024.04.24.00.38.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 00:38:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3947-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GSU9hTUL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3947-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3947-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E93361C233F8 for ; Wed, 24 Apr 2024 07:38:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 075D323CB; Wed, 24 Apr 2024 07:38:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GSU9hTUL" X-Original-To: linux-bluetooth@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B5DB26AC6 for ; Wed, 24 Apr 2024 07:38:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713944299; cv=none; b=Ro+uiXk0+yDz26NPsixQwagQ3VZB50BjPkl14BY38/Pjyb7lcNfswqSeYqZY9T9XSmjeCjqFP4fSryXSsXIe2HV0L3FmjpKJxrcryeeZK0ch+BRaNHaZopP4js+FhxFZnnNu+t2HtlpCXEGV7D7FvRpKJk2CHyMwCYjvYS0h0/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713944299; c=relaxed/simple; bh=RBeYQkS82TZ1RDRvckRxJGpf8zWFjnW2isrwzirnEY4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ds6oMRyhUOjU/LFOVcdb/CVd318Y8g+Z7ONm79lcuBvuLY3diaSU+33NorSAfNQwgLz52WfyznmfVxueD/6h6cc8fo/LEWD5V0AAbGiknw6RHbf5fvKBqElrsJeJjNYeuRsi+qyqNUjLHEtwY+Sda7An/kjr9OCpgiqhh9SDS2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GSU9hTUL; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E73BC113CE; Wed, 24 Apr 2024 07:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713944299; bh=RBeYQkS82TZ1RDRvckRxJGpf8zWFjnW2isrwzirnEY4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GSU9hTULYuYJix014N12T7I44jvwa4n6ftzoTeF6ThQoT5Ojac1jBIYyr7sD6qRzT 17aqDDpP9Xd4qia2WhPYslU1HaoCydSJ8P/ne4KaOQ9XndQtqQjuygJK6M/w7MtN+x nI68iTcB0qTcXtL/NOc8/2RuFblnYIO5uh2PMD5ih/cDxjEmxMchqUzsXdPZDxqsDu 6GzShXr/kVfX8214yaUxJA+WSJREJ+mrnejvGsCsSU3+egGmw70WrwbPu6fykGMEOf dBQe15aetmD+Xvbn9w6kbJ11RVhxRprCE7LqTo66n9L5S6JqiixgeeDkNTKkrRtH24 N5dVPckqxbkoA== Message-ID: <11cf74a5-317c-4276-8a59-ff11ddf5825f@kernel.org> Date: Wed, 24 Apr 2024 09:38:14 +0200 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Bluetooth: qca: Support downloading board id specific NVM for WCN7850 To: quic_zijuhu , luiz.dentz@gmail.com, luiz.von.dentz@intel.com, marcel@holtmann.org Cc: linux-bluetooth@vger.kernel.org References: <1713340174-1304-1-git-send-email-quic_zijuhu@quicinc.com> <362984a6-7567-4d06-920f-18a6fc8a4908@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <362984a6-7567-4d06-920f-18a6fc8a4908@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/04/2024 09:04, quic_zijuhu wrote: >> /* Download NVM configuration */ >> @@ -751,8 +764,7 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, >> "qca/hpnv%02x.bin", rom_ver); >> break; >> case QCA_WCN7850: >> - snprintf(config.fwname, sizeof(config.fwname), >> - "qca/hmtnv%02x.bin", rom_ver); >> + qca_get_nvm_name_generic(&config, "hmt", rom_ver, boardid); >> break; >> >> default: > > Hi luiz, marcel, > could you code review for this change since a new product needs this > change ? What does your internal guide (go/upstream) tell you about pinging after two days? Best regards, Krzysztof