Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp275891lqd; Wed, 24 Apr 2024 01:45:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVRYo8m2Janmiwc3rmoBTR8iDoERcYh0NaID5/A6dCkAYEyRxppMw7S53ZGSGWyF6+DDAg/SRErGxj/7XrZfDRRHUTILHOl+lhbLtw+gQ== X-Google-Smtp-Source: AGHT+IEEKx+65wqls08FXUq26MuW06k9bUKvFD5kHQUJQcmT+uUinr35sr0HL7kuXy09o/9oi6n9 X-Received: by 2002:a50:8a9e:0:b0:56d:f54a:8765 with SMTP id j30-20020a508a9e000000b0056df54a8765mr1292677edj.23.1713948306839; Wed, 24 Apr 2024 01:45:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713948306; cv=pass; d=google.com; s=arc-20160816; b=B7+e4LNxVAphJ5+5EXwbdIb6S6hbgfIQMc/pbbn9imnwZgoxH6/Ha3bUXiLJ/IfpuO Gbiw2aqUofsLOIqji2JEeM4bu4UXHmtbY5enWmUoIZvQTwahasug4hiOy2Eej/MizBuP bImMxbePex05UetJ9wLlvVLkrYa4CEYZhMoGuphNuk7r3W0JOfX1GBMLVK1xMWEsRiWP htkJc41yEEs8N71ftruW3t1t0FSISb2HLeRFJrXwje0t5F4vXWcSsDG/9PYiguIBDG1g ZOuYRsHxoG51v3qec96Gx5vbI9lzfhWyR/RfMILsZeprUvbe5WkBfAwW/lKJRn9dlAmN 0nNQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=QG2I53mkb4b/UBuPn4KibIIm21UUNETQCluIgHmzLU0=; fh=oeuSg7CMVBYfUYK/ll7aFCTf0K6i5hoehtZRMl+rqdc=; b=X5gTSTJopEkGLzTpMZnRY+b+BFt+XnkMkPQFuBa8x+IkrKt/PPN3epoRo9Cbqd9Ucp 4UsrSyy/e10VWQ0paR8hwazjMhw6Ib0DctWW29SP3YQzE/67Q8EdnAXpaq/JluSTirlB xLCsMKYu842vQD9uZQ8eSNm1YefqeXsOwKc8PHURhx7c2mMkMd0Kog7w5iwz4FGTI1t0 KqACFna7Nm+g1OvWAcUCGwBHMmBiPatdw2P1mbZNHcQacw7/24wpsWffT8MbAk1xF4SH f/Td9G0Ffm9L3Llz6w74hiNIVxa8CEdjR7F6y9vM1Qc5HRyywY2PkWEJwVLOsRavYMaZ eVfw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="rLtwV/8j"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3949-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3949-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id v23-20020a509557000000b00571daa9e96csi6474132eda.595.2024.04.24.01.45.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 01:45:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3949-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="rLtwV/8j"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-bluetooth+bounces-3949-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3949-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6989A1F22C94 for ; Wed, 24 Apr 2024 08:45:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1577415887D; Wed, 24 Apr 2024 08:44:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rLtwV/8j" X-Original-To: linux-bluetooth@vger.kernel.org Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0994158872 for ; Wed, 24 Apr 2024 08:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713948298; cv=none; b=mBRQAHx+Bd+9b2cv5mP8p5kQ9X2yu/OQ3wlNzLFpO+L1EXt7mFShxsKeiNFgkQ1AhLVz1mzKUKyDZN5gU9GsznG7p9IdiM9Z/MGVI6ut4kl2StVHekEQCri3FjJwlZGH52CuTtzeqh+kvug1hT9sJGpqKiX+yLPvVWhWf+Hmc9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713948298; c=relaxed/simple; bh=zuV+FOgiw/GSukQ54T219p6AuZEuzCpu7DGhUqvy53c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g6lcYgyFsCXAavrjhFaUhyJsQ2lDeCPeM0wSjlML5VDqLM7UeV1f7EDu0mF8MVTi/rD5zfgMvmc8tj9hjaFMwPLM4zBRLrmFBbu58cwAja6KDeV2HqlevtRf7xeYDGcva4e0k6RROdoJs9G7Xh/POuDHxmq1DOj6eF6MNLGBf3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rLtwV/8j; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-56e1f3462caso8336997a12.3 for ; Wed, 24 Apr 2024 01:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713948295; x=1714553095; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=QG2I53mkb4b/UBuPn4KibIIm21UUNETQCluIgHmzLU0=; b=rLtwV/8jTEzPblQdNuuCv8d4i17EcI51tDAHkeawIdG8mLFjHsX5xf42amsOeXxUG/ kaKygWPN7ddfT/ulmvRUe3vPFlsXerWWMlpOk/Of87fvUcgabr/M3c1Gk1/KcKtg9q7c jHm9YQtN1kNxHTNHfqD/ynWkPmZ6nu1lhzSm8yCWQlSVHCXNIE4Pl2bWbAr2zrW8xcuI zfvAVzGdAHOg0LX99a5k/DMG1vRwneuuct/xpcNGf50C2nWkrvV97Jn4FB8UcYkwM40g YrfR4hQ90qWvYY7h+sDLnU7g2AaksnQpDnwPGBywTY0QaFPBFjKJiJdoUiS1opVYmTz3 3PLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713948295; x=1714553095; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QG2I53mkb4b/UBuPn4KibIIm21UUNETQCluIgHmzLU0=; b=JmCfRkKRZCoziZ31W2VON59nAzXrmoiITtqW3qhzGgWK6wN/2kx+KwHSsSWug0ARM3 k40I4+EZMHJ/hk/Ls1XOVJ8v71/mNcGKuVfGAPcuuX/lIDsZwNfiXctR9XFIyRUVFeU4 sKoMw8hTjd6CfaYgAqVX05T/6mszuXi5M3uGXX3RXrxFnj6bBopAMd2Mu1XhiZkHMj9Y JdZxWCV+bRX0ixvpJh7ai5Wrqb8/Fkgb8+rlZhKOWlgfnEHL0CEq0DgnwLDFTC30wK7h BLtkesbv30OsuPxaEIqVp3DG2xRmqYyYODMYpvAaqxEBzewlyiWV6hwp23NImxmCDwV4 ErEQ== X-Gm-Message-State: AOJu0YzADXbRZVjsZPnk8PnspbIVjhU7xhmFSJ6ufnGgtHpXkXciTXHz kBXaOpJrJC8pola5Sc4ZTeDJMMzQeZv8IFzskq9IHWtmZ09DlJ08FJNRePEqGa+BdcSJcGaJwJk GANM= X-Received: by 2002:a17:906:6987:b0:a55:61cc:7337 with SMTP id i7-20020a170906698700b00a5561cc7337mr952806ejr.43.1713948295248; Wed, 24 Apr 2024 01:44:55 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id f15-20020a170906c08f00b00a553574ae71sm8045395ejz.7.2024.04.24.01.44.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 01:44:54 -0700 (PDT) Message-ID: Date: Wed, 24 Apr 2024 10:44:53 +0200 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] Bluetooth: qca: Correct property enable-gpios handling logic for WCN6750 and WCN6855 To: Zijun Hu , luiz.dentz@gmail.com, luiz.von.dentz@intel.com, marcel@holtmann.org Cc: linux-bluetooth@vger.kernel.org, bartosz.golaszewski@linaro.org, wt@penguintechs.org, kernel@quicinc.com References: <1713947712-4307-1-git-send-email-quic_zijuhu@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <1713947712-4307-1-git-send-email-quic_zijuhu@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/04/2024 10:35, Zijun Hu wrote: > Commit 56d074d26c58 ("Bluetooth: hci_qca: don't use IS_ERR_OR_NULL() > with gpiod_get_optional()") has wrong logic for below case: > > property enable-gpios is not configured for WCN6750 and WCN6855 As I said before, bindings say this property is required. I already asked you to provide rationale describing hardware and update the bindings if they bindings are not correct. Best regards, Krzysztof