Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp378737lqd; Wed, 24 Apr 2024 05:27:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUkiV61pqnS1cW6InTcr2R9ADYfqHFmZAtdkdHYDpeg+TWp47giibp8QzKgf3lj18qvE7h42DupyaLRtixJaiXrzSpgPIpNsxArHO83UA== X-Google-Smtp-Source: AGHT+IH1MmHP341o4x+dpNuGHoGSBVWEqPnQtWxOR4R+0cHnIZ2YIVmVshUbxjB9jcrno1M+bZbv X-Received: by 2002:a17:906:f9da:b0:a52:4118:9273 with SMTP id lj26-20020a170906f9da00b00a5241189273mr1374092ejb.43.1713961675179; Wed, 24 Apr 2024 05:27:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713961675; cv=pass; d=google.com; s=arc-20160816; b=FKlPqJWAiPxUJct4IJFkude1fVkvnH2CqYDFEKsKnWotPw1sV/4J4jYw7h7J0KOLaM v6xrr1AqU971RZILwSK830g9DYwKM1ux8V++95mh2jL4rT8H8Hjb7GemdnAw8/TlURxW T+ayV1tGwfjj/dEs5NFBUWFL5ZkOaSQlbXhw7tsafkjxU1Yi6/OqBTLyLMx10+SHBKn3 3kt7DaWqElabLueKiw6uTEaRxT+bH9xspxnd2eALnlkCa1qo6dTtKGiDMwb5sBB1guPI fLXMKokalJFNan7ll757IV8SYU5MQRZBoX8U+lh7HquvzKf4RdDbyZ+zdXedrcku3d4S GM7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=4l5jZLb/34NM5dMz9g2a72zUgmN/UcICDE4JDkqzAyI=; fh=BMYOgmlYOl08gZajNIt1ENs4iuKhrR4dgzaayeda+5Y=; b=NlpKEEQY1E0yTj5kUfV27t8K45/Kir8Xv3/rDlHdRKUapmdsUdu5Ee6q7YEft7+rnW lBOahLupIawJL1KtA1LWpWnisQ6Kmyfo0OnBdM/F5DG6WSTjBbRAFS9SyyHR1gem3Rko daZcf3QMDLGjrlk5e1lnuXfTABviNMzg1MkhN4J3YMUDAmPlqXFudpipD0o8yzTOMVJ2 LoeJHwV5NT1MGADlqpbwk8kn0W1bPYMjvTp/M9bOpKFVAZkHTHM3HUFkYYCMHwTRwKpt jpPxID+MRqocrreqva6GJ9L/qu5rNaXPCWborxNazsSai+y7ZoKdDjYOOa6+TQ2gvNG6 zboQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=187GRk5Z; arc=pass (i=1 dkim=pass dkdomain=bgdev-pl.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-bluetooth+bounces-3974-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3974-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id bi10-20020a170906a24a00b00a5213f8fc14si8121722ejb.69.2024.04.24.05.27.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 05:27:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-3974-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=187GRk5Z; arc=pass (i=1 dkim=pass dkdomain=bgdev-pl.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-bluetooth+bounces-3974-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-3974-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E4D941F227C2 for ; Wed, 24 Apr 2024 12:27:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9340E15B0F1; Wed, 24 Apr 2024 12:27:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="187GRk5Z" X-Original-To: linux-bluetooth@vger.kernel.org Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9263A15A4AA for ; Wed, 24 Apr 2024 12:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713961668; cv=none; b=Vc/UPr1MlEl9ialzy5TDxZZaewa8ld1qZT43YO8fgxtOeG7GsQOuVb/BI0GNaK08KMNZbflyOWL3s/G/TM39h9F4PdnG4grdThuLqGpnjawAvV+MW0BsX7P151vZjwnCNi5wOt4C+gSx0x/r6snt0GXpGY1kTh7pozXlKMBIfNQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713961668; c=relaxed/simple; bh=4l5jZLb/34NM5dMz9g2a72zUgmN/UcICDE4JDkqzAyI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ddXin6jNlS3BsKkNldVrqAWmCo3SA/z+NmZ7RCb+jyrf9R9Sw8jsrCzX3dgWTIa+E43ebsqXlNRSJcTybV6rsfgecNxmfbVFw/8wimvWrJEGT+UhRmM2dl7i4Z84ALFmBr4+mix/4bhv9sdWw6quIjOtMAbGuZsUz2KtgeAnZfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=187GRk5Z; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-51967f75729so8013578e87.0 for ; Wed, 24 Apr 2024 05:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1713961665; x=1714566465; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4l5jZLb/34NM5dMz9g2a72zUgmN/UcICDE4JDkqzAyI=; b=187GRk5Z/0YU/NZSmDCUzyWaIqkXszx4MK+5rLBQNmRWun/zLuedYCrQCcOp1Epl62 t/OTNmtPNlNBh1TAwIhD9CH2hqixQ0OX34hHZOsWa3kB0jYMW1KjLgyVgH8qzVunTmX5 HTaYCo9q/k78yAxmzud9gRxQBYmMi6mkF6i51jJVmL4CtpyKXqszkeCMnrcFDsW4WcQ+ luOJwDjo5r8TtCR1FlYhLrhr6B7qIwl5IYcGXkJi/FKWuXfSV7QUvOycmKdXcbI5y7+m WeInu9QVbSnQxuJleOO1+GUOSvpEZhwecWiyvhNfakPkKh4Hd8HxbYxltHpDwLmUdFW5 /7iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713961665; x=1714566465; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4l5jZLb/34NM5dMz9g2a72zUgmN/UcICDE4JDkqzAyI=; b=YTduPON6TaTfdWrFTMpTmRe6R3airslzz/sDmvalqb1ehXnszQYAxOttfj2dxVtw5o 70pGN0yt3n+KxZWO0KYlOAhS8KR0cYXt6lhQaabkQ+vLqYn8TmfSxt3SDl+YGWC4ZgRg YYe7EYUENeWq7BSD9NSR2D8VFS4oEeA1hE9Kbbx/zbheiaDS2VZmpqM+nLYca41FRmIX +1dgh+Ah/VQFOrOe6I1HRuNeQdrs4S6Wd/EFsaLW3E5Yv3cc7+pNN3k8Bp+kjAir4wvJ wdlLjIPyZE/hA0zCI5gwQQ1dbfPxtritf89XQL/1eQlC9bpuCLHwAZb0JFX5Nkk57DRn qInw== X-Forwarded-Encrypted: i=1; AJvYcCXEVo/KguqaYxnDUwdqP8xtytoQLr+WKuriB/cw2e3LN1pxeKtTGb89q5wBc2nMrqh6qKKhl0P/s3Coz3GZJ2TQ5+ztvmfxXFV2QHuC86os X-Gm-Message-State: AOJu0YxSOQ1lEZABV7pQiV24G7fhQrWdQ9rOT58JHFoOuXmfwbDJPXov cu5DobQwkoFeydfVP3oxtUGdYD5aFSgFh7sxd4kWJG9q8/w+5VNike3CcCLfp9+tLdhYzeKTXhb vQZaFLB+ArVBTEwkX3OB7/osldlS5bCIr7UD7BQ== X-Received: by 2002:a05:6512:748:b0:51a:f255:ade3 with SMTP id c8-20020a056512074800b0051af255ade3mr1477665lfs.20.1713961664672; Wed, 24 Apr 2024 05:27:44 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240422130036.31856-1-brgl@bgdev.pl> <99242a7c-53bf-4227-9623-7bc092f564b3@penguintechs.org> <0381f39c-38ba-4a2b-915c-f14c5f911eb9@penguintechs.org> <2371f538-ec53-4037-b171-c62bf4e06eb1@penguintechs.org> <4c33304a-5dbc-450a-b874-e04ba9e93150@penguintechs.org> In-Reply-To: <4c33304a-5dbc-450a-b874-e04ba9e93150@penguintechs.org> From: Bartosz Golaszewski Date: Wed, 24 Apr 2024 14:27:33 +0200 Message-ID: Subject: Re: [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional() To: Wren Turkal Cc: Bartosz Golaszewski , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu , Marcel Holtmann , Luiz Augusto von Dentz , Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 24, 2024 at 2:24=E2=80=AFPM Wren Turkal w= rote: > >>> > >>> That's OK, we have the first part right. Let's now see if we can reus= e > >>> patch 2/2 from Zijun. > >> > >> I'm compiling it right now. Be back soon. > >> > > > > Well I doubt it's correct as it removed Krzysztof's fix which looks > > right. If I were to guess I'd say we need some mix of both. > > Patch 2/2 remove K's fix? I thought only 1/2 did that. > > To be specific, I have applied your patch and Zijun's 2/2 only. > No, patch 1/2 from Zijun reverted my changes. Patch 2/2 removes Krzysztof's changes and replaces them with a different if else. This patch is a better alternative to Zijun's patch 1/2. For 2/2, I'll let Krzysztof handle it. Bart