Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4036-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240424122932.79120-1-brgl@bgdev.pl> <0f8ba1b5-490e-4961-80e2-7942f66730ec@linaro.org>
 <CACMJSeuBCkNyaD60qGVpAq91DqD_OA=tCVEY0t+JNK2vcWBc+Q@mail.gmail.com>
 <d82c2e39-d2b8-4de0-a11a-6ab2420f8f95@quicinc.com> <f4bffd0e-0d9b-4fb9-926e-c75a20c92b50@quicinc.com>
 <CAMRc=MfqKsRqKck5Wb052zuUURxqRykjbu+c3K9oFPMHaHuiJA@mail.gmail.com> <f1d41e3a-e864-43a3-bb59-f59a8667b595@quicinc.com>
In-Reply-To: <f1d41e3a-e864-43a3-bb59-f59a8667b595@quicinc.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Wed, 24 Apr 2024 11:41:42 -0400
Message-ID: <CABBYNZ+5R8gJVWXjO_VMsZ9MN9e6YV-Cnp3oYEnnbRJz1D=W=g@mail.gmail.com>
Subject: Re: [PATCH v2] Bluetooth: qca: set power_ctrl_enabled on NULL
 returned by gpiod_get_optional()
To: quic_zijuhu <quic_zijuhu@quicinc.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>, Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Marcel Holtmann <marcel@holtmann.org>, 
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Wren Turkal <wt@penguintechs.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Quic_zijuhu,

On Wed, Apr 24, 2024 at 11:35=E2=80=AFAM quic_zijuhu <quic_zijuhu@quicinc.c=
om> wrote:
>
> On 4/24/2024 11:31 PM, Bartosz Golaszewski wrote:
> > On Wed, Apr 24, 2024 at 5:30=E2=80=AFPM quic_zijuhu <quic_zijuhu@quicin=
c.com> wrote:
> >>
> >> On 4/24/2024 11:24 PM, quic_zijuhu wrote:
> >>> On 4/24/2024 10:52 PM, Bartosz Golaszewski wrote:
> >>>> On Wed, 24 Apr 2024 at 16:46, Krzysztof Kozlowski
> >>>> <krzysztof.kozlowski@linaro.org> wrote:
> >>>>>
> >>>>> On 24/04/2024 14:29, Bartosz Golaszewski wrote:
> >>>>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >>>>>>
> >>>>>
> >>>>>>               qcadev->susclk =3D devm_clk_get_optional(&serdev->de=
v, NULL);
> >>>>>>               if (IS_ERR(qcadev->susclk)) {
> >>>>>> @@ -2355,10 +2360,13 @@ static int qca_serdev_probe(struct serdev_=
device *serdev)
> >>>>>>               qcadev->bt_en =3D devm_gpiod_get_optional(&serdev->d=
ev, "enable",
> >>>>>>                                              GPIOD_OUT_LOW);
> >>>>>>               if (IS_ERR(qcadev->bt_en)) {
> >>>>>> -                     dev_warn(&serdev->dev, "failed to acquire en=
able gpio\n");
> >>>>>> -                     power_ctrl_enabled =3D false;
> >>>>>> +                     dev_err(&serdev->dev, "failed to acquire ena=
ble gpio\n");
> >>>>>> +                     return PTR_ERR(qcadev->bt_en);
> >>> please think about for QCA2066. if it is returned from here.  BT will
> >>> not working at all.  if you don't return here. i will be working fine
> >>> for every BT functionality.
> >> sorry, correct a type error, it is QCA6390 not QCA2066.
> >
> > Doesn't matter. If enable-gpios is not there, gpiod_get_optional()
> > will return NULL and we will not return.
> >
> i think i need to explain more for my consider case.
> let me take QCA6390,  if the property enable-gpios is configured.
> but IS_ERR(qcadev->bt_en) case happens, your change will do error
> return, so BT will not work at all
>
> but if you don't do error return, BT will working fine.
>
> so your fix is not right regarding QCA6390.

Actually I'd say he is probably right with respect to DT because that
seems to require GPIO, we probably need a clearer way to differentiate
if a device is being set up via DT or not (btattach), in any case DT
is probably preferable thus why I went ahead and applied this one.

> > Bart
> >
> >>> NAK again by me.
> >>>
> >>>>>>               }
> >>>>>>
> >>>>>> +             if (!qcadev->bt_en)
> >>>>>> +                     power_ctrl_enabled =3D false;
> >>>>>
> >>>>> This looks duplicated - you already have such check earlier.
> >>>>>
> >>>>
> >>>> It's under a different switch case!
> >>>>
> >>>> Bartosz
> >>>
> >>>
> >>
>


--=20
Luiz Augusto von Dentz