Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4065-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "K, Kiran" <kiran.k@intel.com>
To: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
CC: "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>, "Tumkur Narayan,
 Chethan" <chethan.tumkur.narayan@intel.com>
Subject: RE: [PATCH v2 1/2] Bluetooth: btintel: Dump exception event
Thread-Topic: [PATCH v2 1/2] Bluetooth: btintel: Dump exception event
Thread-Index: AQHahC3og6997VpueE6hOnBn9WtO1LF46NNw
Date: Thu, 25 Apr 2024 10:09:53 +0000
Message-ID: <PH0PR11MB75854FFF8E6088A0E7BB9B80F5172@PH0PR11MB7585.namprd11.prod.outlook.com>
References: <20240401122559.1097489-1-kiran.k@intel.com>
In-Reply-To: <20240401122559.1097489-1-kiran.k@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8BKYodA6/ZCpPeenpc7VBuLPbAS38bN1W3IoPhYzBfXnsm1TWUJOP+wnZvMZ?=
 =?us-ascii?Q?txkJm5vgyfFYDsVBU74WC3xKfRkWwuqO4cWV9meHRnh+nMQOdWN/j3Q2c/JX?=
 =?us-ascii?Q?MbNxC3qGm4pNp+x6ZeyOsIRYCtxU8V+DToruSXj2RuOYlCAcaRdwkY3DExo/?=
 =?us-ascii?Q?OVmi1htoac6+swnnBforQf4pUW6QptUz169nvJLIqI9lSyDQBTVlk3GYE4Bf?=
 =?us-ascii?Q?QOOBkIj6NOdqgkKSWjC/fhJo3x9U/3kv9kruPhtL7U9bb2Y15XvwVJeRDSw4?=
 =?us-ascii?Q?WqwkaxmUMdJameOyN6dWJNNBgC5VWJ5GXCfPQLW24zTK/6DoAj9ZG9BCtM8K?=
 =?us-ascii?Q?6Nm0mpQk8C/sYhgxyyRWF3dM4+umRD85sOxELPf3MvxgqmlzSKU5G0ujt7xU?=
 =?us-ascii?Q?pov6FmYsxxH1x3q7GGaKO7NcPHjY68wjOOOJF2ymKezV9fcSHxXugYx/2txI?=
 =?us-ascii?Q?PwI5Jql6Ck/hUpl7AGfVqVTsJwLVBt11c+tDMK28EnF6u2fZyuN4wYyzw7QR?=
 =?us-ascii?Q?AJAwzdItPzSZ/tZuXGh7M4Z33YWplbGVcAtdvrVANyB32YjMQHvvgNrincXA?=
 =?us-ascii?Q?kJLY3PW9x1Cp7zodq9XFyJUx0GX+pIIq6etw1X6lueuJ1lCZwZ526FUCjtsP?=
 =?us-ascii?Q?phMi0rZ/Tsjo80pld2ZZx2xkpnhC0gbak9E4xqDzrtDI97IiQKrunIEVmCox?=
 =?us-ascii?Q?41AjtE0E7t11Uu+Kk1Kt+AAXrWCAJaaYmD3MRrylE54bt+5r0Qbe4wBARCQ1?=
 =?us-ascii?Q?L3TLjqK54p7k+rdT1FKarF7ke7Hzz2zTwmdimZQXvUJYIsxHbhcnzhSEV0jD?=
 =?us-ascii?Q?oAeherp+CEunfUP5NAO1jeq0F2F2fmS47MN4H1oMqGUhoVm/aG9TXXSZQYFB?=
 =?us-ascii?Q?++Y9wIS1nuG3QMqaEjBREEXlHOpRS3tANNDNKOCWmMm+q4yaBZaKM+0IcKXW?=
 =?us-ascii?Q?oswd6vo9/YNCHB8Jlz4JiIbJPDQpdC2IfQJbQipHkx4i1/oSOZxzp6A0yBtK?=
 =?us-ascii?Q?Kv9Kw1i+d/xnPn0+gUSe6e/BCdUWlbsedYVLKVFrJZ+BYB3Y9zku8iZkpYmr?=
 =?us-ascii?Q?bd9imIJ1lEnTLvJb/opCpfFCZQfItSSN7VOotLUl5HcH6tXyKGmj69NI4opm?=
 =?us-ascii?Q?8/qDwbtwQ3W2GAAORWOeLKT1rfHTl+TKTpXJsN3HemA+tOEoGCZf4JI0w0q4?=
 =?us-ascii?Q?VDW7sD/N51c7l3ISjUS6f9Y/cpVR/cn0elKUq/D1blI6WLFsNnNqFUlFKNAT?=
 =?us-ascii?Q?EG3EfQp7db3dfSC1oHtANpNhOkl/tOsatLHT3H/53CAuCRk7DLuTwa7t3CdP?=
 =?us-ascii?Q?tp6XNlmjuO0fzRFmnkmXq9THkPyMGvWgSNP9TdhTtq/erkJaDW9tbxuDvvpm?=
 =?us-ascii?Q?OWfpiNVdqEfrVcsKD91xgO6It+O0kFhW91OWzJrTmghngKbx0fdlzhJGioGX?=
 =?us-ascii?Q?VT4y1YwtWV684zL25+6+Mu+eHyAyI0DITwipKvLe60kl76ZcgRWb8xRMCY8c?=
 =?us-ascii?Q?F6JiQqIBfu45Dyg2k7iBV3YjDN1sjlJ1MLPdZzucSfDT3lEytqr5G25OaJLC?=
 =?us-ascii?Q?tKGfPh4WPDPiSPXiCKE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-bluetooth@vger.kernel.org
List-Id: <linux-bluetooth.vger.kernel.org>
List-Subscribe: <mailto:linux-bluetooth+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-bluetooth+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7585.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5ae61e0-1f7b-4b01-dad3-08dc650fda24
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2024 10:09:53.8478
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gjUmKrDnnVn8TLcrNidNsVztQAT+OFuTr+5zCEutV7wyqYy3im5U0qXd9c6hNh5B+/pp+1mV5+uIPLoUdECg2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7000
X-OriginatorOrg: intel.com

Hi Luiz,

Friendly reminder.

> -----Original Message-----
> From: K, Kiran <kiran.k@intel.com>
> Sent: Monday, April 1, 2024 5:56 PM
> To: linux-bluetooth@vger.kernel.org
> Cc: Srivatsa, Ravishankar <ravishankar.srivatsa@intel.com>; Tumkur Naraya=
n,
> Chethan <chethan.tumkur.narayan@intel.com>; K, Kiran <kiran.k@intel.com>
> Subject: [PATCH v2 1/2] Bluetooth: btintel: Dump exception event
>=20
> Having exception event dump in kernel log helps debugging the use cases
> where snoop traces are not available.
>=20
> dmesg:
>=20
> [27.032666] Bluetooth: hci0: Exception occurred - type: 0xde [27.032703]
> Bluetooth: hci0: ff 4f 87 80 03 01 01 de 07 01 de 06 1c ef be ad [27.0327=
29]
> Bluetooth: hci0: de ef be ad de ef be ad de ef be ad de ef be ad [27.0327=
53]
> Bluetooth: hci0: de ef be ad de ef be ad de 05 14 ef be ad de ef [27.0327=
78]
> Bluetooth: hci0: be ad de ef be ad de ef be ad de ef be ad de 43 [27.0328=
03]
> Bluetooth: hci0: 10 ef be ad de ef be ad de ef be ad de ef be ad [27.0328=
27]
> Bluetooth: hci0: de
>=20
> Signed-off-by: Kiran K <kiran.k@intel.com>
> ---
>  drivers/bluetooth/btintel.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c in=
dex
> a19ebe47bd95..c0dbbd1a2032 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -3119,6 +3119,7 @@ EXPORT_SYMBOL_GPL(btintel_configure_setup);
>  static int btintel_diagnostics(struct hci_dev *hdev, struct sk_buff *skb=
)  {
>  	struct intel_tlv *tlv =3D (void *)&skb->data[5];
> +	char prefix[64];
>=20
>  	/* The first event is always an event type TLV */
>  	if (tlv->type !=3D INTEL_TLV_TYPE_ID)
> @@ -3129,6 +3130,12 @@ static int btintel_diagnostics(struct hci_dev *hde=
v,
> struct sk_buff *skb)
>  	case INTEL_TLV_FATAL_EXCEPTION:
>  	case INTEL_TLV_DEBUG_EXCEPTION:
>  	case INTEL_TLV_TEST_EXCEPTION:
> +		bt_dev_err(hdev, "Exception occurred - type: 0x%2.2x",
> +			   tlv->val[0]);
> +		snprintf(prefix, sizeof(prefix), "Bluetooth: %s: ",
> +			 bt_dev_name(hdev));
> +		print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_NONE, 16,
> 1,
> +			       skb->data, skb->len, false);
>  		/* Generate devcoredump from exception */
>  		if (!hci_devcd_init(hdev, skb->len)) {
>  			hci_devcd_append(hdev, skb);
> --
> 2.34.1

Thanks,
Kiran