Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4097-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240426072006.358802-1-iam@sung-woo.kim> <964b0005-3a9d-499b-91d3-171a3c917b4a@web.de>
In-Reply-To: <964b0005-3a9d-499b-91d3-171a3c917b4a@web.de>
From: Sungwoo Kim <iam@sung-woo.kim>
Date: Fri, 26 Apr 2024 04:38:24 -0400
Message-ID: <CAJNyHp+WFONaNbZVK3tPcT=9obEiuE3MvQzJK++HP-ffNdfX0w@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: L2CAP: Fix slab-use-after-free in l2cap_send_cmd
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org, 
	LKML <linux-kernel@vger.kernel.org>, "Dave (Jing) Tian" <daveti@purdue.edu>, 
	Johan Hedberg <johan.hedberg@gmail.com>, Luiz Augusto von Dentz <luiz.dentz@gmail.com>, 
	Marcel Holtmann <marcel@holtmann.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 26, 2024 at 4:26=E2=80=AFAM Markus Elfring <Markus.Elfring@web.=
de> wrote:
>
> I prefer that you would put recipient specifications also into the messag=
e field =E2=80=9CTo=E2=80=9D
> (besides =E2=80=9CCc=E2=80=9D).

Okay.

>
>
> > Hello, could you review a bug and its fix?
>
> I suggest to omit such a question from better change descriptions.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D=
ocumentation/process/submitting-patches.rst?h=3Dv6.9-rc5#n45

Thank you. I'll thoroughly read this.

>
>
> =E2=80=A6
> > To fix this, this patch holds and locks the l2cap channel.
>
> Please choose a corresponding imperative wording.

Okay.

>
>
> You would probably like to improve your patch approach further
> so that provided data will be kept consistent.

I will.

> https://lore.kernel.org/lkml/20240426073142.363876-1-iam@sung-woo.kim/
>
> Regards,
> Markus
>

On Fri, Apr 26, 2024 at 4:26=E2=80=AFAM Markus Elfring <Markus.Elfring@web.=
de> wrote:
>
> I prefer that you would put recipient specifications also into the messag=
e field =E2=80=9CTo=E2=80=9D
> (besides =E2=80=9CCc=E2=80=9D).
>
>
> > Hello, could you review a bug and its fix?
>
> I suggest to omit such a question from better change descriptions.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D=
ocumentation/process/submitting-patches.rst?h=3Dv6.9-rc5#n45
>
>
> =E2=80=A6
> > To fix this, this patch holds and locks the l2cap channel.
>
> Please choose a corresponding imperative wording.
>
>
> You would probably like to improve your patch approach further
> so that provided data will be kept consistent.
> https://lore.kernel.org/lkml/20240426073142.363876-1-iam@sung-woo.kim/
>
> Regards,
> Markus
>