Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4098-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240422152500.1.I8939e49084a6fef78496eb73edafdf3c2c4afbf4@changeid>
 <CABBYNZLCjrJUiVzNf53XYM-ZHWL6TZD4yFNtNGOuYi=6s5Q+OA@mail.gmail.com>
In-Reply-To: <CABBYNZLCjrJUiVzNf53XYM-ZHWL6TZD4yFNtNGOuYi=6s5Q+OA@mail.gmail.com>
From: Archie Pusaka <apusaka@google.com>
Date: Fri, 26 Apr 2024 17:08:40 +0800
Message-ID: <CAJQfnxHUW+MdJUp9VCrF2Nq_-JZrd7mKBR9NdDoo0SOvgH5WUQ@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: btusb: Add debugfs to force toggling remote wakeup
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>, 
	Johan Hedberg <johan.hedberg@gmail.com>, Marcel Holtmann <marcel@holtmann.org>, 
	CrosBT Upstreaming <chromeos-bluetooth-upstreaming@chromium.org>, 
	Archie Pusaka <apusaka@chromium.org>, Abhishek Pandit-Subedi <abhishekpandit@google.com>, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Luiz,

On Thu, 25 Apr 2024 at 03:05, Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Archie,
>
> On Mon, Apr 22, 2024 at 3:25=E2=80=AFAM Archie Pusaka <apusaka@google.com=
> wrote:
> >
> > From: Archie Pusaka <apusaka@chromium.org>
> >
> > Sometimes we want the controller to not wake the host up, e.g. to
> > save the battery. Add some debugfs knobs to force the wake by BT
> > behavior.
> >
> > Signed-off-by: Archie Pusaka <apusaka@chromium.org>
> > Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@google.com>
> >
> > ---
> >
> >  drivers/bluetooth/btusb.c | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 8bede0a335668..846b15fc3c04c 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -873,6 +873,9 @@ struct btusb_data {
> >         unsigned cmd_timeout_cnt;
> >
> >         struct qca_dump_info qca_dump;
> > +
> > +       bool force_enable_remote_wake;
> > +       bool force_disable_remote_wake;
> >  };
> >
> >  static void btusb_reset(struct hci_dev *hdev)
> > @@ -4596,6 +4599,10 @@ static int btusb_probe(struct usb_interface *int=
f,
> >
> >         debugfs_create_file("force_poll_sync", 0644, hdev->debugfs, dat=
a,
> >                             &force_poll_sync_fops);
> > +       debugfs_create_bool("force_enable_remote_wake", 0644, hdev->deb=
ugfs,
> > +                           &data->force_enable_remote_wake);
> > +       debugfs_create_bool("force_disable_remote_wake", 0644, hdev->de=
bugfs,
> > +                           &data->force_disable_remote_wake);
> >
> >         return 0;
> >
> > @@ -4702,6 +4709,18 @@ static int btusb_suspend(struct usb_interface *i=
ntf, pm_message_t message)
> >                 }
> >         }
> >
> > +       if (!PMSG_IS_AUTO(message)) {
> > +               if (data->force_enable_remote_wake) {
> > +                       data->udev->do_remote_wakeup =3D 1;
> > +                       if (test_bit(BTUSB_WAKEUP_AUTOSUSPEND, &data->f=
lags))
> > +                               data->udev->reset_resume =3D 0;
> > +               } else if (data->force_disable_remote_wake) {
> > +                       data->udev->do_remote_wakeup =3D 0;
> > +                       if (test_bit(BTUSB_WAKEUP_AUTOSUSPEND, &data->f=
lags))
> > +                               data->udev->reset_resume =3D 1;
> > +               }
> > +       }
> > +
> >         return 0;
> >  }
> >
> > --
> > 2.44.0.769.g3c40516874-goog
>
> There is a D-Bus interface available to overwrite the wakeup setting:
>
> https://github.com/bluez/bluez/blob/master/doc/org.bluez.Device.rst#boole=
an-wakeallowed-readwrite
>
> Or do you want a master switch for it? On the other hand aren't we
> getting into the rfkill area if you really want to switch off radio
> activity while suspended? That seems like a better idea then just
> disable remote wakeup.

Yes, the initial idea was a master switch.
Thanks for your suggestions.
Let me discuss it with Abhishek.
>
> --
> Luiz Augusto von Dentz

Thanks,
Archie