Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp41882lqa; Fri, 26 Apr 2024 13:42:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWL6ZInOBPWQlPEz5r5H2VDLlHY/BJEW91caAqjiYezi1ueSs7nZpeMr1txMtOL9WPMaN+tWKdPB1Lsh3tq00aqm30pD7+5H4+tb6kmjg== X-Google-Smtp-Source: AGHT+IFv4NJNTTpsjFDSLrXZL3k+6wzqbzFX0d0ZPgSmactwwmkKN0g0ftuBjM569CoA4jZQG09z X-Received: by 2002:a05:6902:228d:b0:de4:5c37:60fa with SMTP id dn13-20020a056902228d00b00de45c3760famr4409581ybb.57.1714164165397; Fri, 26 Apr 2024 13:42:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714164165; cv=pass; d=google.com; s=arc-20160816; b=BtCGKI8rh82g4JIy4Sr3DSxDej4tt/wD2yKJhz1oxAvlLCOHpCv8eeKSFsearIRttm sYYdEEGMFtcIroDogKd5+CPpwGbHcUSfTBH6hrRDs/KqgsHdajmrgxG4kxKbNlz6KcCt WaWLF3VeBftbjNz3VT1iwelOio7uomh9iO9/Da3BXrp/ftlxD4PgnOM5+zWgQnfUIfed 66TJ+Z7ZL0nfDKJUpAv/ThlQyqvhp6s6GmXeATjgzXfdypnWWgfVeYDoClHTXJZPtTVw pwMJMH6b+ruBnyck64u4/kIhqKENHvA5f2A/QrZoFscoC1waMou5Rfv8zaMwlSFYX3VI kEew== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Ut2/7QtHb1M2bAQEQd183O3h2QD+aXNEeV9+hYPipro=; fh=Sw4avOHvaxaNn0CJpxbpb3c2pxg1foGf3bkWS0VwOAE=; b=clEyfH3/M5uBoCc4AHAo2O4j8ZUstGTvWy229suYNtWpx0oxtNq418X33wiXECpoCg Nt/LdewQySLyyyZxRdtQkl2Is8tMrM1gLHm4GrF04czKlKydJ+sbPtf0mU26L4klgcyM U6a07yxjrgZt+NKdfjQuiIbCNEq7pqs1tYD7vE+DDQxBR9OwS4qeVPSQKqEhqL8Nqj3y NCE7WZjFL7NXjniJ2qzskYAO6l0I3dLgqBeEk0RGQUGrs8Eg+i1TaeYaALpDaK+4HHUU TiHS+JrcEmvEcLT7M4tIXLQZmerFeT472U3MdM4hmM/cU99lPjaV31YVVE9kF7hrGPmr j3Ow==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@penguintechs.org header.s=google header.b=bo6+aveC; arc=pass (i=1 spf=pass spfdomain=penguintechs.org dkim=pass dkdomain=penguintechs.org); spf=pass (google.com: domain of linux-bluetooth+bounces-4129-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4129-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id n19-20020a05622a041300b00439ff3af093si9703107qtx.101.2024.04.26.13.42.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 13:42:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4129-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@penguintechs.org header.s=google header.b=bo6+aveC; arc=pass (i=1 spf=pass spfdomain=penguintechs.org dkim=pass dkdomain=penguintechs.org); spf=pass (google.com: domain of linux-bluetooth+bounces-4129-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4129-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F3A221C224E5 for ; Fri, 26 Apr 2024 20:42:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD24D2C1A7; Fri, 26 Apr 2024 20:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=penguintechs.org header.i=@penguintechs.org header.b="bo6+aveC" X-Original-To: linux-bluetooth@vger.kernel.org Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7027A2907 for ; Fri, 26 Apr 2024 20:42:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714164159; cv=none; b=l6snjy3FihT9YzSKYgeRr6+eJf4b+vWuogLG+70Lw8lOfAzloh9FcFI1719A7Q4/Ravw8X8yBMdCOZeNTZdrk7iH9dR05OSLbO6euNpicBlinqhhdrC4KumKYDsjP2SbJMu8v0BJTXAOr3LYPGyNqXLOAH1uX1igsVhz5H63w6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714164159; c=relaxed/simple; bh=Ut2/7QtHb1M2bAQEQd183O3h2QD+aXNEeV9+hYPipro=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oVkF+5insrTBcvMgX7NYPUf3zuWm02IybYFCQH6Z2QG+Jd1eNPDcFXTQG340dr62eJiDxtH5fGLsx1qYtP21Lzzld1oTPs45THMv66K0POprFyaVCXMZaTh7qjpOSX7vB4nchzBCAsvMq7yLQ0VijSP37mnPxW0V2UdSSYtD2Bg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=penguintechs.org; spf=pass smtp.mailfrom=penguintechs.org; dkim=pass (1024-bit key) header.d=penguintechs.org header.i=@penguintechs.org header.b=bo6+aveC; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=penguintechs.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=penguintechs.org Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2a484f772e2so1824973a91.3 for ; Fri, 26 Apr 2024 13:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=penguintechs.org; s=google; t=1714164156; x=1714768956; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ut2/7QtHb1M2bAQEQd183O3h2QD+aXNEeV9+hYPipro=; b=bo6+aveCALQzYCYe8T2ITmMyQMwfjsihSiKROoFpMYKMwJBOgy4g25++0kic7wjhEh uXfJwep9ZmXrM5pNvB/lRYQG626wViJAdgMjnJLQwPB+HJLGxS54a/KcBzfol+x0gJ/4 ib00yboa+FIH7PJOmCBr3rDxvftCQXj1Zz6nY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714164156; x=1714768956; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ut2/7QtHb1M2bAQEQd183O3h2QD+aXNEeV9+hYPipro=; b=kkLnrEWME0oTh+RkZmAuil5r/1wefHG2kYKomZceFtyqT4OjCuT6CWU+RnMICfP30F Ej69ye4d/PgHKmiQafRMQ3y5BDOCF43ZxsvB60Bjyu7bTkyv5v+QChRl9xiu1VALKgFB gt8zalttSC4q3lOmAw3dWEBpq04TyH0VxIk+/+W2+ObuXTpAyxHQbmZYNF8VgFVjJ7G+ Ht/Hf65V1hvJXVsYEawmdMu2HuIb/j3pPMDCZt9L0qtNVlcIFcGd8/uSD6NBVi89ccPS FbS9PI/6q3hsCmaU8PQdoFOM5V8UuubeX6YSo/0+EQdhKLPEJGlKQS19RYIcZQ2KAu4d Dp1A== X-Forwarded-Encrypted: i=1; AJvYcCUBl+SnpVSizBT3WSfFrL7n4eKZaMtEJRstxDiPMDpeDg+W3F9lKnmJOiWBlaCMmRfNbyGFaZkxakjvihlpTfYjcuUZrmbRWwaCYAX7cQp7 X-Gm-Message-State: AOJu0Yw/R8iSInTMWYdRQVoQ+c9jL6So96OU7ht1cxZ2GAvgf2yN2QQo kCpAmnffwAyq9/5lyZEfzSsnOadfz8SBUddxQsI+a6orlQ/7mvYKnnJwXFnveA== X-Received: by 2002:a17:90a:ad86:b0:2a2:5860:dea8 with SMTP id s6-20020a17090aad8600b002a25860dea8mr3784343pjq.7.1714164156414; Fri, 26 Apr 2024 13:42:36 -0700 (PDT) Received: from braindead.localdomain ([2601:646:8700:dd30:5f3e:5ba7:e0ea:9a08]) by smtp.gmail.com with ESMTPSA id 9-20020a17090a0b8900b002a2e4b593cdsm18187936pjr.51.2024.04.26.13.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 13:42:35 -0700 (PDT) From: Wren Turkal To: Zijun Hu , linux-bluetooth@vger.kernel.org Cc: luiz.dentz@gmail.com, luiz.von.dentz@intel.com, marcel@holtmann.org, linux-bluetooth@vger.kernel.org, bartosz.golaszewski@linaro.org, krzysztof.kozlowski@linaro.org, regressions@lists.linux.dev, kernel@quicinc.com, stable@vge.kernel.org, Greg KH Subject: Re: [PATCH v7 2/2] Bluetooth: qca: Fix BT enable failure for QCA6390 after disable then warm reboot Date: Fri, 26 Apr 2024 13:42:33 -0700 Message-ID: <5600892.rdbgypaU67@braindead.localdomain> In-Reply-To: <2024042330-boat-launch-aaec@gregkh> References: <1713932807-19619-1-git-send-email-quic_zijuhu@quicinc.com> <1713932807-19619-3-git-send-email-quic_zijuhu@quicinc.com> <2024042330-boat-launch-aaec@gregkh> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Tuesday, April 23, 2024 9:34:43=E2=80=AFPM PDT Greg KH wrote: > On Wed, Apr 24, 2024 at 12:26:47PM +0800, Zijun Hu wrote: > > From: Zijun Hu > >=20 > > Commit 272970be3dab ("Bluetooth: hci_qca: Fix driver shutdown on closed > > serdev") will cause below regression issue: > >=20 > > BT can't be enabled after below steps: > > cold boot -> enable BT -> disable BT -> warm reboot -> BT enable failure > > if property enable-gpios is not configured within DT|ACPI for QCA6390. > >=20 > > The commit is to fix a use-after-free issue within qca_serdev_shutdown() > > during reboot, but also introduces this regression issue regarding above > > steps since the VSC is not sent to reset controller during warm reboot. > >=20 > > Fixed by sending the VSC to reset controller within qca_serdev_shutdown= () > > once BT was ever enabled, and the use-after-free issue is also be fixed > > by this change since serdev is still opened when send to serdev. > >=20 > > Fixes: 272970be3dab ("Bluetooth: hci_qca: Fix driver shutdown on closed > > serdev") Cc: stable@vge.kernel.org >=20 > That is not a valid email address :( @ziljun, can you please post this patch in a new patch series by itself? Th= e=20 warm boot problem is fixed by this patch, and I think it would be better to= =20 have a thread dedicated to this fix so that it doesn't get lost. =46WIW, I think that this may be the correct technical change. I would like= to=20 try to help get this patch landed, and I think a clean thread for only this= =20 change would help. Just so everyone is aware, I am a concerned user of the hardware, and not a= =20 kernel dev myself. I have tested this change. This patch on top of Linus'=20 mainline does allow qca6390 to work after warm reboot on my laptop. wt =2D-=20 You're more amazing than you think!