Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp437619lqm; Wed, 1 May 2024 05:35:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWfVJN106bfPnr2S/WzY/nTsslsSsI5QiZb3AY91a0eCfn28F547Br4kfm5rUtriDB+G8p1vvrRIYZcsCoIPVDJebycAswvvSr0Gsp7Xg== X-Google-Smtp-Source: AGHT+IGODp8znsEtlUhNmNhhEZADKKZhYw8KZWhc0at2/wU55URdnCmUWO2PLtPglC1LwmeoV3nn X-Received: by 2002:a9d:6414:0:b0:6eb:d349:8c3f with SMTP id h20-20020a9d6414000000b006ebd3498c3fmr2293137otl.28.1714566955797; Wed, 01 May 2024 05:35:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714566955; cv=pass; d=google.com; s=arc-20160816; b=sFW7c/frTkdDGjt91EXCNO/j7fx1XQeDJjC3QzZ299tYHhe7Q8oWVMlzgPKu8mT2HJ Lr7XXhzFPMy+nwmYt0U8RrLMAoYPkjPqineCvOFl77EVTiq0xSCnfo7Tq7/k89NIIay8 zrCRpIqQxW1Ki77k2kYE8d/GFLG2SDUzVli/GTdOXESRcliK7YfgsI9vhczSzKlmszIs LvEF6LhYGSRHe5Xj4b5LoYvjoaLdMASoiuFXh0NWCgBIvP9q78/XznDzR5ldv4cqmV98 4l77UGXUHqwkh/e3CIbNXL4pctF1IJjp4XBfDDkXuf7BFgWgWbRTxmouONMM+rhhcHn4 vUHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=w+yI5+ifbpQF0RuY5SD4iTm7v+IgAZauqpmOu5dlnKY=; fh=n5hoXCcICd4GmAQfEUaLPJaVS9/1rKrgJl6OqEI3S/s=; b=lm65g1ImWXuDrsg5aOlBDwXuxwk/Yp1R6v5300AqKNtKCp1gUMdciRW3AWqGo8Slru O7VnnyXv1TLEwrN9Sqb/JIeC0GZpYIOUE1ssfbPbnlcI9rbqFaXL88Dn5AGjYA7FBrtl NdS4qJSNlsZ1BU5OM889FMJec3fBmaF/cMmcg/Fi/riADxanqdbX+rY2EDoAyDXdXMFv pUk54w3aTIIw96hKgMe5++Ad4lX+kvZXBpc/FgHk2O3R8t9Z5Cz/8MkxoVUsPdkulU/+ 6pT1aOvnm9W4zVyqEQCA9OD5hn2Yq9/UryOhuAvJqNLhwPkmtYAtHp8PdmLxZrGh8qIu O30g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A3QKPWsC; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-4228-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4228-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id o10-20020a0562140e4a00b006a0cf287e92si6926960qvc.503.2024.05.01.05.35.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 05:35:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4228-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A3QKPWsC; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-4228-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4228-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 829331C21936 for ; Wed, 1 May 2024 12:35:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BFB7F12A170; Wed, 1 May 2024 12:35:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A3QKPWsC" X-Original-To: linux-bluetooth@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF8B422313; Wed, 1 May 2024 12:35:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714566914; cv=none; b=qRd07diz6iF3owWZ7hhfMwaMR8sJn6ObjBVhYK/l8BuXL0NceCqBeU9ZzmhT0AsF5R6C6hNBm2p16fD80qBJh4ifVoBXGoWaouR50HrElhUQx+8VaHZw4Ztyy8Oo/qZ7UqpIyVfahcVWV1Odp5EjvwreXOqDLRUw9pEyEld9Rsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714566914; c=relaxed/simple; bh=38GjNkh+bP9qOQWBippcQ8WykGLhFZV02w+RzMyVR7o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fiezs14/oN/dsSQNsUu5ugA0/45X2fib9gas3RjOAj8WvXzmAhSxL/Z9Lw1kSkYc/lb60rQbHzpuLipA2TeKz16+mdd4FanhoDPOebV/RUHXBVBdfBapaLQf/KxwxGIqdbUjLv6N5ZNCSkCQWPqEZxIiDg9/FW+npIjbEojt/S0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A3QKPWsC; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3485DC4AF1C; Wed, 1 May 2024 12:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714566914; bh=38GjNkh+bP9qOQWBippcQ8WykGLhFZV02w+RzMyVR7o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A3QKPWsCEt+N/9hYwDUIfmI03tymgX5lslI9OoJrD9pGWK1jegwFxPi7Ud11B4BJX nxJMsZGmXdpkcxkQgFWHx5HkK75pakwIq2vMnVUTc23kx2pfB6UHVLIA0piUed7klh Nk55tOh8w+M/n+87TIOPYXkG5Q4EzV/+2XJ/HyzfyueKuJB1fvxtM2OLflev+mEMqp y0KqvZUgFDmtuibhM2Y9CIg7FjA2MwsWyB3u8PhyNmItzOy7wPCZoXi8Ssouuk4vvo DRyYxgiwyDWOrK39AnptFeDnKe72k/c0CgedpFuz1pDv0jXQ2LkPflIroAAuP1FXjZ 0vXbE6o0gpZxg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1s29B7-000000001l9-0iYI; Wed, 01 May 2024 14:35:17 +0200 From: Johan Hovold To: Marcel Holtmann , Luiz Augusto von Dentz Cc: Janaki Ramaiah Thota , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 5/5] Bluetooth: qca: clean up defines Date: Wed, 1 May 2024 14:34:56 +0200 Message-ID: <20240501123456.6712-6-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240501123456.6712-1-johan+linaro@kernel.org> References: <20240501123456.6712-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Clean up the QCA driver defines by dropping redundant parentheses around values and making sure they are aligned (using tabs only). Signed-off-by: Johan Hovold --- drivers/bluetooth/btqca.h | 60 +++++++++++++++++++-------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/bluetooth/btqca.h b/drivers/bluetooth/btqca.h index 215433fd76a1..bb5207d7a8c7 100644 --- a/drivers/bluetooth/btqca.h +++ b/drivers/bluetooth/btqca.h @@ -5,33 +5,33 @@ * Copyright (c) 2015 The Linux Foundation. All rights reserved. */ -#define EDL_PATCH_CMD_OPCODE (0xFC00) -#define EDL_NVM_ACCESS_OPCODE (0xFC0B) -#define EDL_WRITE_BD_ADDR_OPCODE (0xFC14) -#define EDL_PATCH_CMD_LEN (1) -#define EDL_PATCH_VER_REQ_CMD (0x19) -#define EDL_PATCH_TLV_REQ_CMD (0x1E) -#define EDL_GET_BUILD_INFO_CMD (0x20) -#define EDL_GET_BID_REQ_CMD (0x23) -#define EDL_NVM_ACCESS_SET_REQ_CMD (0x01) -#define EDL_PATCH_CONFIG_CMD (0x28) -#define MAX_SIZE_PER_TLV_SEGMENT (243) -#define QCA_PRE_SHUTDOWN_CMD (0xFC08) -#define QCA_DISABLE_LOGGING (0xFC17) - -#define EDL_CMD_REQ_RES_EVT (0x00) -#define EDL_PATCH_VER_RES_EVT (0x19) -#define EDL_APP_VER_RES_EVT (0x02) -#define EDL_TVL_DNLD_RES_EVT (0x04) -#define EDL_CMD_EXE_STATUS_EVT (0x00) -#define EDL_SET_BAUDRATE_RSP_EVT (0x92) -#define EDL_NVM_ACCESS_CODE_EVT (0x0B) -#define EDL_PATCH_CONFIG_RES_EVT (0x00) -#define QCA_DISABLE_LOGGING_SUB_OP (0x14) +#define EDL_PATCH_CMD_OPCODE 0xFC00 +#define EDL_NVM_ACCESS_OPCODE 0xFC0B +#define EDL_WRITE_BD_ADDR_OPCODE 0xFC14 +#define EDL_PATCH_CMD_LEN 1 +#define EDL_PATCH_VER_REQ_CMD 0x19 +#define EDL_PATCH_TLV_REQ_CMD 0x1E +#define EDL_GET_BUILD_INFO_CMD 0x20 +#define EDL_GET_BID_REQ_CMD 0x23 +#define EDL_NVM_ACCESS_SET_REQ_CMD 0x01 +#define EDL_PATCH_CONFIG_CMD 0x28 +#define MAX_SIZE_PER_TLV_SEGMENT 243 +#define QCA_PRE_SHUTDOWN_CMD 0xFC08 +#define QCA_DISABLE_LOGGING 0xFC17 + +#define EDL_CMD_REQ_RES_EVT 0x00 +#define EDL_PATCH_VER_RES_EVT 0x19 +#define EDL_APP_VER_RES_EVT 0x02 +#define EDL_TVL_DNLD_RES_EVT 0x04 +#define EDL_CMD_EXE_STATUS_EVT 0x00 +#define EDL_SET_BAUDRATE_RSP_EVT 0x92 +#define EDL_NVM_ACCESS_CODE_EVT 0x0B +#define EDL_PATCH_CONFIG_RES_EVT 0x00 +#define QCA_DISABLE_LOGGING_SUB_OP 0x14 #define EDL_TAG_ID_BD_ADDR 2 -#define EDL_TAG_ID_HCI (17) -#define EDL_TAG_ID_DEEP_SLEEP (27) +#define EDL_TAG_ID_HCI 17 +#define EDL_TAG_ID_DEEP_SLEEP 27 #define QCA_WCN3990_POWERON_PULSE 0xFC #define QCA_WCN3990_POWEROFF_PULSE 0xC0 @@ -39,7 +39,7 @@ #define QCA_HCI_CC_OPCODE 0xFC00 #define QCA_HCI_CC_SUCCESS 0x00 -#define QCA_WCN3991_SOC_ID (0x40014320) +#define QCA_WCN3991_SOC_ID 0x40014320 /* QCA chipset version can be decided by patch and SoC * version, combination with upper 2 bytes from SoC @@ -48,11 +48,11 @@ #define get_soc_ver(soc_id, rom_ver) \ ((le32_to_cpu(soc_id) << 16) | (le16_to_cpu(rom_ver))) -#define QCA_HSP_GF_SOC_ID 0x1200 -#define QCA_HSP_GF_SOC_MASK 0x0000ff00 +#define QCA_HSP_GF_SOC_ID 0x1200 +#define QCA_HSP_GF_SOC_MASK 0x0000ff00 enum qca_baudrate { - QCA_BAUDRATE_115200 = 0, + QCA_BAUDRATE_115200 = 0, QCA_BAUDRATE_57600, QCA_BAUDRATE_38400, QCA_BAUDRATE_19200, @@ -71,7 +71,7 @@ enum qca_baudrate { QCA_BAUDRATE_1600000, QCA_BAUDRATE_3200000, QCA_BAUDRATE_3500000, - QCA_BAUDRATE_AUTO = 0xFE, + QCA_BAUDRATE_AUTO = 0xFE, QCA_BAUDRATE_RESERVED }; -- 2.43.2