Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4257-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Mahesh Talewad <mahesh.talewad@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: devyani.godbole@nxp.com,
	luiz.dentz@gmail.com,
	sarveshwar.bajaj@nxp.com,
	mahesh.talewad@nxp.com
Subject: [PATCH Bluetooth v2 1/1] LE Create Connection command timeout increased to 20 secs
Date: Thu,  2 May 2024 12:01:23 +0300
Message-Id: <20240502090123.5177-2-mahesh.talewad@nxp.com>
In-Reply-To: <20240502090123.5177-1-mahesh.talewad@nxp.com>
References: <20240502090123.5177-1-mahesh.talewad@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?WLtvhloYEHsiI+LLaKBSAfr4hsRzPh6FbLuZOUpZ+C6oIkkA5wXCcb8eQaXJ?=
 =?us-ascii?Q?XHmKItH1v9UY8KGPfBmJ9VLsUafkQheVg4JT68sFIiIvwVKAI/7V7oM7HTv1?=
 =?us-ascii?Q?TlpQTDvI+0975cxBTDuOtxrXgv6poxsJQJv7Kc3AQiqycQz93wZwXjUDyTmz?=
 =?us-ascii?Q?WnOU//YRvA9vSmSwp+eEKHrf8Gxjbz54dg7mTLJsQ+Dwsu4EZu1V5oKZoMXY?=
 =?us-ascii?Q?02mmvtTOEbUyT7Mq73ATmWtTp0i2JRWXqXHOzRep1AuVO8i7xcNf8UcAufZc?=
 =?us-ascii?Q?KVBYiQ7OsrKWIquYHLenup8LhXBjOeLHhpP2p3SYoWuqIpfRYf2eoyJJwsft?=
 =?us-ascii?Q?sB1JhlUmApyif1I9Ae4qkNqf7r6/SOdMwk1Fubq5lbDnP6ku0ouct5JaVWky?=
 =?us-ascii?Q?FGr9j1jXcROTX25/zHqxXneGXeLVn0d+IH9u63rS2RcBfpvf9ioFRvPAod12?=
 =?us-ascii?Q?rafkDCmJWS1a8jaNJ6xa/7VC7p8AmDnYyZ0CMxp3TH9ylBwIoq3ybqFgjUZc?=
 =?us-ascii?Q?CX0c+bNVyLT+MZQbZ+/1/QpNJ4fRYxiRGmAgM/RdxyZidg0zFkbOuyvffgxn?=
 =?us-ascii?Q?XNVPDPcMBYRufzItq2k06mGl5lCuDWTpU/0RuXABqynHBOFaLYkpuPvHAAjK?=
 =?us-ascii?Q?H0+8j0S6rmAtkt/ZFxztwYwSeGeMeJfCJB35k5jhQxsPEtGyFKwADiyV4Up0?=
 =?us-ascii?Q?Gxamgo+fk1RJmtaPMw3T6as1yPM2ZcxaGz6K9BGLAhknw0iz1+PQ84A+SFBj?=
 =?us-ascii?Q?FvWHrHWJZ4WH6/JHz2WdchTl2WzhjCUKJUTc3qEP1lriJWRFpd7qceagGpLG?=
 =?us-ascii?Q?HVztCl14dqqBw3Owgw+vUFSi4zv+7/ACo6yOuR/ibNATE+Hz7n6Y87lAU8Tq?=
 =?us-ascii?Q?KqQpXKAXPHf2tBG10xIF1+CDL4PV/nBoNOxH+isELUxgqtYmbKnLptF+/L/Z?=
 =?us-ascii?Q?ye+MEj5rIgbvYhx34JIjZa/sxWDebN3oRxuaER+x/OS1+GQmU8WNEIg/Luzh?=
 =?us-ascii?Q?qK15oWU4fmsIZTLlDBlKngGeW6Btiw5kRX+F49LInuU0rWSq6hkiU12F8sNw?=
 =?us-ascii?Q?/vI91/4XG0/JoaJRHawdKq70WjpW7YWOb7RXBEshVTMJYqtsCYLHJfnQeSSb?=
 =?us-ascii?Q?nUU1LstMLfBB8eNOiF1ismVg37PLg2IbPd71YcWy7o2R9doLBhBQB5/fRN1H?=
 =?us-ascii?Q?fYTb2kG55wqDwQOb6yjjzWJdMMy42YEJ0Wll+UiEo+JIzQ7RDFKT4yxLWtyk?=
 =?us-ascii?Q?dCyq3IBcn7sRatt0C0PGK0KuzHLBFCWqCRFqcSmsBW1erY2jwnt4ZjF9ZCgf?=
 =?us-ascii?Q?dPgGSLVlygK50zn1v7cZhthD46rEDRoK58YLuaOIOZ2BweV0CSbWcMbxUarO?=
 =?us-ascii?Q?6lORDI5Pgj1qBVhIA/9RIgJPnmL1QbHIA3kQzm1z8L6sTxMmBkiYfXn7X2ar?=
 =?us-ascii?Q?G8How4E0qMn+5kdHhBd+SxNEH9CbQQ4tXjGGieNXP3mtE5qJOSfxO1gRI/RZ?=
 =?us-ascii?Q?4kyl83bUIAiB+O0HU4ovGtkzWsHQVk7g+J51d/lW4mh+eWQpBqA30kbiClo/?=
 =?us-ascii?Q?Hx+OJaiA/kQBTLt2SWcyhbnohy21VSzNaW+AfLygXgDBgM3+HrLO3dqvzcl0?=
 =?us-ascii?Q?iw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d6b887f-18e6-4853-36bc-08dc6a867f81
X-MS-Exchange-CrossTenant-AuthSource: AS5PR04MB9754.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 09:01:47.7938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /vJCQlB+cEKns9MC99nfoBCfqHDTpaRhm9vsiK6dj7RPHekjOTGJ6WSr0oIIK15plpysvrDZ0jsI5ZF60UuSag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7932

On our DUT, we can see that the host issues create connection cancel
command after 4-sec if there is no connection complete event for
LE create connection cmd.
As per core spec v5.3 section 7.8.5, advertisement interval range is-

Advertising_Interval_Min
Default : 0x0800(1.28s)
Time Range: 20ms to 10.24s

Advertising_Interval_Max
Default : 0x0800(1.28s)
Time Range: 20ms to 10.24s

If the remote device is using adv interval of > 4 sec, it is
difficult to make a connection with the current timeout value.
Also, with the default interval of 1.28 sec, we will get only
3 chances to capture the adv packets with the 4 sec window.
Hence we want to increase this timeout to 20sec.

Signed-off-by: Mahesh Talewad <mahesh.talewad@nxp.com>
---
 include/net/bluetooth/hci.h | 1 -
 net/bluetooth/hci_core.c    | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 8701ca5f31ee..a0f13a213e12 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -447,7 +447,6 @@ enum {
 #define HCI_AUTO_OFF_TIMEOUT	msecs_to_jiffies(2000)	/* 2 seconds */
 #define HCI_ACL_CONN_TIMEOUT	msecs_to_jiffies(20000)	/* 20 seconds */
 #define HCI_LE_CONN_TIMEOUT	msecs_to_jiffies(20000)	/* 20 seconds */
-#define HCI_LE_AUTOCONN_TIMEOUT	msecs_to_jiffies(4000)	/* 4 seconds */
 
 /* HCI data types */
 #define HCI_COMMAND_PKT		0x01
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 1690ae57a09d..f5aa7448de30 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -2549,7 +2549,7 @@ struct hci_dev *hci_alloc_dev_priv(int sizeof_priv)
 	hdev->le_rx_def_phys = HCI_LE_SET_PHY_1M;
 	hdev->le_num_of_adv_sets = HCI_MAX_ADV_INSTANCES;
 	hdev->def_multi_adv_rotation_duration = HCI_DEFAULT_ADV_DURATION;
-	hdev->def_le_autoconnect_timeout = HCI_LE_AUTOCONN_TIMEOUT;
+	hdev->def_le_autoconnect_timeout = HCI_LE_CONN_TIMEOUT;
 	hdev->min_le_tx_power = HCI_TX_POWER_INVALID;
 	hdev->max_le_tx_power = HCI_TX_POWER_INVALID;
 
-- 
2.34.1