Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4273-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240502021709.141220-1-iam@sung-woo.kim>
In-Reply-To: <20240502021709.141220-1-iam@sung-woo.kim>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Thu, 2 May 2024 10:48:13 -0400
Message-ID: <CABBYNZLcfQ-sQ8+=5hebVsXC9qZp+Akq-V4SY0hL4FukfwEaQw@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: HCI: Fix potential null-ptr-deref
To: Sungwoo Kim <iam@sung-woo.kim>
Cc: daveti@purdue.edu, benquike@gmail.com, 
	Marcel Holtmann <marcel@holtmann.org>, Johan Hedberg <johan.hedberg@gmail.com>, 
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Sungwoo,

On Wed, May 1, 2024 at 10:22=E2=80=AFPM Sungwoo Kim <iam@sung-woo.kim> wrot=
e:
>
> Dear all,

Not sure if you are following what I actually enter as patch
description, that normally doesn't include things like Dear all, etc.

> hci_le_big_sync_established_evt() has a potential null-ptr-deref bug.
>
> hci_le_big_sync_established_evt()
>   bis =3D hci_conn_hash_lookup_handle(hdev, handle);
>   if (!bis)
>     bis =3D hci_conn_add() <- could fail
>   /* ... */
>   bis =3D hci_conn_hash_lookup_handle(hdev, handle);
>   set_bit(HCI_CONN_BIG_SYNC_FAILED, &bis->flags); <- null-ptr-deref
>
> There is a missing check after hci_conn_hash_lookup_handle(), which can
> return NULL. Especially, if a prior hci_conn_add() fails than
> hci_conn_hash_lookup_handle() will return NULL.
>
> This patch fixes this by adding a check.

Nor the one below.

> Thanks,
> Sungwoo.

And by now I'd expect you to start adding the Fixes tag as well.

> Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>
> ---
>  net/bluetooth/hci_event.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 4a27e4a17..d72d238c1 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -7037,6 +7037,8 @@ static void hci_le_big_sync_established_evt(struct =
hci_dev *hdev, void *data,
>                         u16 handle =3D le16_to_cpu(ev->bis[i]);
>
>                         bis =3D hci_conn_hash_lookup_handle(hdev, handle)=
;
> +                       if (!bis)
> +                               continue;
>
>                         set_bit(HCI_CONN_BIG_SYNC_FAILED, &bis->flags);
>                         hci_connect_cfm(bis, ev->status);
> --
> 2.34.1
>


--=20
Luiz Augusto von Dentz