Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4282-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <CAD=FV=V-pG9+5fLonNvydmjS=ziUFUHAyF8T7YTkEHiO405aSA@mail.gmail.com>
 <ZizKmtcUIYAMpvOQ@hovoldconsulting.com> <dbba45d2-f955-4d3a-aeab-26b0900d5823@quicinc.com>
 <Zi-ohCWv58d2h5VM@hovoldconsulting.com> <CABBYNZJyqrNKebwPPPqjOAdrkpBJ0fqHyD2iVtypeQKCDcL+AQ@mail.gmail.com>
 <CABBYNZJyRR9FA7TYN4+aWMtG9FPUBWMvCtMNUfvaEzxVcYOt-g@mail.gmail.com>
 <ZjCYu2pc8376rjXk@hovoldconsulting.com> <9eebd77b-c070-4260-a979-9b97f14eb5b1@quicinc.com>
 <ZjDtDRCHT3z-3nHh@hovoldconsulting.com> <a09ab4e3-699b-4eb7-bc64-44c9de6db78d@quicinc.com>
 <ZjNm3OnJ1fdHctaZ@hovoldconsulting.com> <1feddcbc-205d-4c9b-bde2-7a2daace71a9@quicinc.com>
In-Reply-To: <1feddcbc-205d-4c9b-bde2-7a2daace71a9@quicinc.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Thu, 2 May 2024 13:32:38 -0400
Message-ID: <CABBYNZK7MVRoOcFq8Ea8-ZqZq_fE=46WE+5_XMoj2KPnz_ePBw@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: qca: generalise device address check
To: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
Cc: Johan Hovold <johan@kernel.org>, Doug Anderson <dianders@chromium.org>, 
	Johan Hovold <johan+linaro@kernel.org>, Marcel Holtmann <marcel@holtmann.org>, 
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, 
	stable@vger.kernel.org, quic_mohamull@quicinc.com, quic_hbandi@quicinc.com, 
	quic_anubhavg@quicinc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Janaki,

On Thu, May 2, 2024 at 1:03=E2=80=AFPM Janaki Ramaiah Thota
<quic_janathot@quicinc.com> wrote:
>
> Hi Johan,
>
> On 5/2/2024 3:41 PM, Johan Hovold wrote:
> > On Thu, May 02, 2024 at 12:35:19PM +0530, Janaki Ramaiah Thota wrote:
> >> On 4/30/2024 6:37 PM, Johan Hovold wrote:
> >
> >>> But here we disagree. A non-unique address is not a valid one as it w=
ill
> >>> cause collisions if you have more than one such controller.
> >>>
> >>> I understand that this may be convenient/good enough for developers i=
n
> >>> some cases, but this can hurt end users that do not realise why thing=
s
> >>> break.
> >>>
> >>> And a developer can always configure an address manually or patch the
> >>> driver as needed for internal use.
> >>>
> >>> Are there any other reasons that makes you want to keep the option to
> >>> configure the device address through NVM files? I'm assuming you're n=
ot
> >>> relying on patching NVM files to provision device-specific addresses
> >>> after installation on target?
> >
> >> We prefer unique address to be flashed on OTP (persistent) memory of
> >> BT-Chip, which is supported by almost all QC BT-chips.
> >
> > Yes, that is certainly the best option for everyone.
> >
> >> If someone is not able to do that/ does not prefer that, they still
> >> have an option to flash unique address in firmware binary (NVM)file.
> >> This does not require setting BD address from user space.
> >>
> >> Also until a developer flashes OTP/ keep unique BD-Address in NVM,
> >> he should be able to run most of the use cases from Device, that's
> >> why we want to make it as configured.
> >
> > Ok, but a developer can still do this since they can patch the driver t=
o
> > disable the check temporarily or, alternatively, just update the
> > devicetree with a valid unique address.
> >
> >> In our opinion this provides best Out of box experience.
> >
>
> If a developer has to patch a code/update device-tree, that is not
> a "out of box" experience. By "out of box" we meant, things should
> work without much changes required.
>
> > You can also look into improving support in user space (e.g. bluez) for
> > providing a valid unique address in a simple text-based configuration
> > file.
> >
>
> We don't think putting a must-have dependency in user space is the
> right thing to do, especially when we own a code in kernel space.
>
> > That would be useful for all Linux users and not require having access
> > to Qualcomm specific tools to update the NVM configuration file (which
> > could also be in a read-only file system, e.g. on Android).
> >
>
> Having a non-unique valid address allows a developer to handle all
> scenarios where he/she is dealing with DUT + commercial device and
> in such case, default BD-Address from nvm file should also be okay.
> Only when 2/more similar devices are in the mix, they need unique
> address. In that case we are providing end developers with a NVM
> utility(part of Qcom build Not open source tool)to change this
> default BD-Address.

And we don't agree with doing that, that is why the controller shall
be marked as unconfigured when a non-unique address is used and if you
insist in doing that I will probably have to escalate that you guys
are intentionally using addresses that can clash over the air.

If the firmware is intended for developer, it shall be kept private,
public firmware shall never use duplicate addresses, ever, and don't
come back with arguments like that only when 2/more similar devices
are in the mix but that would just stress even more the point that you
are breaking stuff _on purpose_, which is pretty bad by itself, and
then suggesting to use a non-open-source tool to fix the address is
making things worse because end users can be affected by this, that
really fills like you don't care if your hardware works on regular
Linux distros and in that case I will probably move it to
driver/staging.

> > Johan
>
> -Janaki Ram


--=20
Luiz Augusto von Dentz