Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp820656lqh; Sun, 5 May 2024 03:38:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVufJ7zGRwiFxpIHKYmiV+OujGaIuQ4pLW/Mflv7/PxuvSPi8NPBjSdb6XYOoumJQORCfBpV1Mjp0c7/NJeEE3kHc1nzb9kLbVknsckVQ== X-Google-Smtp-Source: AGHT+IFK7+qx+0imSIFWEptDCNPrdqjxzJmoboQ3OgC6QS+KyOG9oCvWlLyWypWPPEU7NDPUJUpD X-Received: by 2002:a17:902:a382:b0:1ed:c526:c93f with SMTP id x2-20020a170902a38200b001edc526c93fmr2250000pla.42.1714905521793; Sun, 05 May 2024 03:38:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714905521; cv=pass; d=google.com; s=arc-20160816; b=CU/P+lKAPVctLO1QRDvpxuA4aGy00grV1z4aqAzMRRmpcYRUPMr5z82mwSyc1DrHU+ 566oY1t6iH4LVDy/Lbv4ZhVgZCnmU629fqdNV1XJeFUO9YQoPPLHXUZfmRPsCMPdlX7A SO2lMNoRgrrM+eXXLrA8nUI6+8XuuvMDeKNh/SV1r6l6jJTEVYGvGq5cUP4gCqxW9GUD Mh5TjnfK+1DH2osCMLRmmVJ5tG9IU5dP0QemXUNTwuEwhym1Frt1sKbOKWNVooYMCbAA 2BasaAL1bzUImIAvks6pfW07UMbGiiVFnw34pXd74yh9mdyKV6c171rIQGLtkd86JIEO cSLw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=bnEpZ4ek9gyxr2Bjc24kTx45c9ZBkO1BONI1X2l8JAc=; fh=v42CYHMfPusvDY0IIDqx1/8Xz+A7sSb3/kzXTePVXJQ=; b=zA9dG1CUtPmSwAQLV/RhTgA0ir6IWeXQQZHtLPAQOQ6IFXkx73nkfxAeigynLeN0cb N/DhYFF/bmmPgDUzhWbbVxyYUcJbsOvtXUIiSLkUnOTzOH3NlmePN1yYoQKR4HB6ZpcW oLge1cqDUm3tkssnTIBSB0EYNIcDmlLxKaQ4Sjf8uBaAD6+6usyneELls3ucHhLIACD/ H8qtBwOp1pj1VEyJ3/iHuF6c5Y/aJmsgfkearx7orCs6RPP2Vyn2E4y/nHsg4v7NFrzc rx+epQuQtk0z/hIwgjBnHRDzQUeXsH1Q+vu9WZYchdmgfUZqGdeGOkk9Hv45Syk9Rjk2 MyVQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b=e6NjzObd; arc=pass (i=1 spf=pass spfdomain=inria.fr dkim=pass dkdomain=inria.fr dmarc=pass fromdomain=inria.fr); spf=pass (google.com: domain of linux-bluetooth+bounces-4318-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4318-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id z3-20020a170902ccc300b001e23e133a76si6741662ple.575.2024.05.05.03.38.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 May 2024 03:38:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4318-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@inria.fr header.s=dc header.b=e6NjzObd; arc=pass (i=1 spf=pass spfdomain=inria.fr dkim=pass dkdomain=inria.fr dmarc=pass fromdomain=inria.fr); spf=pass (google.com: domain of linux-bluetooth+bounces-4318-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4318-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=inria.fr Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 912A7B20D75 for ; Sun, 5 May 2024 10:38:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8CFBB12E7F; Sun, 5 May 2024 10:38:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="e6NjzObd" X-Original-To: linux-bluetooth@vger.kernel.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2FC3566A; Sun, 5 May 2024 10:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.83 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714905500; cv=none; b=i9cj8NR6BhKFwaepbqRlncxCF6c8CZcntui0zjzK5HWGUY70v/5a9kHGQFPSoQuYAsFfiXSdyPgi5m2RHRSU4LU3kG2X2a23wrqjmks06GFlZvZlMzeNoGEgiZfH4qITLb6F6TMAUj0M8sOAYn4Hb8tbuoHp5dxTJ39gchrdgjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714905500; c=relaxed/simple; bh=NNdDnPQlRSRzHhYTvhUK9y1CX1nyF8zPfZQDyiTOiWU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=PhO9WlwmZQNAv+exQvyS47XiAp3HnxuF+2eun9kaPeCugdHlPMqip9JDJ2AGPWOfV9+qd2w2oGeyYxdy/kNwn5utmhMWhVDTPdNc71jfYUEMwqG646rEnnyNVp+bE1WH+raaGw3DKkyS7rti0OUHf+Ntgs8CI5DzeZlQNfRaSHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=e6NjzObd; arc=none smtp.client-ip=192.134.164.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=bnEpZ4ek9gyxr2Bjc24kTx45c9ZBkO1BONI1X2l8JAc=; b=e6NjzObdZj0pnTiWmX/Kyx8s+zgErFHpasKDTDNtbCSezR8JsaBHIgG4 GFCDc+mBO43ATzEb6GuI+jMd+LN4Qc3tZH4YtWhnV7BnRt9U7a0QjPR0c TxdrSc3nl/xfcsdRT5SxYJ4N6YvHgIQ669pcRuILvgZX4qnTODq5B1dEY Q=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.07,256,1708383600"; d="scan'208";a="164542257" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2024 12:37:05 +0200 Date: Sun, 5 May 2024 12:37:05 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Luiz Augusto von Dentz , Marcel Holtmann , linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org, LKML Subject: Re: Bluetooth: qca: Use common error handling code in two functions In-Reply-To: <31f78b18-0caa-45c0-af84-c95d525a13dc@web.de> Message-ID: References: <31f78b18-0caa-45c0-af84-c95d525a13dc@web.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1282540469-1714905425=:3397" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1282540469-1714905425=:3397 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sun, 5 May 2024, Markus Elfring wrote: > >> Add a jump target so that the setting of an error code can be better reused > >> at the end of these function implementations. > … > > This reduces readability, and backwards jumps are rarely desirable. > > Would you like to support any other design approaches better for > the reduction of questionable source code duplication? Maybe cleanup.h can be used to get rid of the kfree_skb. I have no idea. It would be nice to keep the patch in the message so that one could see what is being discussed from the message itself. julia --8323329-1282540469-1714905425=:3397--