Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp224936lqo; Tue, 7 May 2024 19:05:08 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVwHS62JZ9CPyzSScfa5/TJ8YFRkqIzSDuLV4aXS3Ob/VHDW88tLQtd7ihoQjgJQDaQI1JDMLyZIN0R4R19gXI8WkmPVS9P3fRPwi1NvQ== X-Google-Smtp-Source: AGHT+IFEuZR5WPUrtQpR5b4bex1SFtnoLazIu1dANHiMmgqARd+5HGzscnHV52c9Odt0XYLJQaUV X-Received: by 2002:a17:90a:db98:b0:2b2:7c42:bcd7 with SMTP id 98e67ed59e1d1-2b6165bfff9mr1309332a91.21.1715133908099; Tue, 07 May 2024 19:05:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715133908; cv=pass; d=google.com; s=arc-20160816; b=NPuwPIJVCEb1bGW72/onQgQcpsd1sv8h6ZWxeIziuwu/aXQ/9FiMqt4OP7QhWNCxej sRmBC8wPcZ328q36q5UB0uSfw+MhU1N30jBYQoGNQaTeoSuE8DsmQEmbna01NpFT1J1T 03Q6plXqvU8NdsNdzmGvTfwfWxxWiqGpMXP2f3bJdylLhnh7h7EPNzHLZYSWQZ9QZA4D PW0kfsAZeZHCKGZO35Hja8oYkC8YRusuSvjfo0D8wJG1uZfLFLg2moNpLjUFX5gWO2M/ qYdzlvxAwHDtaNck/jNL4hKiQ5l6tOHd3BjM9c35IKk3l9ycQritPRfFPxbsP/f2va9b BpRQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:subject:cc:to:from :date:dkim-signature; bh=7cs2DYztMsIu84Zw3vhCvNyLV8QNKLUq0RSUSWBe2xA=; fh=WIb2YirK2kAoBkkWdCJ/KaF6nXeKMT+FdVw42jCw8xw=; b=vdf6tkjdRVzSZC86Y62ZPxXZ+Wxq/P0OdzKBM5AUnqGi/wslfu2YPN77SOT661gik5 w3K5GJdh0bw3Ugjl8GtElNhwsKB5t3uHEXLFBOJuVYhbCdHl3dyTOD9TDgii6BA748Xu l78zMQCclOieVIMDAxJv5dLP43AkYY/bh9HKRVzWpaQ7lqu1X/qBb856Db9KDBu4ZtdP VtOzqn8tIg+ZiHdcPTzVf4/WylNBS/bmIUrPVJymzGKfql175hpCHNKspTtHjA3V2Iaf 32sNa4No2ddbtIC6MA9MBl21eBlYVuJWZdzoLJq9VTbP8UYIWEn+Anhs87GJBABhZ4Ic mkZA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MCOkBdtv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-4383-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4383-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2b628ea7556si343225a91.122.2024.05.07.19.05.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 19:05:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-4383-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MCOkBdtv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-4383-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-4383-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BB0DB284052 for ; Wed, 8 May 2024 02:05:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5EBCE8F6C; Wed, 8 May 2024 02:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MCOkBdtv" X-Original-To: linux-bluetooth@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1E6B8BE7 for ; Wed, 8 May 2024 02:05:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715133901; cv=none; b=YPeVphoSIU1dw2Te7eyxnEN2fA1UsmgwTbEvd9c1wblxoGMqxmxPM3u2mWUZOs/ZL5/cG7wIbFgIYcRJW8Ts8rV321+Ysjkj+L7PKK6HfBAOc3FgFG1WBnOsr9ZbCDe4HmRDFVmjPVzz2V94yRxfRDA0h/YGJU3Dp9u0It2Kj0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715133901; c=relaxed/simple; bh=nIsmRl78ulinnKkTb7wpc6NtA/a6+ptYO2iLn4YO3SA=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=VO8O3FozJql+7M6ikZpBaC89XIlbPpZTzQgzp3GiN8+f84SPs5fm+VQLzsRMiioQTsxMdICV6bIappKwuESkzPVPyZCHmlY3zxyLXZQrIH8k3aKXdiV3Vdp1BUYHFhZsfaYAc6w+rXZLGTV+HegqWm8T/I57pVgKp//GiP1zync= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MCOkBdtv; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 231DAC2BBFC; Wed, 8 May 2024 02:05:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715133901; bh=nIsmRl78ulinnKkTb7wpc6NtA/a6+ptYO2iLn4YO3SA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=MCOkBdtvf0pkThrK2HOmaN6i8sbBmIAwWsl5NN6hTZ46fFWXAP0RbbkWYpVEjQANt yulWl2ze9uk3FaVqgAdE54sfQqsoApa4hhu3zppGpVgzv4/+QadZ1VKvhYv8ui5lnh 782UilcrODRxJv2bLFNqKYpfIgH9dVDyur2BqEnta1hWD3oT2H0hv5Cig/ZA6j+UJp uZ09bsLxp3IOAMuyiynQD82UG0GFlXF/AhoeJ8k5EBFOCWyoBumPkFo23b0nfOe1Ax Xw6geSSvyHAFyw5cOvqxEhpjTQEJfTv973YqtlFsovfaRkuBidrd9qDbdYrWNgM3Sx dP7U6lpzSR2KQ== Date: Tue, 7 May 2024 21:04:59 -0500 From: Bjorn Helgaas To: Kiran K Cc: linux-bluetooth@vger.kernel.org, ravishankar.srivatsa@intel.com, chethan.tumkur.narayan@intel.com, Chandrashekar Subject: Re: [PATCH v1 3/3] Bluetooth: btintel_pcie: Add *setup* function to download firmware Message-ID: <20240508020459.GA1746498@bhelgaas> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240508020330.GA1746392@bhelgaas> On Tue, May 07, 2024 at 09:03:32PM -0500, Bjorn Helgaas wrote: > On Thu, Mar 28, 2024 at 04:49:04PM +0530, Kiran K wrote: > > Add to support to download firmware. > > > > Signed-off-by: Kiran K > > Co-developed-by: Chandrashekar > > Signed-off-by: Chandrashekar > > > + /* Due to the fw limitation, the type header of the packet should be > > + * 4 bytes unlikely 1 byte for UART. In UART, the firmware can reads > > s/unlikely/unlike/ (I think?) > s/can reads/can read/ Sorry, ignore this. I didn't notice that this was an old thread and just popped up again because somebody else responded to it.